Re: [squid-dev] [PATCH] Fix 'miss_access' and 'cache' checks when no ACL rules matched

2017-06-21 Thread Amos Jeffries
On 12.06.2017 14:14, Eduard Bagdasaryan wrote: On 01.06.2017 17:37, Amos Jeffries wrote: The admin intention here is almost invariably to prevent certain users getting cached data. Preventing cache being used simply for lack of credentials is not a good occurance. Ok, I am leaving 'cache' a

Re: [squid-dev] [PATCH] Fix 'miss_access' and 'cache' checks when no ACL rules matched

2017-06-21 Thread Eduard Bagdasaryan
Any remarks about latest patch before applying? Eduard. On 12.06.2017 14:14, Eduard Bagdasaryan wrote: On 01.06.2017 17:37, Amos Jeffries wrote: The admin intention here is almost invariably to prevent certain users getting cached data. Preventing cache being used simply for lack of credent

Re: [squid-dev] [PATCH] Reduce "!Comm::MonitorsRead(serverConnection->fd)" assertions.

2017-06-21 Thread Alex Rousskov
On 06/21/2017 05:40 AM, Christos Tsantilas wrote: > Replaced primary ConnStateData::pinConnection() calls with a pair of > pinBusyConnection() and notePinnedConnectionBecameIdle() calls, > depending on the pinned connection state ("busy" or "idle"). > > Removed pinConnection() parameters that wer

Re: [squid-dev] [PATCH] Reduce "!Comm::MonitorsRead(serverConnection->fd)" assertions.

2017-06-21 Thread Alex Rousskov
On 06/21/2017 08:24 AM, Amos Jeffries wrote: > On 21/06/17 23:40, Christos Tsantilas wrote: >> * Protect Squid Client classes from new requests that compete with >> ongoing pinned connection use and >> * resume dealing with new requests when those Client classes are done >> using the pinned connect

Re: [squid-dev] [PATCH] Reduce "!Comm::MonitorsRead(serverConnection->fd)" assertions.

2017-06-21 Thread Amos Jeffries
On 21/06/17 23:40, Christos Tsantilas wrote: * Protect Squid Client classes from new requests that compete with ongoing pinned connection use and * resume dealing with new requests when those Client classes are done using the pinned connection. Replaced primary ConnStateData::pinConnection() ca

[squid-dev] [PATCH] Reduce "!Comm::MonitorsRead(serverConnection->fd)" assertions.

2017-06-21 Thread Christos Tsantilas
* Protect Squid Client classes from new requests that compete with ongoing pinned connection use and * resume dealing with new requests when those Client classes are done using the pinned connection. Replaced primary ConnStateData::pinConnection() calls with a pair of pinBusyConnection() and

Re: [squid-dev] [PATCH] squid: let it compile ok for gcc7

2017-06-21 Thread Dengke Du
On 2017年06月21日 15:00, Amos Jeffries wrote: On 21/06/17 14:54, Dengke Du wrote: After the gcc upgrade to gcc7.1, gcc7 contains a number of enhancements that help detect buffer overflow and other forms of invalid memory accesses. We can check the changes here: https://gcc.gnu.org/gcc-7/ch

Re: [squid-dev] [PATCH] squid: let it compile ok for gcc7

2017-06-21 Thread Amos Jeffries
On 21/06/17 14:54, Dengke Du wrote: After the gcc upgrade to gcc7.1, gcc7 contains a number of enhancements that help detect buffer overflow and other forms of invalid memory accesses. We can check the changes here: https://gcc.gnu.org/gcc-7/changes.html When gcc7 compiling squid, it output