Re: [squid-dev] [RFC] WCCP alternatives implentations.

2017-04-02 Thread Garri Djavadyan
On 2017-04-02 14:40, Eliezer Croitoru wrote: I have a project I have been planning and it might take some time but I do want to implement this one. WCCP is a Cisco only protocol so they are the only that benefit from this protocol. AFAIK, WCCP(v2) is Cisco-developed, but is not Cisco-propri

Re: [squid-dev] Fix for the bug 4648

2017-01-06 Thread Garri Djavadyan
On 2016-12-19 22:32, Garri Djavadyan wrote: Please review the fix [1] proposed for bug 4648 [2] in comment 0. It is very primitive, but solves serious issue related to TLS bump. Thanks. [1] http://bugs.squid-cache.org/attachment.cgi?id=3474 [2] http://bugs.squid-cache.org/show_bug.cgi?id=4648

[squid-dev] Fix for the bug 4648

2016-12-19 Thread Garri Djavadyan
Please review the fix [1] proposed for bug 4648 [2] in comment 0. It is very primitive, but solves serious issue related to TLS bump. Thanks. [1] http://bugs.squid-cache.org/attachment.cgi?id=3474 [2] http://bugs.squid-cache.org/show_bug.cgi?id=4648 Garri __

Re: [squid-dev] [squid-announce] Squid 3.5.23/4.0.17 is available

2016-12-17 Thread Garri Djavadyan
On 2016-12-17 21:04, Amos Jeffries wrote: The Squid HTTP Proxy team is very pleased to announce the availability of the Squid-3.5.23/4.0.17 release! Amos, Alex, Francesco, Eduard, Christos and other members of the team! My congratulations to you! Thank you for valuable time spent on contribut

Re: [squid-dev] Automake bug workaround

2016-12-10 Thread Garri Djavadyan
On 2016-12-10 15:41, Amos Jeffries wrote: On 9/12/2016 12:18 p.m., Eliezer Croitoru wrote: What happen with this? Nothing so far. It is not going to be as simple as adding those lines to the configure.ac script unfortunately. There is already a hack in configure.ac to work around some syst

[squid-dev] [PATCH] Prevent public entry purging caused by a request with cc: no-store and no-cache combination

2016-12-07 Thread Garri Djavadyan
Dear Squid developers, Please review the attached patch prepared for r14967 which solves the issue described in bug 2258 [1], but triggered purely by means of Cache-Control header. Particularly, a request for an object with header 'Cache-Control: no-cache, no-store' purges a stored one public

Re: [squid-dev] Fix If-None-Match processing and related bug 4169

2016-12-04 Thread Garri Djavadyan
On Sun, 2016-12-04 at 20:05 -0700, Alex Rousskov wrote: > Actually, in this case, If-None-Match matched (i.e., "no one matched" > is > true). And this is exactly why we can ignore that conditional header > field and treat the request as an unconditional hit. All these > conditional headers have the

Re: [squid-dev] [PATCH] Update refresh_pattern description regarding 'max' option

2016-11-30 Thread Garri Djavadyan
On Thu, 2016-12-01 at 00:56 +1300, Amos Jeffries wrote: > On 21/11/2016 9:58 a.m., Garri Djavadyan wrote: > > > > The patch adds description for undocumented behavior related to > > 'max' > > option of 'refresh_pattern' directive. I mean, 'ma

Re: [squid-dev] Fix If-None-Match processing and related bug 4169

2016-11-30 Thread Garri Djavadyan
On Wed, 2016-11-30 at 07:44 -0700, Alex Rousskov wrote: > On 11/30/2016 04:44 AM, Garri Djavadyan wrote: > > > > * If-Modified-Since header is ignored if If-None-Match header > > exists > > (RFC7232 compliance)  > > > > >  if (r.header.has(Http::Hdr

Re: [squid-dev] Fix If-None-Match processing and related bug 4169

2016-11-30 Thread Garri Djavadyan
On Tue, 2016-11-29 at 15:42 -0700, Alex Rousskov wrote: > On 11/29/2016 02:23 PM, Amos Jeffries wrote: > > > > On 30/11/2016 1:47 a.m., Garri Djavadyan wrote: > > > > > > On Tue, 2016-11-29 at 14:51 +0500, Garri Djavadyan wrote: > > > > > > >

Re: [squid-dev] Fix If-None-Match processing and related bug 4169

2016-11-29 Thread Garri Djavadyan
On Tue, 2016-11-29 at 14:51 +0500, Garri Djavadyan wrote: > Hello, > > Please review the attached patch prepared for r14958, it fixes the > If- > None-Match processing (incorrect logging [1]) and the bug [2] report > 4169 depending on the incorrect (IMO) behavior. > >

[squid-dev] Fix If-None-Match processing and related bug 4169

2016-11-29 Thread Garri Djavadyan
Hello, Please review the attached patch prepared for r14958, it fixes the If- None-Match processing (incorrect logging [1]) and the bug [2] report 4169 depending on the incorrect (IMO) behavior. An If-None-Match request for a non-matched (ETag) but cached object should be processed as normal HIT.

[squid-dev] [PATCH] Update refresh_pattern description regarding 'max' option

2016-11-20 Thread Garri Djavadyan
The patch adds description for undocumented behavior related to 'max' option of 'refresh_pattern' directive. I mean, 'max' option sets value for 'Cache-Control: max-age' header sent by Squid upstream. Feel free to modify the description. Thanks. Garri=== modified file 'src/cf.data.pre' --- src

Re: [squid-dev] Build fails after update to rev. 14954

2016-11-20 Thread Garri Djavadyan
On 2016-11-21 01:22, Garri Djavadyan wrote: Hello, the build fails with the following error: Making all in compat make[1]: Entering directory '/usr/local/src/squid/trunk/compat' make[1]: *** No rule to make target 'GnuRegex.c', needed by 'GnuRegex.lo'. Stop. ma

[squid-dev] Build fails after update to rev. 14954

2016-11-20 Thread Garri Djavadyan
Hello, the build fails with the following error: Making all in compat make[1]: Entering directory '/usr/local/src/squid/trunk/compat' make[1]: *** No rule to make target 'GnuRegex.c', needed by 'GnuRegex.lo'. Stop. make[1]: Leaving directory '/usr/local/src/squid/trunk/compat' make: *** [Makef

[squid-dev] [PATCH] Fix for bug 3290

2016-11-16 Thread Garri Djavadyan
Dear developers, Please review the attached patch for Squid-5 fixing the issue explained in the bug report 3290 [1]. The issue is still reproducible using rev. 14947. The problem exists because Squid resets expiration time for a user on every successful authentication, regardless where the user w

[squid-dev] [PATCH] Fix for bug 4630

2016-11-15 Thread Garri Djavadyan
Hello, Please review the attached one-line patch for Squid-5 fixing the issue described in the report [1]. Thanks in advance! [1] http://bugs.squid-cache.org/show_bug.cgi?id=4630 Garri=== modified file 'src/auth/CredentialsCache.cc' --- src/auth/CredentialsCache.cc 2016-01-01 00:12:18 + +++

[squid-dev] [PATCH] Fix for the bug 3533

2016-11-12 Thread Garri Djavadyan
Dear developers, The attached patch fixes the bug 3533 [1], still existing in trunk (revno: 14938). The problem relates to the fact that the code 303 (scSeeOther) is not considered by Squid as a one permitted to remove public store entries. Below is excerpt from src/http.cc: 180 /// Remov

Re: [squid-dev] [PATCH] Fix spelling for digest nonce cache maintenance event

2016-11-06 Thread Garri Djavadyan
On 2016-11-03 08:18, Amos Jeffries wrote: On 2/11/2016 9:12 p.m., Garri Djavadyan wrote: Please apply the patch to fix spelling for digest nonce cache maintenance event. The patch is for Squid 4.0.16. Thanks. Thanks. Applied to trunk as rev.14910. Amos Same problem in 3.5 branch. The

[squid-dev] [PATCH] Fix spelling for digest nonce cache maintenance event

2016-11-02 Thread Garri Djavadyan
Please apply the patch to fix spelling for digest nonce cache maintenance event. The patch is for Squid 4.0.16. Thanks. Garri--- src/auth/digest/Config.cc 2016-11-02 12:16:24.093510602 +0500 +++ src/auth/digest/Config.cc 2016-11-02 12:17:25.755333833 +0500 @@ -215,7 +215,7 @@ if (!digest_nonc

[squid-dev] [PATCH] Fix debug message in ACLChecklist::bannedAction()

2016-10-29 Thread Garri Djavadyan
Hello, Please apply the patch to fix the debug line (version 3.5.22). Thanks. Garri--- src/acl/Checklist.cc 2016-10-29 22:09:06.143778825 +0500 +++ src/acl/Checklist.cc 2016-10-29 22:09:49.380604810 +0500 @@ -397,7 +397,7 @@ ACLChecklist::bannedAction(const allow_t &action) const { const