Re: [squid-dev] [PATCH] Bug 3819: "fd >= 0" assertion in file_write() during reconfiguration

2016-09-20 Thread Alex Rousskov
On 09/20/2016 11:58 AM, Alex Rousskov wrote: > On 09/20/2016 04:10 AM, Amos Jeffries wrote: >> On 20/09/2016 9:52 a.m., Alex Rousskov wrote: >>> The attached trunk patch fixes bug 3819 in our tests. > >> +1. Thank you. > > Committed with one additional fix to trunk (r14815 and r14816).

Re: [squid-dev] [PATCH] Bug 3819: "fd >= 0" assertion in file_write() during reconfiguration

2016-09-20 Thread Alex Rousskov
On 09/20/2016 04:10 AM, Amos Jeffries wrote: > On 20/09/2016 9:52 a.m., Alex Rousskov wrote: >> The attached trunk patch fixes bug 3819 in our tests. > +1. Thank you. Committed with one additional fix to trunk (r14815 and r14816). The bug report has a v3.5 patch providing the same fix:

Re: [squid-dev] [PATCH] Bug 3819: "fd >= 0" assertion in file_write() during reconfiguration

2016-09-20 Thread Amos Jeffries
On 20/09/2016 9:52 a.m., Alex Rousskov wrote: > Hello, > > The attached trunk patch fixes bug 3819 in our tests. > > Please note that the underlying problem may lead to other assertions, > including "NumberOfUFSDirs" in UFSSwapDir and "fd >= 0" in file_close(). > > Since trunk r9181.3.1,

[squid-dev] [PATCH] Bug 3819: "fd >= 0" assertion in file_write() during reconfiguration

2016-09-19 Thread Alex Rousskov
Hello, The attached trunk patch fixes bug 3819 in our tests. Please note that the underlying problem may lead to other assertions, including "NumberOfUFSDirs" in UFSSwapDir and "fd >= 0" in file_close(). Since trunk r9181.3.1, reconfiguration is done in at least two steps: First,