Re: [squid-dev] [PATCH] GnuTLS session redo

2016-09-04 Thread Amos Jeffries
On 16/08/2016 7:53 p.m., Amos Jeffries wrote: > Friendly ping. This is getting close to the 10-day merge criteria. > Anyone other than me had time to test (or audit) the lastest patch? > Applied the latest updated patch to trunk as r14817. Amos ___ sq

Re: [squid-dev] [PATCH] GnuTLS session redo

2016-08-16 Thread Amos Jeffries
Friendly ping. This is getting close to the 10-day merge criteria. Anyone other than me had time to test (or audit) the lastest patch? Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] GnuTLS session redo

2016-08-08 Thread Amos Jeffries
On 6/08/2016 9:41 a.m., Alex Rousskov wrote: > On 08/05/2016 02:13 PM, Amos Jeffries wrote: >> On 6/08/2016 6:37 a.m., Alex Rousskov wrote: >>> On 08/03/2016 11:57 PM, Amos Jeffries wrote: +Security::SetSessionResumeData(const Security::SessionPointer &s, const Security::SessionStatePoin

Re: [squid-dev] [PATCH] GnuTLS session redo

2016-08-05 Thread Alex Rousskov
On 08/04/2016 03:40 AM, Amos Jeffries wrote: > On 4/08/2016 5:57 p.m., Amos Jeffries wrote: > I'm also wondering if it would be useful to add debugs() in the Get/Set > functions for debugging session resume usage. If we do not have that already, I think it would be very useful to add debugging th

Re: [squid-dev] [PATCH] GnuTLS session redo

2016-08-05 Thread Alex Rousskov
On 08/05/2016 02:13 PM, Amos Jeffries wrote: > On 6/08/2016 6:37 a.m., Alex Rousskov wrote: >> On 08/03/2016 11:57 PM, Amos Jeffries wrote: >>> +Security::SetSessionResumeData(const Security::SessionPointer &s, const >>> Security::SessionStatePointer &data) >>> +{ >>> +if (data) { >>> +#if USE

Re: [squid-dev] [PATCH] GnuTLS session redo

2016-08-05 Thread Amos Jeffries
On 6/08/2016 6:37 a.m., Alex Rousskov wrote: > On 08/03/2016 11:57 PM, Amos Jeffries wrote: >> +Security::SetSessionResumeData(const Security::SessionPointer &s, const >> Security::SessionStatePointer &data) >> +{ >> +if (data) { >> +#if USE_OPENSSL >> +(void)SSL_set_session(s.get(), d

Re: [squid-dev] [PATCH] GnuTLS session redo

2016-08-05 Thread Alex Rousskov
On 08/03/2016 11:57 PM, Amos Jeffries wrote: > +Security::SetSessionResumeData(const Security::SessionPointer &s, const > Security::SessionStatePointer &data) > +{ > +if (data) { > +#if USE_OPENSSL > +(void)SSL_set_session(s.get(), data.get()); > +#elif USE_GNUTLS > +(void)gnut

Re: [squid-dev] [PATCH] GnuTLS session redo

2016-08-04 Thread Amos Jeffries
On 4/08/2016 5:57 p.m., Amos Jeffries wrote: > Attached is an updated version of the TLS session resume patch which was > previously reverted due to a crash issue. > > Trunk no longer needs the implicit conversion that turned out to be > behind that issue. However, I would still like to get this c

[squid-dev] [PATCH] GnuTLS session redo

2016-08-03 Thread Amos Jeffries
Attached is an updated version of the TLS session resume patch which was previously reverted due to a crash issue. Trunk no longer needs the implicit conversion that turned out to be behind that issue. However, I would still like to get this change tested by someone with OpenSSL to confirm that th