Re: [squid-dev] [PATCH] ICAP trailer support

2016-11-14 Thread Amos Jeffries
On 13/11/2016 7:01 a.m., Eduard Bagdasaryan wrote: > 2016-11-11 8:27 GMT+03:00 Amos Jeffries : > >> In Adaptation::Icap::ModXact::expectIcapTrailers() please use >> getByIdIfPresent(Http::TRAILER, ...) since Trailer is a registered >> header. > > Fixed. > >> In answer to "TODO: should we add a n

Re: [squid-dev] [PATCH] ICAP trailer support

2016-11-12 Thread Eduard Bagdasaryan
2016-11-11 8:27 GMT+03:00 Amos Jeffries : > In Adaptation::Icap::ModXact::expectIcapTrailers() please use > getByIdIfPresent(Http::TRAILER, ...) since Trailer is a registered > header. Fixed. > In answer to "TODO: should we add a new Http::scInvalidTrailer?" only if > the draft defines an HTTP

Re: [squid-dev] [PATCH] ICAP trailer support

2016-11-10 Thread Amos Jeffries
On 10/11/2016 7:29 a.m., Alex Rousskov wrote: > On 11/09/2016 08:16 AM, Amos Jeffries wrote: >> On 9/11/2016 3:05 a.m., Eduard Bagdasaryan wrote: >>> Also simplified and fixed headers isolating code while dealing with >>> empty (i.e. zero header fields) headers. Old httpMsgIsolateHeaders() >>> trie

Re: [squid-dev] [PATCH] ICAP trailer support

2016-11-09 Thread Alex Rousskov
On 11/09/2016 08:16 AM, Amos Jeffries wrote: > On 9/11/2016 3:05 a.m., Eduard Bagdasaryan wrote: >> Also simplified and fixed headers isolating code while dealing with >> empty (i.e. zero header fields) headers. Old httpMsgIsolateHeaders() >> tried to re-implement header end detection/processing lo

Re: [squid-dev] [PATCH] ICAP trailer support

2016-11-09 Thread Amos Jeffries
On 9/11/2016 3:05 a.m., Eduard Bagdasaryan wrote: > Hello, > > This patch introduces the initial ICAP trailer support. ICAP trailers are > currently specified by > https://datatracker.ietf.org/doc/draft-rousskov-icap-trailers/. For now, > Squid logs and ignores all parsed ICAP header fields. In f

[squid-dev] [PATCH] ICAP trailer support

2016-11-08 Thread Eduard Bagdasaryan
Hello, This patch introduces the initial ICAP trailer support. ICAP trailers are currently specified by https://datatracker.ietf.org/doc/draft-rousskov-icap-trailers/. For now, Squid logs and ignores all parsed ICAP header fields. In future we plan to add code for using ICAP trailers for transac