Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-10-03 Thread Shively, Gregory
> > +cmd.append("\" && $8 == \""); > > +cmd.append("ESTABLISHED:ESTABLISHED\" {print $5}'"); > > These should probably be merged into one. If no other changes are needed, > this merge can be done during commit. > Sounds good. I've gone ahead and made the changes and including. > > +

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-30 Thread Alex Rousskov
On 09/30/2016 10:37 AM, Amos Jeffries wrote: > Please make sure that your code debugs() dumps the full pfctl line(s) > received at level DBG_DATA, and (only) on errors the relevant bit at a > higher level like 2 or 3 - the other functions debug output can give This approach is outdated because Raw

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-30 Thread Amos Jeffries
On 1/10/2016 4:04 a.m., Shively, Gregory wrote: >> Must(false) just throws an exception. Where that exception will be >> caught before main() when thrown from your code, I do not know >> (perhaps you already do). Must(false) is just a trick to check >> whether all exceptions in your code will be ca

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-30 Thread Alex Rousskov
On 09/30/2016 09:04 AM, Shively, Gregory wrote: > How about I get rid of the loop all together All other factors being equal, a single statement is better than a loop with a similar statement inside. > - I should be > only getting one line from pfctl, and if the parsing fails -I should > probabl

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-30 Thread Shively, Gregory
> Must(false) just throws an exception. Where that exception will be caught > before main() when thrown from your code, I do not know (perhaps you > already do). Must(false) is just a trick to check whether all exceptions in > your > code will be caught/handled the way you want. The alternative is

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-29 Thread Alex Rousskov
On 09/29/2016 03:48 PM, Shively, Gregory wrote: >>> I wasn't sure if I should handle it or let it flow up, since if it was >>> in an overflow state I would doubt I could handle this packet, but >>> maybe the next connection would be successful. >> I recommend temporary adding an exception with Mus

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-29 Thread Shively, Gregory
> -Original Message- > From: Alex Rousskov [mailto:rouss...@measurement-factory.com] > Sent: Thursday, September 29, 2016 4:12 PM > To: squid-dev@lists.squid-cache.org > Cc: Shively, Gregory > Subject: [EXTERNAL] Re: [squid-dev] [PATCH] OSX transparent-proxy using >

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-29 Thread Alex Rousskov
On 09/29/2016 01:12 PM, Shively, Gregory wrote: > Sometimes these mailing lists make me think like I'm talking to one > person :-). Glad we all sound coherent to you :-)! > ERROR: files left in build directory after distclean: > ./src/cf_gen.dSYM/Contents/Info.plist > ./src/cf_gen.dSYM/Contents

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-29 Thread Shively, Gregory
> -Original Message- > From: Alex Rousskov [mailto:rouss...@measurement-factory.com] > Sent: Wednesday, September 28, 2016 6:05 PM > To: squid-dev@lists.squid-cache.org > Cc: Shively, Gregory > Subject: [EXTERNAL] Re: [squid-dev] [PATCH] OSX transparent-proxy using >

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-28 Thread Alex Rousskov
On 09/28/2016 12:18 PM, Shively, Gregory wrote: > The one-time warning sounds like a good idea. Is there a place that > you have to add the one-time message, or should I just add a static variable > to determine if the warning has been displayed the first time down this code > path? If nobody rec

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-28 Thread Shively, Gregory
> -Original Message- > From: Alex Rousskov [mailto:rouss...@measurement-factory.com] > Sent: Monday, September 26, 2016 4:07 PM > To: squid-dev@lists.squid-cache.org > Cc: Shively, Gregory > Subject: [EXTERNAL] Re: [squid-dev] [PATCH] OSX transparent-proxy using > pfc

Re: [squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-26 Thread Alex Rousskov
On 09/26/2016 12:59 PM, Shively, Gregory wrote: > The patch calls /sbin/pfctl to get the > redirect state information For every intercepted connection, this patch forks Squid to start a shell (which then starts pfctl and awk) and then blocks Squid on that shell output, right? That feels very expe

[squid-dev] [PATCH] OSX transparent-proxy using pfctl

2016-09-26 Thread Shively, Gregory
Hello, I had discussed with Amos a couple weeks back on the user mailing list with regards to getting a transparent proxy setup on an OSX machine. I'm having some issues running the test-builds.sh, but they all look like they are associated with compiling on OSX with deprecated APIs that are er