[squid-dev] [PATCH] Remove ServerOptions "partial copy" copy constructor

2016-04-06 Thread Alex Rousskov
Hello, The attached patch removes broken and, AFAICT, unused "partial copy" ServerOptions copy constructor. I am not intimate with the affected code, so more work may be needed around this change: If the partial copy constructor was meant to be abused for something, then a new approach should

Re: [squid-dev] [PATCH] Remove ServerOptions "partial copy" copy constructor

2016-04-07 Thread Amos Jeffries
On 7/04/2016 6:10 p.m., Alex Rousskov wrote: > Hello, > > The attached patch removes broken and, AFAICT, unused "partial copy" > ServerOptions copy constructor. > > I am not intimate with the affected code, so more work may be needed > around this change: If the partial copy constructor was m

Re: [squid-dev] [PATCH] Remove ServerOptions "partial copy" copy constructor

2016-04-07 Thread Alex Rousskov
On 04/07/2016 03:22 AM, Amos Jeffries wrote: > On 7/04/2016 6:10 p.m., Alex Rousskov wrote: >> The attached patch removes broken and, AFAICT, unused "partial copy" >> ServerOptions copy constructor. > A (full) copy-constructor is needed on some systems for the clear() > method implementation

Re: [squid-dev] [PATCH] Remove ServerOptions "partial copy" copy constructor

2016-04-09 Thread Amos Jeffries
On 8/04/2016 2:57 a.m., Alex Rousskov wrote: > On 04/07/2016 03:22 AM, Amos Jeffries wrote: >> On 7/04/2016 6:10 p.m., Alex Rousskov wrote: >>> The attached patch removes broken and, AFAICT, unused "partial copy" >>> ServerOptions copy constructor. > > >> A (full) copy-constructor is needed o

Re: [squid-dev] [PATCH] Remove ServerOptions "partial copy" copy constructor

2016-04-11 Thread Alex Rousskov
On 04/09/2016 11:03 PM, Amos Jeffries wrote: > On 8/04/2016 2:57 a.m., Alex Rousskov wrote: >> On 04/07/2016 03:22 AM, Amos Jeffries wrote: >>> On 7/04/2016 6:10 p.m., Alex Rousskov wrote: The attached patch removes broken and, AFAICT, unused "partial copy" ServerOptions copy construc