Re: [squid-dev] [PATCH] renaming StoreEntryStream to PackableStream

2015-08-31 Thread Amos Jeffries
On 24/08/2015 7:44 a.m., Amos Jeffries wrote: > Okay. Added the flushing but left the existing StoreEntry logic bug in > place. > > Also re-added the flush/buffer unit testing since that is now Packable > API relevant. > > Everything that auditor script you posted complains about now is > intenti

Re: [squid-dev] [PATCH] renaming StoreEntryStream to PackableStream

2015-08-23 Thread Amos Jeffries
Okay. Added the flushing but left the existing StoreEntry logic bug in place. Also re-added the flush/buffer unit testing since that is now Packable API relevant. Everything that auditor script you posted complains about now is intentional whitespace polish. In the side topic of Big3 rules this

Re: [squid-dev] [PATCH] renaming StoreEntryStream to PackableStream

2015-08-23 Thread Alex Rousskov
On 08/22/2015 04:18 AM, Amos Jeffries wrote: > On 22/08/2015 5:44 a.m., Alex Rousskov wrote: >> On 08/21/2015 04:38 AM, Amos Jeffries wrote: >>> So PackableStream is really just a rename of StoreEntryStream BUT with >>> some implicit new properties from the underlying type change: >>> >>> * lack of

Re: [squid-dev] [PATCH] renaming StoreEntryStream to PackableStream

2015-08-22 Thread Amos Jeffries
On 22/08/2015 5:44 a.m., Alex Rousskov wrote: > On 08/21/2015 04:38 AM, Amos Jeffries wrote: >> So PackableStream is really just a rename of StoreEntryStream BUT with >> some implicit new properties from the underlying type change: >> >> * lack of Store.h dependency >> >> * ability to stream into a

Re: [squid-dev] [PATCH] renaming StoreEntryStream to PackableStream

2015-08-21 Thread Alex Rousskov
On 08/21/2015 04:38 AM, Amos Jeffries wrote: > So PackableStream is really just a rename of StoreEntryStream BUT with > some implicit new properties from the underlying type change: > > * lack of Store.h dependency > > * ability to stream into a MemBuf if its creator desires that > > This patch

[squid-dev] [PATCH] renaming StoreEntryStream to PackableStream

2015-08-21 Thread Amos Jeffries
So PackableStream is really just a rename of StoreEntryStream BUT with some implicit new properties from the underlying type change: * lack of Store.h dependency * ability to stream into a MemBuf if its creator desires that This patch demonstrates that by doing the upgrade in-place and re-typing