Re: [squid-dev] [RFC] [PREVIEW] LockingPointer round 3.

2016-07-21 Thread Alex Rousskov
On 07/21/2016 07:58 AM, Amos Jeffries wrote: > void resetWithoutLocking(T *t) { > +#if USE_OPENSSL > +assert(!t || t->references > 0); > +assert(!raw || raw->references > 0); > +if (raw && t == raw) { > +assert(raw->references > 1); // us plus caller locks >

Re: [squid-dev] [RFC] [PREVIEW] LockingPointer round 3.

2016-07-21 Thread Amos Jeffries
On 21/07/2016 5:54 a.m., Alex Rousskov wrote: > On 07/19/2016 10:45 PM, Amos Jeffries wrote: >> On 19/07/2016 7:14 p.m., Amos Jeffries wrote: >>> On 19/07/2016 6:58 a.m., Christos Tsantilas wrote: On 07/18/2016 08:32 PM, Alex Rousskov wrote: > I can only repeat my earlier suggestions to hi

Re: [squid-dev] [RFC] [PREVIEW] LockingPointer round 3.

2016-07-20 Thread Alex Rousskov
On 07/19/2016 10:45 PM, Amos Jeffries wrote: > On 19/07/2016 7:14 p.m., Amos Jeffries wrote: >> On 19/07/2016 6:58 a.m., Christos Tsantilas wrote: >>> On 07/18/2016 08:32 PM, Alex Rousskov wrote: I can only repeat my earlier suggestions to hide that dangerous constructor behind an explici

[squid-dev] [RFC] [PREVIEW] LockingPointer round 3.

2016-07-19 Thread Amos Jeffries
On 19/07/2016 7:14 p.m., Amos Jeffries wrote: > On 19/07/2016 6:58 a.m., Christos Tsantilas wrote: >> On 07/18/2016 08:32 PM, Alex Rousskov wrote: > > Dropping the non-locking constructor and forcing explicit resetFoo() is > probably for the best. Though it would not have helped in this case. I >