Re: [squid-dev] RFC: Modernizing sources using clang-tidy

2020-06-01 Thread Francesco Chemolli
> > > > IMO we would be better off going the scripted way to remove the subset > > of cases we can automate and catch the rest with manual edits and in > review. > > I do not see a point of automating ourselves if there is an existing > automation that works much better than anything we can do ours

Re: [squid-dev] RFC: Modernizing sources using clang-tidy

2020-05-31 Thread Alex Rousskov
On 5/30/20 3:22 PM, Amos Jeffries wrote: > On 20/04/20 2:02 pm, Alex Rousskov wrote: >> Squid sources contain a lot of poorly written, obsolete, and >> inconsistent code that (objectively) complicates development and >> (unfortunately) increases tensions among developers during review. >> >> So

Re: [squid-dev] RFC: Modernizing sources using clang-tidy

2020-05-30 Thread Amos Jeffries
On 20/04/20 2:02 pm, Alex Rousskov wrote: > Hello, > > Squid sources contain a lot of poorly written, obsolete, and > inconsistent code that (objectively) complicates development and > (unfortunately) increases tensions among developers during review. > > Some of those problems can be solved

[squid-dev] RFC: Modernizing sources using clang-tidy

2020-04-19 Thread Alex Rousskov
Hello, Squid sources contain a lot of poorly written, obsolete, and inconsistent code that (objectively) complicates development and (unfortunately) increases tensions among developers during review. Some of those problems can be solved using tools that modify sources. Clang-tidy is one such