On 13/01/2016 10:53 p.m., Eduard Bagdasaryan wrote:
> Addressed your comments in [t2] patch.
> Also polished ACLFilledChecklist::fd(int) similarly.
>
> Eduard.
>
Thank you. Applied as trunk rev.14491.
Amos
___
squid-dev mailing list
squid-dev@lists.s
Addressed your comments in [t2] patch.
Also polished ACLFilledChecklist::fd(int) similarly.
Eduard.
2016-01-13 8:05 GMT+03:00 Amos Jeffries :
in src/acl/DestinationIp.cc
* please use a "const auto" local variable to store checklist->conn().
- that way you can avoid three de-references and me
On 12/01/2016 6:54 a.m., Eduard Bagdasaryan wrote:
> Hello,
>
> Attaching patch with suggested fix. The fix is
> related to bug 4378.
>
in src/acl/DestinationIp.cc
* please use a "const auto" local variable to store checklist->conn().
- that way you can avoid three de-references and method ca
Hello,
Attaching patch with suggested fix. The fix is
related to bug 4378.
Eduard.
On 19.07.2015 11:10, squid3 at treenet.co.nz (Amos Jeffries) wrote:
On 19/07/2015 3:26 p.m., Alex Rousskov wrote:
How about the following two changes?
1. Change FilledChecklist::conn() to return NULL when conn
On 19/07/2015 3:26 p.m., Alex Rousskov wrote:
>
> How about the following two changes?
>
> 1. Change FilledChecklist::conn() to return NULL when conn_ is invalid.
> 2. Change the above assertion into an if statement, returning -1.
>
>
> If, after the above is done, somebody volunteers to replac
On 07/17/2015 11:31 PM, Amos Jeffries wrote:
> On 18/07/2015 6:09 a.m., Alex Rousskov wrote:
>> Intercepting Squids sometimes fail with the following assertion in
>> ACLDestinationIP::match():
>>
>>> if (Config.onoff.client_dst_passthru && ... intercepted ...) {
>>> assert(checklist
On 18/07/2015 6:09 a.m., Alex Rousskov wrote:
> Hello,
>
> Intercepting Squids sometimes fail with the following assertion in
> ACLDestinationIP::match():
>
>> // Bug 3243: CVE 2009-0801
>> // Bypass of browser same-origin access control in intercepted
>> communication
>> // To r
Hello,
Intercepting Squids sometimes fail with the following assertion in
ACLDestinationIP::match():
> // Bug 3243: CVE 2009-0801
> // Bypass of browser same-origin access control in intercepted
> communication
> // To resolve this we will force DIRECT and only to the original cl
