Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-07-15 Thread Amos Jeffries
Added and applied to trunk as rev.14157. Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-07-15 Thread Alex Rousskov
On 06/26/2015 06:44 AM, Amos Jeffries wrote: > +// invalid character somewhere in the line. > +// As long as we can find the LF, accept the characters > +// which we know are invalid in any URI, but actively used > +LfDelim.add('\0'); // Java > +

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-26 Thread Alex Rousskov
On 06/26/2015 06:44 AM, Amos Jeffries wrote: > On 26/06/2015 7:55 a.m., Alex Rousskov wrote: >> Tokenizer cannot handle URIs with whitespaces directly, like your patch >> attempts to do: Tokenizer alone cannot handle ambiguous grammars. To >> handle such URIs well, you have two options IMO: >> >> A

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-26 Thread Amos Jeffries
On 26/06/2015 7:55 a.m., Alex Rousskov wrote: > On 06/25/2015 08:13 AM, Amos Jeffries wrote: >> Which is why I want to go the route of HTTP/0.9 handling. Its >> clear when products encounter it and cause themselves problems. > > Sigh. You are repeating essentially the same argument as before. Any

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-25 Thread Alex Rousskov
On 06/25/2015 08:13 AM, Amos Jeffries wrote: > Which is why I want to go the route of HTTP/0.9 handling. Its > clear when products encounter it and cause themselves problems. Sigh. You are repeating essentially the same argument as before. Any "let's create problems for something that appears to w

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-25 Thread Eliezer Croitoru
About the shaming idea: I do not like in any way and time to write bad things on anyone. To make sure there is a bug and to make sure where the bug is from I would try to first understand the bug and maybe someone would be able to make this world a better place for programs and programmeres. I

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-25 Thread Amos Jeffries
On 25/06/2015 4:05 p.m., Alex Rousskov wrote: > On 06/24/2015 02:24 PM, Kinkie wrote: >> My 2c: I vote for reality; possibly with a shaming announce message; > > I would recommend against shaming any particular company unless somebody > can personally vouch that that specific company is the one to

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-24 Thread Alex Rousskov
On 06/24/2015 02:24 PM, Kinkie wrote: > My 2c: I vote for reality; possibly with a shaming announce message; I would recommend against shaming any particular company unless somebody can personally vouch that that specific company is the one to blame. I cannot (without a lot more triage work which

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-24 Thread Marcus Kool
On 06/24/2015 05:24 PM, Kinkie wrote: My 2c: I vote for reality; possibly with a shaming announce message; I wouldn't even recommend logging the violation: there is nothing the average admin can do about it. I would consider adding a shaming comment in the release notes. more cents: correct.

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-24 Thread Kinkie
My 2c: I vote for reality; possibly with a shaming announce message; I wouldn't even recommend logging the violation: there is nothing the average admin can do about it. I would consider adding a shaming comment in the release notes. On Wed, Jun 24, 2015 at 10:12 PM, Alex Rousskov wrote: > On 06/

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-24 Thread Alex Rousskov
On 06/24/2015 05:26 AM, Amos Jeffries wrote: > On 24/06/2015 5:55 p.m., Alex Rousskov wrote: >> This temporary trunk fix adds support for request URIs containing >> '|' characters. Such URIs are used by popular Amazon product (and >> probably other) sites: /images/I/ID1._RC|ID2.js,ID3.js,ID4.j

Re: [squid-dev] [PATCH] Temporary fix to restore compatibility with Amazon

2015-06-24 Thread Amos Jeffries
On 24/06/2015 5:55 p.m., Alex Rousskov wrote: > Hello, > > This temporary trunk fix adds support for request URIs containing > '|' characters. Such URIs are used by popular Amazon product (and > probably other) sites: /images/I/ID1._RC|ID2.js,ID3.js,ID4.js_.js > > Without this fix, all reques