Re: C++

2003-03-26 Thread Henrik Nordstrom
Robert Collins wrote: > > On Thu, 2003-03-27 at 04:01, Henrik Nordstrom wrote: > > Something like that yes.. (should not be any () on fd, but that you > > probably notice..) > > Actually, there is in -3 HEAD. It's an accessor method. Right.. some day I promise to get used to C++ way of things..

Re: HIT or MISS?

2003-03-26 Thread Henrik Nordstrom
Daniel Draper wrote: > I think I worked it out. I simply used the http object in > ClientSocketContext and then parsed it as a hit or a miss using > logTypeIsATcpHit() so I had something like: > > int hit = logTypeIsATcpHit(http->logType); > > This worked ok. Thanks for listening to my d

Re: ToS Marking

2003-03-26 Thread Robert Collins
On Thu, 2003-03-27 at 04:01, Henrik Nordstrom wrote: > Something like that yes.. (should not be any () on fd, but that you > probably notice..) Actually, there is in -3 HEAD. It's an accessor method. Rob -- GPG key available at: . signature.asc Des

Re: Squid-2.5 ICAP client

2003-03-26 Thread Henrik Nordstrom
ons 2003-03-26 klockan 16.08 skrev Kinkie: > Are you planning to bring it into HEAD? It might be interesting for my day-job. Not the Squid-2.5 patch no.. If there is a patch for Squid-3 developed I see no major issues with having it integrated into HEAD, assuming the coding style is sane of cour

Re: ToS Marking

2003-03-26 Thread Henrik Nordstrom
Something like that yes.. (should not be any () on fd, but that you probably notice..) Regards Henrik ons 2003-03-26 klockan 15.45 skrev Daniel Draper: > > The client socket is known as the variable "fd" within > > clientSendMoreData. clientSendMoreData is the function within Squid > > which tran

Re: HIT or MISS?

2003-03-26 Thread Daniel Draper
Never mind. I think I worked it out. I simply used the http object in ClientSocketContext and then parsed it as a hit or a miss using logTypeIsATcpHit() so I had something like: int hit = logTypeIsATcpHit(http->logType); This worked ok. Thanks for listening to my dribble anyway. Its 3am

HIT or MISS?

2003-03-26 Thread Daniel Draper
Ok, So when a request is made for a page from a client, squid first checks its store of local files. If the file exists locally then this file is parsed and sent back as an Http response to the client. Is there a flag that indicates whether the file was found locally? Is there a struct that handle

Re: ToS Marking

2003-03-26 Thread Daniel Draper
> The client socket is known as the variable "fd" within > clientSendMoreData. clientSendMoreData is the function within Squid > which transmits HTTP replies to the client. setsockopt(fd(), IPPROTO_IP, IP_TOS, (char *) &tos, sizeof(int)); ??? As far as I can tell this works ok.

Re: Squid-2.5 ICAP client

2003-03-26 Thread Henrik Nordstrom
Ok. So if conn->me.sin_family is not set then the call came from icapReqModReadReply, and the conn and filedescriptor is that of the ICAP server and not the original client? Ugly but works I guess. Need to look into how this affects handling of persistent and/or pipelined client connections. There

Re: Squid-2.5 ICAP client

2003-03-26 Thread Geetha Manjunath
Hello Henrik, This piece of code is related to the call to clientReadRequest from the function icapReqModReadReply in icap.c . The function icapReqModReadReply reads the modified http request from the icap server - which is in reply to a reqmod request - and processes this new request. You will no

Re: ToS Marking

2003-03-26 Thread Henrik Nordstrom
ons 2003-03-26 klockan 08.30 skrev Daniel Draper: > Hi Henrik, > > I'm afraid I don't fully know what you mean. I now realise that I am > modifying the wrong socket but as to where the code should go I placed > the code immediately after httpReplyPack(rep); as you suggested. > > There is an arra