Re: ACL: request max body size

2004-02-12 Thread Henrik Nordstrom
On Thu, 12 Feb 2004, Diego Woitasen (Lanux) wrote: > Sorry, but... Is my patch OK? Almost. To be consistent with the other max_... acls (maxconn, max_user_ip) the condition should be inversed, matching unless above the maximum. Also there is the small issue about Squid-2.5 being a STABLE frozen

Re: ACL: request max body size

2004-02-12 Thread Diego Woitasen (Lanux)
Sorry, but... Is my patch OK? On Thu, Feb 12, 2004 at 09:17:20PM +0100, Henrik Nordstrom wrote: > On Fri, 13 Feb 2004, Robert Collins wrote: > > > Perhaps it would be useful to consolidate with/replace > > request_body_max_size which already exists... > > When this gets merged then the old reques

Open task: SPNEGO authentication

2004-02-12 Thread Henrik Nordstrom
Here is a interesting task for Windows authentication freaks: Now that Samba supports SPNEGO it is about time we start adding support for this to Squid. As far as Squid is concerned the principles of SPNEGO is pretty much the same as NTLM, the difference is mainly in the helper who parses and gene

Re: redirector more like external_auth

2004-02-12 Thread Henrik Nordstrom
On Thu, 12 Feb 2004, Brian Akins wrote: > It would be good if it were possible to send various stuff to the a > redirector. Right now, it is fixed. It would be nice if it could be as > configurable as external_acl. Maybe, but I have a feeling that in many cases the external acl approach is mo

Re: ACL: request max body size

2004-02-12 Thread Henrik Nordstrom
On Fri, 13 Feb 2004, Robert Collins wrote: > Perhaps it would be useful to consolidate with/replace > request_body_max_size which already exists... When this gets merged then the old request_body_max_size should obviously be depreated in favor of the acl approach. Regards Henrik

redirector more like external_auth

2004-02-12 Thread Brian Akins
It would be good if it were possible to send various stuff to the a redirector. Right now, it is fixed. It would be nice if it could be as configurable as external_acl. Anyone have any objections to me exploring this? -- Brian Akins Senior Systems Engineer CNN Internet Technologies

Re: ACL: request max body size

2004-02-12 Thread Robert Collins
On Fri, 2004-02-13 at 00:50, Diego Woitasen (Lanux) wrote: > This patch add a new ACL type: max_body_size. This will be matched when > the client's HTTP request body is greater than X bytes. > > Example: > > acl users max_body_size 10 > > > Comments and suggestions are welcome... Perhaps

ACL: request max body size

2004-02-12 Thread Diego Woitasen (Lanux)
This patch add a new ACL type: max_body_size. This will be matched when the client's HTTP request body is greater than X bytes. Example: acl users max_body_size 10 Comments and suggestions are welcome... diff -Nur squid-2.5.STABLE4-20040208/src/acl.c squid-2.5.STABLE4-20040208-diegows

Re: Archiving, take II.

2004-02-12 Thread Henrik Nordstrom
On Thu, 12 Feb 2004, Magnus Bodin wrote: > A little question arises: Is it possible to make squid use/not use > different parent proxies for different protocols: Yes. See cahce_peer_access/always/never_direct. Regards Henrik

Archiving, take II.

2004-02-12 Thread Magnus Bodin
I finally gave up patching squid to archive everything it retrieved. I went the easy road and put the archiving part in a non-icp parent proxy instead. A little question arises: Is it possible to make squid use/not use different parent proxies for different protocols: * http (This is my pr

Re: Squid-2.5.STABLE5 still not ready

2004-02-12 Thread Henrik Nordstrom
On Thu, 12 Feb 2004, Duane Wessels wrote: > This change looks suspicious to me: > > @@ -199,11 +199,15 @@ > static void > ipcacheAddEntry(ipcache_entry * i) > { > -hash_link *e = hash_lookup(ip_table, i->hash.key); > +ipcache_entry *e = (ipcache_entry *) hash_lookup(ip_table, i->hash.k

Re: Squid-2.5.STABLE5 still not ready

2004-02-12 Thread Henrik Nordstrom
On Thu, 12 Feb 2004, Duane Wessels wrote: > src/ipcache.c had a minor change (+7 -3 lines) on Nov 28 > and a very big change ( +89 -81 lines) on Dec 6. Right.. Don't know what I was on when looking into what changes had been done. Will look very close at these changes again. The changes are cle

Re: Squid-2.5.STABLE5 still not ready

2004-02-12 Thread Henrik Nordstrom
On Thu, 12 Feb 2004, Duane Wessels wrote: > This change looks suspicious to me: > > @@ -199,11 +199,15 @@ > static void > ipcacheAddEntry(ipcache_entry * i) > { > -hash_link *e = hash_lookup(ip_table, i->hash.key); > +ipcache_entry *e = (ipcache_entry *) hash_lookup(ip_table, i->hash.k