Re: squid-3 icap related patch

2006-10-03 Thread Tsantilas Christos
Hi Alex, Alex Rousskov wrote: On Thu, 2006-09-28 at 05:18 -0400, Tsantilas Christos wrote: 3) File ICAP/ICAPModXact.cc function ICAPModXact::handleCommWroteHeaders() Sometimes, we have read the headers but not any part of the body yet so in this case we must not call writeMore()

Re: proposal to remove port 563 from default ACLs

2006-10-03 Thread Henrik Nordstrom
tis 2006-10-03 klockan 00:35 +0200 skrev Henrik Nordstrom: I have actually used it in in real life. Was a some vendor support forum NNTP server requiring authentication and encryption to protect the passwords. But I have no problem with removing the port from the suggested default

Re: squid-3 icap related patch

2006-10-03 Thread Alex Rousskov
On Tue, 2006-10-03 at 11:36 +0300, Tsantilas Christos wrote: Alex Rousskov wrote: I believe zero size content is valid. If writeMore() cannot handle it, writeMore() should be fixed and still called unconditionally in the above code. I believe that the problem here is not the zero sized

Re: squid-3 icap related patch

2006-10-03 Thread Alex Rousskov
On Tue, 2006-10-03 at 08:48 -0600, Alex Rousskov wrote: On Tue, 2006-10-03 at 11:36 +0300, Tsantilas Christos wrote: I believe that the problem here is not the zero sized content. Squid calls this function when read all headers. There are cases in which squids did not read any part of

Re: squid-3 icap related patch

2006-10-03 Thread Adrian Chadd
On Wed, Oct 04, 2006, Tsantilas Christos wrote: Hi, I can not reproduce the problem any more using the squid3-icap sources. I am testing for some hours the icap client and looks OK. I believe that you can ignore this patch. Thanks a lot for your ICAP feedback, and thanks to Alex for