Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Amos Jeffries
Alex Rousskov wrote: rousskov2007/05/22 10:40:06 MDT Modified files: lib MemPool.cc Log: Bug #1966 fix: Use rounded String MemPool sizes in the hard-coded pool config to avoid warnings that the configured pool size does not match the actual size.

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Henrik Nordstrom
tor 2007-05-24 klockan 00:59 +1200 skrev Amos Jeffries: Did you run make check before committing any of the days changes? I'm getting 7 of 14 core unit tests fail. Two on MemPool.cc:240, the rest on silent segfault. Assertion failed: (aLabel != NULL aSize) at MemPool.cc:240 Hmm...

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Robert Collins
On Wed, 2007-05-23 at 22:49 +0200, Henrik Nordstrom wrote: Mem::Init needs to be called via the setUp() method, not from an automatic instantiation constructor.. Actually I spent quite some time making it work correctly without setUp. I think manual setup is very annoying and error prone: if

Re: cvs commit: squid3/src gopher.cc protos.h url.cc

2007-05-23 Thread Henrik Nordstrom
ons 2007-05-23 klockan 14:59 -0600 skrev Henrik Nordstrom: hno 2007/05/23 14:59:15 MDT Modified files: src gopher.cc protos.h url.cc Log: Fix the cppunit tests to use setUp() rather than an static constructor to initialize memory pools etc. Hmm...

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Henrik Nordstrom
tor 2007-05-24 klockan 06:58 +1000 skrev Robert Collins: On Wed, 2007-05-23 at 22:49 +0200, Henrik Nordstrom wrote: Mem::Init needs to be called via the setUp() method, not from an automatic instantiation constructor.. Actually I spent quite some time making it work correctly without

Re: cvs commit: squid/lib rfc1738.c

2007-05-23 Thread Adrian Chadd
On Wed, May 23, 2007, Henrik Nordstrom wrote: hno 2007/05/23 16:00:02 MDT Modified files: lib rfc1738.c Log: MFC: URI-escape using the recommended upper case Ta for doing this; the only reason I didn't touch it when I saw the discrepancy between the

Re: cvs commit: squid/lib rfc1738.c

2007-05-23 Thread Henrik Nordstrom
ons 2007-05-23 klockan 19:35 -0600 skrev Adrian Chadd: Ta for doing this; the only reason I didn't touch it when I saw the discrepancy between the code and RFC (3986 though) is what it might break. I was going to talk to you about it today. I'm not very worried about breakage here. The only

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Alex Rousskov
On Thu, 2007-05-24 at 00:59 +1200, Amos Jeffries wrote: Alex Rousskov wrote: rousskov2007/05/22 10:40:06 MDT Modified files: lib MemPool.cc Log: Bug #1966 fix: Use rounded String MemPool sizes in the hard-coded pool config to avoid warnings that