Re: logic error in httpHdrRangeSpecParseCreate

2007-09-08 Thread Pierangelo Masarati
Wenzhuo Zhang wrote: Hi, squid developers When reading squid-2.6-STABLE15 source code, I found a logical error in the if statement at src/HttpHdrRange.c line 96: if (!((p = strchr(field, '-')) || (p - field = flen))) { If p is NULL, (p - field) is meaningless. If p is not NULL, the

Re: logic error in httpHdrRangeSpecParseCreate

2007-09-08 Thread Adrian Chadd
On Sat, Sep 08, 2007, Pierangelo Masarati wrote: I'm not a Squid developer, but your diagnosis sounds right. Just in case, I think you should file a bug http://www.squid-cache.org/bugs/ so the fix, if confirmed, can be tracked. You analysed a bug; you're a squid developer now! Adrian

Re: cvs commit: squid3 configure.in

2007-09-08 Thread Henrik Nordstrom
On lör, 2007-09-08 at 07:53 +0200, Pierangelo Masarati wrote: I think you don't need to burn your brains too much on this point. Figuring the perfect API out of the blue could mean spend a lot of energies on something that would eventually freeze anyway, and if one really needs a feature that

Re: Contribution to Squid development.

2007-09-08 Thread Pierangelo Masarati
Yet another step: http://www.sys-net.it/~ando/Download/squid-ldap-20070908.patch This will probably be the last for a while because I'll be almost unavailable for a couple of weeks. In any case, now squid_ldap_auth and squid_ldap_group share most of the code, except for the core logic

Re: Contribution to Squid development.

2007-09-08 Thread Adrian Chadd
On Sat, Sep 08, 2007, Pierangelo Masarati wrote: Yet another step: http://www.sys-net.it/~ando/Download/squid-ldap-20070908.patch This will probably be the last for a while because I'll be almost unavailable for a couple of weeks. In any case, now squid_ldap_auth and squid_ldap_group