Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Hi Adrian, I commit some changes to async-calls branch and now compiles (but does not link) without ICAP client enabled. Currently you have to enable ICAP client to build async-calls. The reason is that the src/ICAP/AsyncJob.o used in AsyncCalls but built only as part of ICAP client library.

Re: building async-calls

2007-12-16 Thread Adrian Chadd
On Sun, Dec 16, 2007, Tsantilas Christos wrote: Hi Adrian, I commit some changes to async-calls branch and now compiles (but does not link) without ICAP client enabled. Currently you have to enable ICAP client to build async-calls. The reason is that the src/ICAP/AsyncJob.o used in

Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Adrian Chadd wrote: On Sun, Dec 16, 2007, Tsantilas Christos wrote: Currently you have to enable ICAP client to build async-calls. The reason is that the src/ICAP/AsyncJob.o used in AsyncCalls but built only as part of ICAP client library. OK Adrian I fixed this too. You can build the

Re: building async-calls

2007-12-16 Thread Adrian Chadd
On Sun, Dec 16, 2007, Tsantilas Christos wrote: OK Adrian I fixed this too. You can build the async-calls without enabling of ICAP client. Next question - if I read this code right, a class is instanced for every async callback being scheduled, is this true? Yes this is true. An

Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Adrian Chadd wrote: On Sun, Dec 16, 2007, Tsantilas Christos wrote: Yes this is true. An AsyncCall class instanced for every async callback. And the comm code is going to register one of these per comm events? Yes. Have you benchmarked what that'll do to performance? :) Maybe has some

Re: 3-HEAD IPv6 updates

2007-12-16 Thread Amos Jeffries
Hi Amos, Just a small patch to allow ICAP compile and run with the newly added IPV6 changes. First tests looks good. Regards, Christos Amos Jeffries wrote: I'm done now. Welcome to IPv6 everyone ;-) ... I quick note on this code behaviour. The default

Re: 3-HEAD IPv6 updates

2007-12-16 Thread Amos Jeffries
Hi Amos, Just a small patch to allow ICAP compile and run with the newly added IPV6 changes. First tests looks good. Regards, Christos Amos Jeffries wrote: I'm done now. Welcome to IPv6 everyone ;-) ... I quick note on this code behaviour. The default

Re: 3-HEAD IPv6 updates

2007-12-16 Thread Amos Jeffries
On 16/12/2007 2:28 PM, Henrik Nordstrom wrote: On sön, 2007-12-16 at 14:10 +1100, Reuben Farrelly wrote: Still as of now failing to compile -HEAD for me: clientInterpretRequestHeaders(ClientHttpRequest*)': client_side_request.cc:733: error: 'no_addr' was not declared in this scope

Re: building async-calls

2007-12-16 Thread Adrian Chadd
On Sun, Dec 16, 2007, Tsantilas Christos wrote: Have you benchmarked what that'll do to performance? :) Maybe has some performance penalty. But if there is a performance decrease, I do not think that it is huge. Normally creating a class is not more costly than creating a C struct and

Re: building async-calls

2007-12-16 Thread Amos Jeffries
On Sun, Dec 16, 2007, Tsantilas Christos wrote: Have you benchmarked what that'll do to performance? :) Maybe has some performance penalty. But if there is a performance decrease, I do not think that it is huge. Normally creating a class is not more costly than creating a C struct and

Re: building async-calls

2007-12-16 Thread Adrian Chadd
On Mon, Dec 17, 2007, Amos Jeffries wrote: Adrian, I've tried to do some profiling myself recently but am stuck getting those nice stats you post out of it. (Last time I did profiling was in VisualStudio). Could you send me or the list a how-to on using the cpu-profiling feature, from

Re: astyle

2007-12-16 Thread Alex Rousskov
On Fri, 2007-12-14 at 23:17 +0100, Henrik Nordstrom wrote: On fre, 2007-12-14 at 14:36 -0700, Alex Rousskov wrote: My only regret is that I did not do the astyle check yet. If you can check what the latest astyle does to Squid3, please do that. I think having common automated format

Re: building async-calls

2007-12-16 Thread Amos Jeffries
On Mon, Dec 17, 2007, Amos Jeffries wrote: Adrian, I've tried to do some profiling myself recently but am stuck getting those nice stats you post out of it. (Last time I did profiling was in VisualStudio). Could you send me or the list a how-to on using the cpu-profiling feature, from