Re: building async-calls

2007-12-17 Thread Adrian Chadd
On Sun, Dec 16, 2007, Tsantilas Christos wrote: > > Have you benchmarked what that'll do to performance? :) > > Maybe has some performance penalty. But if there is a performance > decrease, I do not think that it is huge. > Normally creating a class is not more costly than creating a C struct > a

Re: building async-calls

2007-12-17 Thread Robert Collins
On Sun, 2007-12-16 at 21:57 +0900, Adrian Chadd wrote: > On Sun, Dec 16, 2007, Tsantilas Christos wrote: > > > OK Adrian I fixed this too. You can build the async-calls without > > enabling of ICAP client. > > > > > Next question - if I read this code right, a class is instanced > for every > >

Re: building async-calls

2007-12-17 Thread Adrian Chadd
On Mon, Dec 17, 2007, Tsantilas Christos wrote: > Hi Adrian, > As I am seeing squid3 spends time in EventScheduler::schedule method. > This method did not affected by the new AsyncCall code. Also this method > is similar with squid 2.6 eventAdd function. Yes, but you're using an event system wh

Re: building async-calls

2007-12-17 Thread Tsantilas Christos
Hi Adrian, As I am seeing squid3 spends time in EventScheduler::schedule method. This method did not affected by the new AsyncCall code. Also this method is similar with squid 2.6 eventAdd function. The only I can say is that possibly we are scheduling a huge number of events in squid3. If the

ctx cache.log entries

2007-12-17 Thread Tony Dodd
Hi All, I'm running Squid-2.HEAD-20071216 on one of my boxes for testing purposes... overall I'm seeing better performance compared to 2.6STABLE17; however, my cache.log now contains a lot of entries like the following: 2007/12/17 13:17:58| ctx: enter level 0: 'http://ws.audioscrobbler.com

Re: building async-calls

2007-12-17 Thread Tsantilas Christos
Hi Adrian, If you just worry about performance of AsyncCalls/JobCalls design lets waiting to have a progress in AsyncCalls development and see how performs. About the event subsystem in squid, it is less than 500 lines of C/C++ code and looking in it I have in my mind 2-3 easy to implement hacks

astyle

2007-12-17 Thread Alex Rousskov
On Sat, 2007-12-15 at 11:40 +1300, Amos Jeffries wrote: > Alex Rousskov wrote: > > On Fri, 2007-12-14 at 21:35 +0100, Henrik Nordstrom wrote: > >> On fre, 2007-12-14 at 18:26 +1300, Amos Jeffries wrote: > >> > >>> He suggested a big(ger) delay than a few days to wait for bugs to > >>> prevent 'inv

Re: building async-calls

2007-12-17 Thread Adrian Chadd
On Mon, Dec 17, 2007, Tsantilas Christos wrote: > Hi Adrian, > > If you just worry about performance of AsyncCalls/JobCalls design lets > waiting to have a progress in AsyncCalls development and see how performs. Hey I'm glad to, as long as people test resource use regressions as they're developi