Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-03-09 at 22:23 +0100, Henrik Nordstrom wrote: Or we could consider squid.h the dirty one, moving out the little tweaks which is there to config.h or better places. IMO, at the end of the cleanup, "squid.h" should be the file that all sources are guaranteed to

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Alex Rousskov
On Sun, 2008-03-09 at 22:23 +0100, Henrik Nordstrom wrote: > Or we could consider squid.h the dirty one, moving out the little > tweaks which is there to config.h or better places. IMO, at the end of the cleanup, "squid.h" should be the file that all sources are guaranteed to include first simpl

bzr actions

2008-03-09 Thread Amos Jeffries
Robert as the resident bzr expert you may know the answer to this one: As you are probably aware I recently submitted two patches or the cleanup. The first was hideous with all the bootstrap'd changes local to my config an machines. For the second I managed to produce a clean submission by revert

Re: Time for squid 3.0 STABLE2 ?

2008-03-09 Thread Amos Jeffries
> On Fri, 2008-02-29 at 01:13 +1300, Amos Jeffries wrote: >> Hm, yes. Henrik, is there a report somewhere that lgroups the merged >> changesets the same way the maintainer merge.html lists the un-merged >> and non-merged ones? > > There is a merge.html in 2.7 showing what's unique for 2.7 and not m

Re: Time for squid 3.0 STABLE2 ?

2008-03-09 Thread Amos Jeffries
> On Sun, 2008-03-09 at 21:28 +1300, Amos Jeffries wrote: >> 1) I don't have write access to the FTP area to copy the files in. >> I think its /server/ftp/pub/squid-3/STABLE/ anyway. > > Fixed. > >> (The STABLE1 signature files and diff appear to be missing too) > > I have now copied the ST

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Amos Jeffries
> > On Sun, 2008-03-09 at 11:23 -0600, Alex Rousskov wrote: > >> IMO, virtually all Squid sources should include (directly or indirectly) >> squid.h as the first include file. In my experience, this design is very >> useful for portability and other hacks. > > We have two such files > > include/con

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Henrik Nordstrom
On Sun, 2008-03-09 at 11:23 -0600, Alex Rousskov wrote: > IMO, virtually all Squid sources should include (directly or indirectly) > squid.h as the first include file. In my experience, this design is very > useful for portability and other hacks. We have two such files include/config.h proje

Re: Time for squid 3.0 STABLE2 ?

2008-03-09 Thread Henrik Nordstrom
On Fri, 2008-02-29 at 01:13 +1300, Amos Jeffries wrote: > Hm, yes. Henrik, is there a report somewhere that lgroups the merged > changesets the same way the maintainer merge.html lists the un-merged > and non-merged ones? There is a merge.html in 2.7 showing what's unique for 2.7 and not merged

Re: What's in the NT branch

2008-03-09 Thread Henrik Nordstrom
On Sat, 2008-03-01 at 10:57 +0100, Guido Serassio wrote: > This is very critical on the side of the DOS/Unix > text format: Visual Studio doesn't work with Unix text files. > Usually I commit the files on this directory only from Windows machines. Thats easy to deal with, in fact most likely not

Re: Time for squid 3.0 STABLE2 ?

2008-03-09 Thread Henrik Nordstrom
On Sun, 2008-03-09 at 21:28 +1300, Amos Jeffries wrote: > 1) I don't have write access to the FTP area to copy the files in. > I think its /server/ftp/pub/squid-3/STABLE/ anyway. Fixed. > (The STABLE1 signature files and diff appear to be missing too) I have now copied the STABLE1 signat

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Alex Rousskov
On Mon, 2008-03-10 at 00:03 +1300, Amos Jeffries wrote: > - removes squid.h includes from many unit-tests I think this is a step backwards (which may be OK as a temporary measure, but I think there are better ways to deal with the problem at hand). IMO, virtually all Squid sources should include

Robustness project adjustments

2008-03-09 Thread Alex Rousskov
Hello, This email describes upcoming changes in the Squid3 robustness project. The Squid3 robustness project has two related goals: - Prevent Squid from crashing when a non-critical assumption about transaction state fails. Currently, most such assumptions are expressed using fatal assertions

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Amos Jeffries
Bundle Buggy wrote: Bundle Buggy has detected this merge request. For details, see: http://squid-cache.org/bundlebuggy//request/%3C20080309110310.889A6E9FF1%40treenet.co.nz%3E You can ignore this. It went badly and included all the bootstrap-ed file changes. The next submit with a proper

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://squid-cache.org/bundlebuggy//request/%3C20080309110310.889A6E9FF1%40treenet.co.nz%3E

Re: Time for squid 3.0 STABLE2 ?

2008-03-09 Thread Amos Jeffries
Amos Jeffries wrote: Henrik Nordstrom wrote: On Thu, 2008-02-28 at 01:04 +1300, Amos Jeffries wrote: Just a few issues remaining before 3.0.STABLE-2. * patch 11467 back-porting. cd English ls ERR_* >../list * Close more bugs? http://www.squid-cache.org/bugs/show_bug.cgi?id=2127