Re: Features/SourceLayout

2008-03-24 Thread Alex Rousskov
On Tue, 2008-03-25 at 10:29 +1300, Amos Jeffries wrote: > Alex Rousskov wrote: > >> The following page has been changed by Amos Jeffries: > >> http://wiki.squid-cache.org/Features/SourceLayout?action=diff&rev2=9&rev1=8 > > > > Original: > > > >> Question: Can we remove Foo prefix from FOO/!FooSom

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-24 Thread Amos Jeffries
Bernhard Schmidt wrote: Hi, Oh drat. I mis-configured my new test setup. Sorry. Revision 8903 has had a more careful set of tests done and fixes that problem. Confirmed. At least I think so, there was quite some trial and error involved to force the dreaded bzr to sync the trees again (afte

bzr revert

2008-03-24 Thread Amos Jeffries
Robert & Henrik, Some of us have found a knowledge-hole in the bzr revert process. We can easily reverse a patch using for example: bzr revert -r 8902 But then when its fixed we don't know how to undo the undo. The local branch is left with code apparently up-to-date but is actually missi

Re: [squid-users] Squid Future (was Re: [squid-users] Squid-2, Squid-3, roadmap)

2008-03-24 Thread Robert Collins
On Mon, 2008-03-24 at 11:25 +0100, Henrik Nordstrom wrote: > On Sun, 2008-03-23 at 18:29 +0900, Adrian Chadd wrote: > > > The real solution is a tree for offset lookups, and a linear walk of order > > O(1) for subsequent sequential accesses. > > Walking a tree is usually a cheap operation, unless

Re: Features/SourceLayout

2008-03-24 Thread Amos Jeffries
Alex Rousskov wrote: The following page has been changed by Amos Jeffries: http://wiki.squid-cache.org/Features/SourceLayout?action=diff&rev2=9&rev1=8 Original: Question: Can we remove Foo prefix from FOO/!FooSomething.h file names? The prefix carries no additional information and is probably

Re: Valgrind results

2008-03-24 Thread Amos Jeffries
Henrik Nordstrom wrote: On Mon, 2008-03-24 at 00:16 +1300, Amos Jeffries wrote: I care about every potential cause of trouble in squid. Particularly avoidable ones that pop up all the time. 'Zero errors' policy and all that. It may be that this is fixable by setting the first byte of the buff

Re: Bundle Buggy: Voting error

2008-03-24 Thread Alex Rousskov
On Mon, 2008-03-24 at 14:30 -0600, Bundle Buggy wrote: > Submitter "Alex Rousskov <[EMAIL PROTECTED]>" does not > have voting rights Nope. Alex.

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-24 Thread Alex Rousskov
On Mon, 2008-03-24 at 13:57 +0100, Henrik Nordstrom wrote: > On Sun, 2008-03-23 at 23:20 +1200, Amos Jeffries wrote: > > Fix memory leak in Linux builds. bb:comment Just testing whether voting works now. Please ignore. Alex.

Re: Features/SourceLayout

2008-03-24 Thread Alex Rousskov
> The following page has been changed by Amos Jeffries: > http://wiki.squid-cache.org/Features/SourceLayout?action=diff&rev2=9&rev1=8 Original: > Question: Can we remove Foo prefix from FOO/!FooSomething.h file > names? The prefix carries no additional information and is probably > not required

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-24 Thread Bernhard Schmidt
Hi, Oh drat. I mis-configured my new test setup. Sorry. Revision 8903 has had a more careful set of tests done and fixes that problem. Confirmed. At least I think so, there was quite some trial and error involved to force the dreaded bzr to sync the trees again (after altering it locally by

Re: v3 roadmap

2008-03-24 Thread Alex Rousskov
On Mon, 2008-03-24 at 21:29 +1300, Amos Jeffries wrote: > Alex Rousskov wrote: > > On Sun, 2008-03-23 at 15:24 +1300, Amos Jeffries wrote: > >> Henrik Nordstrom wrote: > >>> On Wed, 2008-03-19 at 11:15 +1300, Amos Jeffries wrote: > >>> > - I'm kind of in favour of it as a pure file-movements

Re: [MERGE] Merged from trunk

2008-03-24 Thread Henrik Nordstrom
bb:approve On Mon, 2008-03-24 at 00:03 +1200, Amos Jeffries wrote: > Replace a goto with do-while.

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-24 Thread Henrik Nordstrom
On Sun, 2008-03-23 at 23:20 +1200, Amos Jeffries wrote: > Fix memory leak in Linux builds. bb:approve

Re: Valgrind results

2008-03-24 Thread Henrik Nordstrom
On Mon, 2008-03-24 at 00:16 +1300, Amos Jeffries wrote: > I care about every potential cause of trouble in squid. Particularly > avoidable ones that pop up all the time. 'Zero errors' policy and all that. > > It may be that this is fixable by setting the first byte of the buffer > to '\0'. I'm

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-24 Thread Amos Jeffries
Bernhard Schmidt wrote: Amos Jeffries <[EMAIL PROTECTED]> wrote: Fix memory leak in Linux builds. This one seems to break outgoing IPv4 connects (on a dualstacked Squid) bzr trunk revision 8902 fails with | While trying to retrieve the URL: http://www.heise.de/ | | The following error wa

Re: [squid-users] Squid Future (was Re: [squid-users] Squid-2, Squid-3, roadmap)

2008-03-24 Thread Henrik Nordstrom
On Sun, 2008-03-23 at 18:29 +0900, Adrian Chadd wrote: > The real solution is a tree for offset lookups, and a linear walk of order > O(1) for subsequent sequential accesses. Walking a tree is usually a cheap operation, unless the tree is wrongly designed. You just need to remember the current tr

Re: v3 roadmap

2008-03-24 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-03-23 at 15:24 +1300, Amos Jeffries wrote: Henrik Nordstrom wrote: On Wed, 2008-03-19 at 11:15 +1300, Amos Jeffries wrote: - I'm kind of in favour of it as a pure file-movements-only alteration. 3.2 has no feature-requests yet and back-porting across a fi