Re: Valgrind results

2008-03-25 Thread Henrik Nordstrom
On Tue, 2008-03-25 at 10:23 +1300, Amos Jeffries wrote: I found that in 3.x as well. It turns out those bits of valgrind code only occur if both --enable-leakfinder and --with-valgrind-debug are enabled. My test script only had --with-valgrind which wasn't doing even the job it needed

adaptation sections

2008-03-25 Thread Alex Rousskov
Hello, Should I use the same debugging sections for ICAP, eCAP, and the code they share? Or should we have three distinct debugging sections for those three areas? Thank you, Alex.

Re: Features/SourceLayout

2008-03-25 Thread Amos Jeffries
Alex Rousskov wrote: On Tue, 2008-03-25 at 10:29 +1300, Amos Jeffries wrote: Alex Rousskov wrote: The following page has been changed by Amos Jeffries: http://wiki.squid-cache.org/Features/SourceLayout?action=diffrev2=9rev1=8 Original: Question: Can we remove Foo prefix from

Re: async-call progress

2008-03-25 Thread Alex Rousskov
On Tue, 2008-03-25 at 00:18 +0200, Tsantilas Christos wrote: 1) I convert most of the tunnel.cc to new asyncCalls/CommCalls interface. It looks that works very well (setting the assert_burst_max I am able to completely bypass the bug #2253). If there is not any objection I will commit the

Re: 3.1 steps forward

2008-03-25 Thread Amos Jeffries
Adrian Chadd wrote: On Fri, Feb 15, 2008, Amos Jeffries wrote: Sorry if I was obtuse. I meant that you are the expert on this one. Are you able to re-locate that mysterious branch and estimate when you will have time to sync and push it to HEAD? squid3_logdaemon have you fixed the AddrInfo

Re: Valgrind results

2008-03-25 Thread Robert Collins
On Sun, 2008-03-23 at 20:37 +0900, Adrian Chadd wrote: On Mon, Mar 24, 2008, Amos Jeffries wrote: Adrian Chadd wrote: You can ignore that. If you care that much about the epoll error then just bzero() the data being passed into epoll_ctl() before its called. I care about every potential

Re: bzr revert

2008-03-25 Thread Robert Collins
On Tue, 2008-03-25 at 10:34 +1300, Amos Jeffries wrote: Robert Henrik, Some of us have found a knowledge-hole in the bzr revert process. We can easily reverse a patch using for example: bzr revert -r 8902 But then when its fixed we don't know how to undo the undo. The local

[MERGE] Replace a URN handling set of gotos' with a sub-function.

2008-03-25 Thread Amos Jeffries
Replace a URN handling set of gotos' with a sub-function. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch: file:///src/squid/bzr/cleanup/ # testament_sha1: 23ceddad39c635fcb80fa6d71378c39220fb9f2a # timestamp: 2008-03-25 13:13:05 +1200 #

Re: adaptation sections

2008-03-25 Thread Kinkie
On Tue, Mar 25, 2008 at 5:14 AM, Alex Rousskov [EMAIL PROTECTED] wrote: Hello, Should I use the same debugging sections for ICAP, eCAP, and the code they share? Or should we have three distinct debugging sections for those three areas? IMO the most intuitive approach would be to have

Re: bzr revert

2008-03-25 Thread Henrik Nordstrom
On Tue, 2008-03-25 at 10:34 +1300, Amos Jeffries wrote: Robert Henrik, Some of us have found a knowledge-hole in the bzr revert process. We can easily reverse a patch using for example: bzr revert -r 8902 I prefer using merge. bzr merge -r 8903..8902 to undo revision 8903. that

Re: Features/SourceLayout

2008-03-25 Thread Henrik Nordstrom
On Tue, 2008-03-25 at 11:29 +1300, Amos Jeffries wrote: I missed that email from you. I don't see any huge problems with that approach, as long as we make sure its kept to. Same here, except for some minor human confusion about which file is really meant when someone says just file.h.

Re: adaptation sections

2008-03-25 Thread Henrik Nordstrom
On Mon, 2008-03-24 at 22:14 -0600, Alex Rousskov wrote: Should I use the same debugging sections for ICAP, eCAP, and the code they share? Or should we have three distinct debugging sections for those three areas? I think using the same is appropriate, unless you think there will be a need

Re: adaptation sections

2008-03-25 Thread Amos Jeffries
Alex Rousskov wrote: Hello, Should I use the same debugging sections for ICAP, eCAP, and the code they share? Or should we have three distinct debugging sections for those three areas? I think 2 areas for the unique code at least. Preferrably numerically close. How much of the shared

Re: Valgrind results

2008-03-25 Thread Amos Jeffries
Henrik Nordstrom wrote: On Tue, 2008-03-25 at 10:23 +1300, Amos Jeffries wrote: I found that in 3.x as well. It turns out those bits of valgrind code only occur if both --enable-leakfinder and --with-valgrind-debug are enabled. My test script only had --with-valgrind which wasn't doing even

Re: [MERGE] Replace a URN handling set of gotos' with a sub-function.

2008-03-25 Thread Adrian Chadd
Is there any way to get this stuff to post an actual diff rather than this bundle? Adrian On Tue, Mar 25, 2008, Amos Jeffries wrote: Replace a URN handling set of gotos' with a sub-function. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch:

Re: bzr revert

2008-03-25 Thread Henrik Nordstrom
On Tue, 2008-03-25 at 12:04 +1100, Robert Collins wrote: 'bzr revert' changes the working tree to be the same as a given revision [with optional file list]. If you then do a commit - e.g: bzr revert -r X bzr commit you are committing a changeset that happens to alter previously done work,

Re: [MERGE] Replace a URN handling set of gotos' with a sub-function.

2008-03-25 Thread Henrik Nordstrom
bb:comment patch looks very empty.. On Tue, 2008-03-25 at 13:13 +1200, Amos Jeffries wrote: Replace a URN handling set of gotos' with a sub-function.

Re: Valgrind results

2008-03-25 Thread Henrik Nordstrom
On Tue, 2008-03-25 at 12:23 +1100, Robert Collins wrote: Is it valgrind being wrong, or does epoll actually read from that unitinitialised region? it's valgrind not knowing (or caring about) the full details of when epoll uses what of the supplied data. But generally speaking it's a good

Re: Bundle Buggy: Voting error

2008-03-25 Thread Henrik Nordstrom
Robert? Should I go ahead and set up the needed accounts? On Mon, 2008-03-24 at 14:33 -0600, Alex Rousskov wrote: On Mon, 2008-03-24 at 14:30 -0600, Bundle Buggy wrote: Submitter Alex Rousskov [EMAIL PROTECTED] does not have voting rights Nope. Alex.

Re: Patch submission

2008-03-25 Thread Henrik Nordstrom
On Fri, 2008-03-21 at 14:33 +1300, Amos Jeffries wrote: I've been thinking it would be a good idea to add the patch-cleaning script to the source for people to use for submission. There are a few minor issues to work out still but if you all agree I'll drop it in. Is this the script we

Re: [MERGE] Replace a URN handling set of gotos' with a sub-function.

2008-03-25 Thread Amos Jeffries
Adrian Chadd wrote: Is there any way to get this stuff to post an actual diff rather than this bundle? It does. This one tried to also as you see below. Watchout for this one guys. Committing the patch to trunk before using bzr to submit the diff for bundlebuggy results in an empty patch

Re: Patch submission

2008-03-25 Thread Amos Jeffries
Henrik Nordstrom wrote: On Fri, 2008-03-21 at 14:33 +1300, Amos Jeffries wrote: I've been thinking it would be a good idea to add the patch-cleaning script to the source for people to use for submission. There are a few minor issues to work out still but if you all agree I'll drop it in. Is

Re: adaptation sections

2008-03-25 Thread Alex Rousskov
On Tue, 2008-03-25 at 12:28 +0100, Kinkie wrote: On Tue, Mar 25, 2008 at 5:14 AM, Alex Rousskov [EMAIL PROTECTED] wrote: Should I use the same debugging sections for ICAP, eCAP, and the code they share? Or should we have three distinct debugging sections for those three areas? IMO

Re: Patch submission

2008-03-25 Thread Henrik Nordstrom
On Wed, 2008-03-26 at 01:45 +1300, Amos Jeffries wrote: My current version: Cleans the ~N~ files created during merge. Why? There may be important backups there from earlier reverts run by the user.. Cleans the automake files out of the submitted patch Ok I think, but complex and not

Re: [MERGE] Replace a URN handling set of gotos' with a sub-function.

2008-03-25 Thread Henrik Nordstrom
On Tue, 2008-03-25 at 21:21 +0900, Adrian Chadd wrote: Is there any way to get this stuff to post an actual diff rather than this bundle? It's there. But I think something was wrong with amos submission. Looks very empty with a 0 lines patch and very small bundle.. Regards

Squid-3 compile warning after latest comm.cc changes

2008-03-25 Thread Henrik Nordstrom
Revision 8905: src/comm.cc: In function 'int comm_connect_addr(int, const IPAddress)': src/comm.cc:1144: warning: passing NULL to non-pointer argument 2 of 'void* memset(void*, int, size_t)' make[1]: *** [comm.lo] Error 1

Re: Squid-3 compile warning after latest comm.cc changes

2008-03-25 Thread Amos Jeffries
Henrik Nordstrom wrote: Revision 8905: src/comm.cc: In function 'int comm_connect_addr(int, const IPAddress)': src/comm.cc:1144: warning: passing NULL to non-pointer argument 2 of 'void* memset(void*, int, size_t)' make[1]: *** [comm.lo] Error 1 What compiler are you using for this? Amos

Re: Patch submission

2008-03-25 Thread Amos Jeffries
Henrik Nordstrom wrote: On Wed, 2008-03-26 at 01:45 +1300, Amos Jeffries wrote: My current version: Cleans the ~N~ files created during merge. Why? There may be important backups there from earlier reverts run by the user.. I found 'bzr revert -r submit: cfgaux/*' failed with an error

default aufs

2008-03-25 Thread Amos Jeffries
I think its probably time we added aufs as one of the available default filesystems. Comments? Amos -- Please use Squid 2.6STABLE17+ or 3.0STABLE1+ There are serious security advisories out on all earlier releases.

Re: Including build tag in daily snapshots

2008-03-25 Thread Robert Collins
On Thu, 2008-03-20 at 08:57 -0600, Alex Rousskov wrote: Hello, From http://www.squid-cache.org/bugs/show_bug.cgi?id=2275: User: squid-3.0.STABLE2 compile error. Troubleshooter: Where did you get this 3.0.STABLE2 tree? User: squid-3.0.STABLE2-20080319.tar.gz

Re: Including build tag in daily snapshots

2008-03-25 Thread Robert Collins
On Fri, 2008-03-21 at 14:33 +1300, Amos Jeffries wrote: I've been thinking it would be a good idea to add the patch-cleaning script to the source for people to use for submission. There are a few minor issues to work out still but if you all agree I'll drop it in. FWIW I'd really rather

Re: bzr revert

2008-03-25 Thread Robert Collins
On Tue, 2008-03-25 at 13:04 +0100, Henrik Nordstrom wrote: On Tue, 2008-03-25 at 12:04 +1100, Robert Collins wrote: 'bzr revert' changes the working tree to be the same as a given revision [with optional file list]. If you then do a commit - e.g: bzr revert -r X bzr commit you are

Re: Including build tag in daily snapshots

2008-03-25 Thread Alex Rousskov
On Wed, 2008-03-26 at 10:08 +1100, Robert Collins wrote: On Fri, 2008-03-21 at 14:33 +1300, Amos Jeffries wrote: I've been thinking it would be a good idea to add the patch-cleaning script to the source for people to use for submission. There are a few minor issues to work out still

Re: Bundle Buggy: Voting error

2008-03-25 Thread Robert Collins
On Tue, 2008-03-25 at 13:09 +0100, Henrik Nordstrom wrote: Robert? Should I go ahead and set up the needed accounts? turbogears seems broken on squid-cache.org at the moment, until I figure out what has changed, noone can add accounts. -Rob -- GPG key available at: