Re: [MERGE] Fixes to configure.in and build-test layer-01

2008-08-22 Thread Amos Jeffries
Kinkie wrote: While doing some build-testing I've noticed that configure doesn't handle gracefully some malformed --with(out) arguments. This patch addresses three related issues: - makes the error messages for those cases more informative - changes some (echo + exit) sequences into AC_MSG_ERRO

Re: [MERGE] Fixes to configure.in and build-test layer-01

2008-08-22 Thread Robert Collins
Robert Collins has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219438105.27899.10.camel%40loki.home.kinkie.it%3E Project: Squid

Re: [MERGE] Fixed typo in squid.h which would prevent leak checking for arrays.

2008-08-22 Thread Robert Collins
Robert Collins has voted approve. Status is now: Approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219424744.7224.0.camel%40loki.home.kinkie.it%3E Project: Squid

Re: [MERGE] Fixed typo in squid.h which would prevent leak checking for arrays.

2008-08-22 Thread Amos Jeffries
Amos Jeffries has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219424744.7224.0.camel%40loki.home.kinkie.it%3E Project: Squid

Re: comm_write(), write cancellations, etc

2008-08-22 Thread Adrian Chadd
Well yes it is similar to what is done in Squid-3.HEAD except I'm probably going to advocate a much more reduced functionality during transition. I'm going to develop the replacement semantics and API on the side, test it with a very reduced functionality codebase, make sure I've handled all the ca

Re: wordlist-refactor branch complete

2008-08-22 Thread Alex Rousskov
On Fri, 2008-08-22 at 17:50 +0200, Kinkie wrote: > On Fri, Aug 22, 2008 at 4:48 PM, Adrian Chadd <[EMAIL PROTECTED]> wrote: > > 2008/8/22 Kinkie <[EMAIL PROTECTED]>: > >> Hi all. > >> The wordlist-refactor branch is from my point of view feature-complete. > >> It can be found in Launchpad, at > >

Re: comm_write(), write cancellations, etc

2008-08-22 Thread Alex Rousskov
On Fri, 2008-08-22 at 23:16 +0800, Adrian Chadd wrote: > Now, the reason I bring this up is in light of copy-free network IO. > Again, this requires the underlying buffer to persist until the write > is completed or is successfully cancelled. comm_write() uses cbdata > and will lazily ignore call

Re: [MERGE] Fixes to configure.in and build-test layer-01

2008-08-22 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219438105.27899.10.camel%40loki.home.kinkie.it%3E Project: Squid

[MERGE] Fixes to configure.in and build-test layer-01

2008-08-22 Thread Kinkie
While doing some build-testing I've noticed that configure doesn't handle gracefully some malformed --with(out) arguments. This patch addresses three related issues: - makes the error messages for those cases more informative - changes some (echo + exit) sequences into AC_MSG_ERROR() standard auto

Re: [MERGE] wordlist refactoring

2008-08-22 Thread Kinkie
Kinkie has voted reject. Status is now: Vetoed Comment: Patch is now obsolete. Refer to lp:~kinkie/squid/wordlist-refactor for updated patch. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3Cf4ad058f0808130859h1ff0b4fcy565135fbf1a965b3%40mail.gmail.com%3E Project

Re: [MERGE] Fixed typo in squid.h which would prevent leak checking for arrays.

2008-08-22 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219424744.7224.0.camel%40loki.home.kinkie.it%3E Project: Squid

[MERGE] Fixed typo in squid.h which would prevent leak checking for arrays.

2008-08-22 Thread Kinkie
Subject says it all; I've spotted a small typo in squid.h. Kinkie # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch: http://www.squid-cache.org/bzr/squid3/trunk/ # testament_sha1: e6edddf8c7aba8b6cb76e11c714848d3d67de2fc # timestamp: 2008-08-22 19:04

Re: wordlist-refactor branch complete

2008-08-22 Thread Kinkie
On Fri, Aug 22, 2008 at 4:48 PM, Adrian Chadd <[EMAIL PROTECTED]> wrote: > 2008/8/22 Kinkie <[EMAIL PROTECTED]>: >> Hi all. >> The wordlist-refactor branch is from my point of view feature-complete. >> It can be found in Launchpad, at >> https://code.launchpad.net/~kinkie/squid/wordlist-refactor.

Re: comm_write(), write cancellations, etc

2008-08-22 Thread Adrian Chadd
2008/8/22 Adrian Chadd <[EMAIL PROTECTED]>: > G'day again, [snip] > (Now, for those who are scared - _yes_, they stay stable in > client_side.c[c] in all of Squid-2.6, 2.7 and 2.HEAD as far as I can > tell (and thus they should be in 3.x) - not by API contract, but by > sheer luck. ;) Actually,

comm_write(), write cancellations, etc

2008-08-22 Thread Adrian Chadd
G'day again, I've been staring at the comm code in Squid-2 to get an idea of how to implement properly async copy-free network IO. Its tricky to say the least. I'll stick to the write side for now. So we have comm_write(), which mostly makes copy-free write network IO possible. You pass it a buf

cbdata semantics, object lifecycles, and cancellation

2008-08-22 Thread Adrian Chadd
G'day everyone, I've been staring at the cbdata semantics and use in the Squid-2 codebase (which translates pretty well to how its used in the Squid-3 codebase) and I'd like to get peoples' opinions on some stuff. Generally, Squid's event driven methodology involves registering callbacks and usin

Re: wordlist-refactor branch complete

2008-08-22 Thread Adrian Chadd
2008/8/22 Kinkie <[EMAIL PROTECTED]>: > Hi all. > The wordlist-refactor branch is from my point of view feature-complete. > It can be found in Launchpad, at > https://code.launchpad.net/~kinkie/squid/wordlist-refactor. > I'm not posting a bundle to propose merging into trunk at this time, > becau

wordlist-refactor branch complete

2008-08-22 Thread Kinkie
Hi all. The wordlist-refactor branch is from my point of view feature-complete. It can be found in Launchpad, at https://code.launchpad.net/~kinkie/squid/wordlist-refactor. I'm not posting a bundle to propose merging into trunk at this time, because despite the patch being quite self-contained,