Re: astyle

2008-09-13 Thread Amos Jeffries
Tsantilas Christos wrote: Amos Jeffries wrote: Finally got around to running it myself on just src/*.* For me md5checker detects bungled files. I haven't looked further than those files to see if other directories are bunged as well. md5checker.sh assures us the printable byte order is iden

Re: astyle

2008-09-13 Thread Tsantilas Christos
Amos Jeffries wrote: Finally got around to running it myself on just src/*.* For me md5checker detects bungled files. I haven't looked further than those files to see if other directories are bunged as well. md5checker.sh assures us the printable byte order is identical, yes? This script j

Re: astyle

2008-09-13 Thread Amos Jeffries
Tsantilas Christos wrote: Hi Amos, I had post the latest version of the formatter (plus a small script for checking md5 signatures): http://www.mail-archive.com/squid-dev@squid-cache.org/msg07208.html In all test I run, worked without problems. I think it is OK. Regards, Christos

Re: [MERGE] WCCPv2 Config Cleanup

2008-09-13 Thread Amos Jeffries
Adrian Chadd wrote: 2008/9/13 Amos Jeffries <[EMAIL PROTECTED]>: This one was easy and isolated, so I went and did it early. It's back-compatible, so people don't have to use the new names if they like. But its clearer for the newbies until the big cleanup you mention below is stable. Well, t

Re: [MERGE] WCCPv2 Config Cleanup

2008-09-13 Thread Adrian Chadd
2008/9/13 Amos Jeffries <[EMAIL PROTECTED]>: > This one was easy and isolated, so I went and did it early. > It's back-compatible, so people don't have to use the new names if they > like. But its clearer for the newbies until the big cleanup you mention > below is stable. Well, the newbies still

Re: [MERGE] Bug #2447: Problems on failed DNS TCP connections

2008-09-13 Thread Amos Jeffries
Amos Jeffries has voted reject. Status is now: Vetoed Comment: I see a potential critical bug in hunk #4: if(!vc) vc->ns For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1220137897.6703.4.camel%40henriknordstrom.net%3E Project: Squid

Re: [RFC] Anti-AsyncCalls

2008-09-13 Thread Amos Jeffries
Amos Jeffries wrote: Following some detailed discussion around the AsyncCalls issues and why it blocks 3.1 release we have come to the point of withdrawing the current implementation. With one conditional; if during the reversal TMF can complete and satisfy the rest of the developers that the

Re: [MERGE] WCCPv2 Config Cleanup

2008-09-13 Thread Amos Jeffries
Adrian Chadd wrote: Amos, why are you pushing through changes to the WCCP configuration stuff at this point in the game? All the magic numbers in the squid.conf have been bugging me for a while. There seems to have been a renewed interest in getting WCCP configs right since Tproxy v4 stuff we

Re: [MERGE] WCCPv2 Config Cleanup

2008-09-13 Thread Amos Jeffries
Amos Jeffries has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C48CA2AD1.4020901%40treenet.co.nz%3E Project: Squid