Re: Making start/stop idempotent

2009-02-16 Thread Mark Nottingham
http://www.squid-cache.org/bugs/show_bug.cgi?id=2599 On 31/10/2008, at 3:59 AM, Alex Rousskov wrote: On Thu, 2008-10-30 at 00:58 +0100, Henrik Nordstrom wrote: On tor, 2008-10-30 at 10:03 +1100, Mark Nottingham wrote: Hmm, good point. My aim was just start and stop. Seem reasonable to just li

Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-16 Thread Kinkie
>> Definately. With a 32-bit signed size it _should_ be large enough for >> most uses. A debugs when it goes close to or over the signed rollover >> would be critical IMO. Maybe more, but debugs & assert for now. > Do not assert(), just use Must(false) or equivalent. No reason to kill > the proxy i

Re: [MERGE] compat round 3

2009-02-16 Thread Alex Rousskov
On 02/14/2009 10:09 PM, Amos Jeffries wrote: > Alex has managed to convince me that its okay to use just compat/* > So here is another round. Thank you for making this change! I think this patch still #includes compat/foo.h headers as foo.h. It should be #include "compat/foo.h" for all compa

Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-16 Thread Alex Rousskov
On 02/13/2009 10:00 PM, Amos Jeffries wrote: > Kinkie wrote: >> On Fri, Feb 13, 2009 at 11:36 AM, Henrik Nordstrom >> wrote: >>> tor 2009-02-12 klockan 17:19 +0100 skrev Kinkie: It would IMHO make sense to: 1. introduce StringNg::size_type, which should be a _signed_ 32-bit integer

Re: Squid 3.1.0.5 uses memory without bounds

2009-02-16 Thread Henrik Nordstrom
mån 2009-02-16 klockan 14:27 +0100 skrev Steinar H. Gunderson: > I've reported dumps of these several times already. I'm not entirely sure > what more information you need. Not sure either. What I do know however is that valgrind traces in general gets very unreliable unless Squid is built with

Re: Lessons learned from string-fix and consequences on StringNg design

2009-02-16 Thread Kinkie
On Sat, Feb 14, 2009 at 6:00 AM, Amos Jeffries wrote: > Kinkie wrote: >> >> On Fri, Feb 13, 2009 at 11:36 AM, Henrik Nordstrom >> wrote: >>> >>> tor 2009-02-12 klockan 17:19 +0100 skrev Kinkie: It would IMHO make sense to: 1. introduce StringNg::size_type, which should be a _signed

Re: Squid 3.1.0.5 uses memory without bounds

2009-02-16 Thread Steinar H. Gunderson
On Sun, Feb 15, 2009 at 06:33:41PM +0100, Henrik Nordstrom wrote: > In squid-3 it's --enable-valgdind-debug I assume you meant valgrind, not valgdind :-) > If you get a valgrind report in cache.log (or stderr) when visiting the > memory statistics cahemgre page (mgr:mem) then it's compiled correc