Re: StringNg review: MemBlob

2010-10-19 Thread Kinkie
On Mon, Oct 18, 2010 at 7:56 PM, Alex Rousskov rouss...@measurement-factory.com wrote: Hi Kinkie,    Attached is am untested patch with some final polishing changes for MemBlob, based on lp:~kinkie/squid/stringng revision 9517. I think the MemBlob class should be committed to trunk after

Re: [squid-users] Leaking ICAP connections

2010-10-19 Thread Amos Jeffries
Great. This looks like it may be of some use to someone who can read it. Cc'ing Squid-dev so Alex and Christos who work on ICAP can see this thread. Please send followups to that other list now. On 19/10/10 23:45, Steve Hill wrote: On Mon, 18 Oct 2010, Amos Jeffries wrote: snip Pity

Introduction

2010-10-19 Thread Steve Hill
My company uses Squid as part of our web filtering product. The filtering itself is done with a separate ICAP server written by ourselves, but as Squid is an integral part of the product we ship to customers we obviously have an interest in improving Squid. -- - Steve Hill Technical

Re: StringNg review: MemBlob

2010-10-19 Thread Kinkie
On Mon, Oct 18, 2010 at 7:56 PM, Alex Rousskov rouss...@measurement-factory.com wrote: Hi Kinkie,    Attached is am untested patch with some final polishing changes for MemBlob, based on lp:~kinkie/squid/stringng revision 9517. I think the MemBlob class should be committed to trunk after

Re: StringNg review request: SBuf

2010-10-19 Thread Kinkie
On Mon, Oct 18, 2010 at 9:02 PM, Alex Rousskov rouss...@measurement-factory.com wrote: On 09/26/2010 04:47 PM, Kinkie wrote:      *      * A SBuf can be empty, but can never be undefined. In other words there is no equivalent      * of NULL. defined/undefined semantics need to be implemented

Re: StringNg review: MemBlob

2010-10-19 Thread Alex Rousskov
On 10/19/2010 08:08 AM, Kinkie wrote: On Mon, Oct 18, 2010 at 7:56 PM, Alex Rousskov wrote: Once MemBlob is committed, please consider re-integrating it with memory pools. This is the biggest remaining XXX, IMO. I've checked and confirmed why MemPools integration was disabled: it's due to an

Re: StringNg review: MemBlob

2010-10-19 Thread Kinkie
On Tue, Oct 19, 2010 at 4:35 PM, Alex Rousskov rouss...@measurement-factory.com wrote: On 10/19/2010 08:08 AM, Kinkie wrote: On Mon, Oct 18, 2010 at 7:56 PM, Alex Rousskov wrote: Once MemBlob is committed, please consider re-integrating it with memory pools. This is the biggest remaining

Re: StringNg review request: SBuf

2010-10-19 Thread Alex Rousskov
On 10/19/2010 08:28 AM, Kinkie wrote: On Mon, Oct 18, 2010 at 9:02 PM, Alex Rousskov wrote: On 09/26/2010 04:47 PM, Kinkie wrote: * * A SBuf can be empty, but can never be undefined. In other words there is no equivalent * of NULL. defined/undefined semantics need to be

Re: StringNg review: MemBlob

2010-10-19 Thread Alex Rousskov
On 10/19/2010 08:40 AM, Kinkie wrote: On Tue, Oct 19, 2010 at 4:35 PM, Alex Rousskov rouss...@measurement-factory.com wrote: On 10/19/2010 08:08 AM, Kinkie wrote: On Mon, Oct 18, 2010 at 7:56 PM, Alex Rousskov wrote: Once MemBlob is committed, please consider re-integrating it with memory

Re: [squid-users] Leaking ICAP connections

2010-10-19 Thread Alex Rousskov
On 10/19/2010 05:10 AM, Amos Jeffries wrote: Great. This looks like it may be of some use to someone who can read it. Cc'ing Squid-dev so Alex and Christos who work on ICAP can see this thread. Please send followups to that other list now. Is this still with v3.1.0.14? Several ICAP code

Re: [PATCH] InstanceId formatting

2010-10-19 Thread Alex Rousskov
On 10/14/2010 04:53 PM, Kinkie wrote: Hi all, this patch changes slightly the formatting of InstanceId's output so that it's easier to parse and isolate. Opinions? === modified file 'src/base/InstanceId.h' --- src/base/InstanceId.h 2010-10-04 14:49:57 + +++ src/base/InstanceId.h

Re: [PATCH] Solaris /dev/poll support for Squid 3 (how can I contribute)

2010-10-19 Thread Alex Rousskov
On 10/13/2010 04:21 AM, Peter Payne wrote: BENCHMARKS Firstly, I wanted to address the benchmark questions as it made me curious as to whether there really was an advantage in using /dev/poll. I used the Apache Bench tool (that comes with HTTPD) to do my benchmarks. I compiled a 32-bit

Re: The order of #include statements

2010-10-19 Thread Alex Rousskov
On 10/14/2010 08:41 PM, Amos Jeffries wrote: On 15/10/10 06:09, Alex Rousskov wrote: Hello, We require that #include statements are alphabetized, with certain exceptions. The presence of old files with out-of-order #includes makes it difficult to enforce this policy because it is often

Re: Updated netfilter mark patch

2010-10-19 Thread Alex Rousskov
On 10/06/2010 01:13 PM, Kinkie wrote: True, but it gets set back to no if the libraries are subsequently not found. Not a problem though if Amos has changed it to a better way of doing it. The current standard for --enable and --with flags is: yes means force-enable, fail the build if not

Re: Obtaining the form data, the user input in a simple web form

2010-10-19 Thread Alex Rousskov
On 10/13/2010 03:05 AM, calin wrote: I need to inspect the content of a form. Please see http://wiki.squid-cache.org/SquidFaq/ContentAdaptation Alex.

Re: [PATCH] log error details

2010-10-19 Thread Amos Jeffries
On Tue, 19 Oct 2010 23:50:04 +0300, Tsantilas Christos chtsa...@users.sourceforge.net wrote: I am sending the new version of the log error details patch. This version is similar to the previous one except: - Uses hexadecimal number for exceptions IDs - Uses 14 bits for line number (16k

Re: Updated netfilter mark patch

2010-10-19 Thread Amos Jeffries
On Tue, 19 Oct 2010 12:35:57 -0600, Alex Rousskov rouss...@measurement-factory.com wrote: On 10/06/2010 01:13 PM, Kinkie wrote: True, but it gets set back to no if the libraries are subsequently not found. Not a problem though if Amos has changed it to a better way of doing it. The current

Re: The order of #include statements

2010-10-19 Thread Amos Jeffries
On Tue, 19 Oct 2010 12:32:35 -0600, Alex Rousskov rouss...@measurement-factory.com wrote: On 10/14/2010 08:41 PM, Amos Jeffries wrote: On 15/10/10 06:09, Alex Rousskov wrote: Hello, We require that #include statements are alphabetized, with certain exceptions. The presence of old files with

Re: The order of #include statements

2010-10-19 Thread Alex Rousskov
On 10/19/2010 07:18 PM, Amos Jeffries wrote: On Tue, 19 Oct 2010 12:32:35 -0600, Alex Rousskov wrote: 3. each src/ file, with a few hard-coded exceptions, must start with #include . If there is no to include, include config.h. Do not include config.h or squid.h if there is another include.

Re: The order of #include statements

2010-10-19 Thread Amos Jeffries
On Tue, 19 Oct 2010 19:40:52 -0600, Alex Rousskov rouss...@measurement-factory.com wrote: On 10/19/2010 07:18 PM, Amos Jeffries wrote: On Tue, 19 Oct 2010 12:32:35 -0600, Alex Rousskov wrote: 3. each src/ file, with a few hard-coded exceptions, must start with #include . If there is no to