Re: [MERGE] c++-refactor HttpHdrCc

2011-09-13 Thread Amos Jeffries
On Tue, 13 Sep 2011 10:11:55 -0600, Alex Rousskov wrote: void +HttpHdrCc::clear() +{ +mask=0; +max_age=-1; +mask=0; +max_age=-1; +s_maxage=-1; +max_stale=-1; +stale_if_error=0; +min_fresh=-1; +other.clean(); +} This duplicates the default constructor. Mask a

Re: [PATCH] SMP Caching: Core, IPC, Shared memory cache, and Rock Store

2011-09-13 Thread Amos Jeffries
On Tue, 13 Sep 2011 10:56:08 -0600, Alex Rousskov wrote: On 09/12/2011 07:31 PM, Amos Jeffries wrote: On Mon, 12 Sep 2011 09:46:22 -0600, Alex Rousskov wrote: On 09/11/2011 09:22 PM, Amos Jeffries wrote: IMO its passed the audit for merge. Should I commit a good old patch or do a bzr merge

Build failed in Jenkins: 3.HEAD-amd64-CentOs-icc #421

2011-09-13 Thread noc
See Changes: [Automatic source maintenance] SourceFormat Enforcement -- [...truncated 4286 lines...] libtool: compile: icpc -no-gcc -DHAVE_CONFIG_H -I../../.. -I../../../include -I../

Re: [PATCH] SMP Caching: Core, IPC, Shared memory cache, and Rock Store

2011-09-13 Thread Alex Rousskov
On 09/12/2011 07:31 PM, Amos Jeffries wrote: > On Mon, 12 Sep 2011 09:46:22 -0600, Alex Rousskov wrote: >> On 09/11/2011 09:22 PM, Amos Jeffries wrote: >> >>> IMO its passed the audit for merge. >> >> >> Should I commit a good old patch or do a bzr merge with the 3p2-rock >> branch on lp? >> >> * P

Re: [MERGE] c++-refactor HttpHdrCc

2011-09-13 Thread Alex Rousskov
On 09/12/2011 05:38 PM, Kinkie wrote: > Hi, > the attached bundle refactors the HttpHdrCc into a c++ class, > attempting also to clean the code up. Main changes: > - 6 less global functions in protos.h > - 1 less struct in structs.h > - proper c++ construction/destruction semantics, standard MemP