On Tue, 2011-11-01 at 15:22 +1300, Amos Jeffries wrote: > On Mon, 31 Oct 2011 23:33:47 +0000, Andrew Beverley wrote: > > Hi, > > > > The attached patch adds a mask option to the qos_flows miss > > configuration value. The reason for this is to allow the preserved > > mark/TOS value from the server to be altered slightly rather than > > overwritten completely. > > > > Example usage. The following will preserve the netfilter mark, but > > will > > ensure that the (9th) bit specified in the miss value will be set to > > 1 > > in the preserved mark: > > > > qos_flows mark miss=0x100/0xF00 > > > > Andy > > > +1. Looks fine. > > I'm not sure the bad mask needs to be fatal. It could be set to default > mask after the error. If you agree that can be altered on commit and > this go in now.
Agreed. Thanks. Andy
