Re: [PATCH] Do not send unretriable requests on reused pinned connections

lör 2012-12-01 klockan 11:42 -0700 skrev Alex Rousskov: > come. Why can't TPROXY reopen a server-side connection? Because it tries to use the original source ip:port, but it's in TIME_WAIT from the previous connection and can't be reused. Regards Henrik

Re: [PATCH] stage 2 of store url as fake store_url helper

On 12/2/2012 8:41 AM, Amos Jeffries wrote: Don't worry about that. Just place the old directive name as a second word on the NAME: line in cf.data.pre. The config generator will take care of the upgrade notices etc and accept both names. The code in redirect.cc is already taking care of helper pr

Re: [PATCH] stage 2 of store url as fake store_url helper

On 2/12/2012 7:22 p.m., Eliezer Croitoru wrote: On 12/1/2012 9:27 PM, Alex Rousskov wrote: On 12/01/2012 06:34 AM, Eliezer Croitoru wrote: BTW, to compute the first parameter, you may be able to just call HttpRequest::storeUrl() method discussed above (if it always returns a URL for Store). We

Re: [PATCH] stage 2 of store url as fake store_url helper

On 12/2/2012 8:20 AM, Amos Jeffries wrote: On 2/12/2012 8:27 a.m., Alex Rousskov wrote: On 12/01/2012 06:34 AM, Eliezer Croitoru wrote: +static helper *storeurls = NULL; Please use camelCase for variable names unless underline_based_names are needed for consistency reasons. Please documen

Build failed in Jenkins: 3.1-matrix » obsd-49-x86 #154

See -- Started by upstream project "3.1-matrix" build number 154 originally caused by: Started by user Amos Jeffries Building remotely on obsd-49-x86 in workspace

Re: [PATCH] stage 2 of store url as fake store_url helper

On 12/1/2012 9:27 PM, Alex Rousskov wrote: On 12/01/2012 06:34 AM, Eliezer Croitoru wrote: - For now I am not changing the mem-obj->url and leave the branch as it is since there is no need for it now. Once the feature will be fine The change will be placed. That is fine, but please note that t

Re: [PATCH] stage 2 of store url as fake store_url helper

On 2/12/2012 8:27 a.m., Alex Rousskov wrote: On 12/01/2012 06:34 AM, Eliezer Croitoru wrote: - For now I am not changing the mem-obj->url and leave the branch as it is since there is no need for it now. Once the feature will be fine The change will be placed. That is fine, but please note that

Build failed in Jenkins: 3.HEAD-amd64-CentOS-5.3 #2165

See Changes: [Automatic source maintenance] SourceFormat Enforcement -- [...truncated 7833 lines...] 373b802000-373ba01000 ---p 2000 fd:00 130496 /lib64/li

Re: [PATCH] Do not send unretriable requests on reused pinned connections

Hello, It just occurred to me that there is nothing wrong, from theoretical protocol point of view, with reseting the client connection when a server-side race condition is detected _and_ we know that the client was the one that caused Squid to open the server connection. I personally do not k

Re: mapping of ecap LogVerbosity to debug_options levels

On 11/30/2012 08:49 PM, carteriii wrote: > The logging functionality of the ecap adapter allows users to specify a > "LogVerbosity" which is a mask of Importance, Frequency, and Message Size: > > enum ImportanceLevel { ilDebug = 0, ilNormal = 1, ilCritical = 2 }; // 0xF > enum FrequencyLevel { flO

Build failed in Jenkins: 3.2-matrix » master #282

See Changes: [Amos Jeffries] ext_file_userip_acl: Remove duplicate variable definition -- [...truncated 3784 lines...] mv -f .deps/libltdlc_la-slist.Tpo .deps/libltdlc_la-slist.Plo /b

Re: [PATCH] Do not send unretriable requests on reused pinned connections

On 11/30/2012 08:27 PM, Amos Jeffries wrote: > On 1/12/2012 1:31 p.m., Henrik Nordström wrote: >> fre 2012-11-30 klockan 15:30 -0700 skrev Alex Rousskov: >> >>> Squid is sending POST requests on reused pinned connections, and >>> some of those requests fail due to a pconn race, with no possibi

Re: [PATCH] stage 2 of store url as fake store_url helper

On 12/01/2012 06:34 AM, Eliezer Croitoru wrote: > - For now I am not changing the mem-obj->url and leave the branch as it > is since there is no need for it now. > Once the feature will be fine The change will be placed. That is fine, but please note that the feature cannot be committed until that

Re: [PATCH] Do not send unretriable requests on reused pinned connections

On 12/01/2012 11:20 AM, Henrik Nordström wrote: > fre 2012-11-30 klockan 23:07 -0700 skrev Alex Rousskov: >> Does the !flags.canRePin exception address your concern? > Yes, if used where needed (TPROXY, NTLM). By default, the canRePin flag is not set and pinned connections are reused, even for un

Re: [PATCH] Do not send unretriable requests on reused pinned connections

fre 2012-11-30 klockan 23:07 -0700 skrev Alex Rousskov: > I am not sure what you are asking about, but I can try to rephrase: This > bug is difficult to fix because some pinned connections should be reused > and some should not be. Pinned connections that can be re-pinned but > have not had any HTT

[PATCH] stage 2 of store url as fake store_url helper

- For now I am not changing the mem-obj->url and leave the branch as it is since there is no need for it now. Once the feature will be fine The change will be placed. - The patch adds the helper basic surrounding code and a bit action code to make sure it is not breaking anything. - The point

Summery of discussion about StoreUrl coming.

Thanks to alex and amos. As we were talking about in the IRC channel it seems like the last blockage for the store url feature kind of cleared up and I started coding. Worth mentioning: - the blockage was url mismatch that came up since I choose to not change the original url that was stored