Re: [PATCH] Support PROXY protocol

2014-08-12 Thread Alex Rousskov
On 08/12/2014 10:17 AM, Amos Jeffries wrote: > On 11/08/2014 4:32 p.m., Alex Rousskov wrote: >> On 08/05/2014 08:31 PM, Amos Jeffries wrote: >>> +tok.skip(Proxy1p0magic); >> >> We already know the magic is there. If you want to optimize this, then >> skip() in ConnStateData::parseProxyProtocolH

[PATCH] Better handling of huge native FTP requests

2014-08-12 Thread Alex Rousskov
Hello, The attached patch avoids assertions on large FTP commands and cleans up both general and FTP-specific error handling code during request parsing. Please see the patch preamble for technical details. Thank you, Alex. Do not assert on native FTP ERR_TOO_BIG. Do not check for ERR_TOO_B

Re: [PATCH] Support PROXY protocol

2014-08-12 Thread Amos Jeffries
On 11/08/2014 4:32 p.m., Alex Rousskov wrote: > On 08/05/2014 08:31 PM, Amos Jeffries wrote: > >> I am adding proxy_protocol_access as the first access control, reverting >> follow_x_forwarded_for for the second. > > Great. I think this is a much simpler/cleaner design. > > >> +} else if (

Build failed in Jenkins: 3.HEAD-amd64-centos-7 #5

2014-08-12 Thread noc
See Changes: [Amos Jeffries] Fix unwrapped adaptation code in rev.13528 -- [...truncated 38344 lines...] make[3]: Nothing to be done for `uninstall'. make[3]: Leaving directory `

Jenkins build is back to normal : 3.HEAD-amd64-centos-6 #429

2014-08-12 Thread noc
See