Re: squid-2.HEAD: some changes to client_side.c for invalid requests.

2008-09-08 Thread Alexander V. Lukyanov
On Mon, Sep 08, 2008 at 02:49:50PM +0400, Alexander V. Lukyanov wrote: > 3. create method object even for invalid requests (this fixes null pointer > dereferences in many other places). I also suggest this patch to detect attempts to create method-less requests. -- Alexander.

squid-2.HEAD: some changes to client_side.c for invalid requests.

2008-09-08 Thread Alexander V. Lukyanov
Hello! I'm using these changes for some time. Maybe they will be useful. 1. Set conn->transparent early after connection establishment and reset connection on transparent connections when there is no valid request. 2. Check http->entry && http->entry->mem_obj && http->entry->mem_obj->reply to av

squid-2.HEAD:

2008-09-03 Thread Alexander V. Lukyanov
Hello! I have noticed lots of 'impossible keep-alive' messages in the log. It appears that httpReplyBodySize incorrectly returns -1 for "304 Not Modified" replies. Patch to fix it is attached. -- Alexander. Index: HttpReply.c ===

Re: squid-2.HEAD: fwdComplete/Fail before comm_close

2008-08-10 Thread Alexander V. Lukyanov
On Fri, Aug 08, 2008 at 11:57:03PM +0200, Henrik Nordstrom wrote: > Can you please file a bug report on this? Preferably with a stack trace > of the crash if possible.. Unfortunately, the core dump was corrupted that time. And yes, it was before 22/07. > The second change looks wrong and should

Re: squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-08-04 Thread Alexander V. Lukyanov
On Tue, Aug 05, 2008 at 02:25:34PM +0800, Adrian Chadd wrote: > Hm, so whats the behaviour without this patch? rebuild is done in foreground as expected, but cleanup goes in background in parallel with client requests. The patch fixes the second part - the cleanup. -- Alexander.

squid-2.HEAD: fwdComplete/Fail before comm_close

2008-08-04 Thread Alexander V. Lukyanov
Hello! Some time ago I had core dumps just after these messages: Short response from ... httpReadReply: Excess data from ... I beleave this patch fixes these problems. Index: http.c === RCS file: /squid/squid/src/htt

squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-08-04 Thread Alexander V. Lukyanov
Hello! I use squid in transparent mode, so I don't want degraded performance while rebuilding and cleanup. Here is a patch I use to make storeCleanup do all the work at once before squid starts processing requests, when -F option is specified on command line. Index: store_rebuild.c ==

Re: squid-2.HEAD: proposed patch for max-age + no-cache combination

2008-04-27 Thread Alexander V. Lukyanov
On Sun, Apr 27, 2008 at 07:55:01PM +0800, Adrian Chadd wrote: > On Sun, Apr 27, 2008, Alexander V. Lukyanov wrote: > > Currently it is possible for squid to send out Cache-Control: max-age=XXX, > > no-cache > > combination. But max-age does not make any sense when there is

squid-2.HEAD: proposed patch for max-age + no-cache combination

2008-04-27 Thread Alexander V. Lukyanov
Hello! Currently it is possible for squid to send out Cache-Control: max-age=XXX, no-cache combination. But max-age does not make any sense when there is a no-cache flag. Here is a patch to fix it. The patch skips setting max-age if there is no-cache flag. If the client has sent the combination

squid-2.HEAD: proposed patch for non-broken keep-alive case

2008-04-27 Thread Alexander V. Lukyanov
Hello! It seems that squid currently considers broken the case of keep-alive when there is no Content-Length and the transfer encoding is chunked. I think it is not quite correct, as chunked encoding allows to determine reply body end. Here is an example: 2008/04/27 08:48:51| httpProcessReplyHead

Re: assorted changes for squid 2 HEAD cvs

2007-10-12 Thread Alexander V. Lukyanov
On Mon, Oct 08, 2007 at 06:07:20PM +0200, Henrik Nordstrom wrote: > Can you please test if the attached patch solves the problem for you? It > makes the maintenance back off if load gets too high. Seems to work. Now I don't get I/O overload during store dir resize. Thank you! -- Alexander.

Re: assorted changes for squid 2 HEAD cvs

2007-10-09 Thread Alexander V. Lukyanov
On Mon, Oct 08, 2007 at 06:07:20PM +0200, Henrik Nordstrom wrote: > > 3. call squidaio_sync in aufs dir maintenance to limit queue growth > >(e.g. when repository size or high/low are decreased). > > Not sure about this one.. this will make Squid block under load and > additionally screws up f