Re: Squid-2.5 ICAP client

2003-03-26 Thread Geetha Manjunath
Hello Henrik, This piece of code is related to the call to clientReadRequest from the function icapReqModReadReply in icap.c . The function icapReqModReadReply reads the modified http request from the icap server - which is in reply to a reqmod request - and processes this new request. You will no

Re: Squid-2.5 ICAP client

2003-03-28 Thread Geetha Manjunath
Hello Henrik, Thanks for your interest/time in the icap related changes...It is also good to know that my changes are not so out of the way. Please find my comments inline... Henrik Nordstrom wrote: > > Ok. So if conn->me.sin_family is not set then the call came from > icapReqModReadReply, an

Re: Squid-2.5 ICAP client

2003-04-01 Thread Geetha Manjunath
"continuation" mechanism of squid?? I should have put a callback on clientReadRequest... We have done that for RESPMOD though. Thanks again for pointing this out! PS: Sorry for my delayed answer - I was out of office... thanks and regards Geetha Henrik Nordstrom wrote: > >

Re: of possible interest to ICAP developers

2003-06-23 Thread Geetha Manjunath
> > On Friday 20 June 2003 01.00, Robert Collins wrote: > > Duane Wessels wrote: > > > http://shweby.sourceforge.net/ > > > > > > I find their logo interesting, especially since the badmouth > > > Squid in http://shweby.sourceforge.net/doc.php > > > > Yeah, that kindof sucks. Particularly as they

Re: Fwd: Squid ICAP client problems

2003-06-23 Thread Geetha Manjunath
Thanks for forwarding this, Henrik. Hello Larry, Sorry for this delayed reply.. > -Original Message- > From: Rosenbaum, Larry M. . > > 1) (icap.c) There is a problem with the way icapRespModReadReply() > tries to read the ICAP header without reading past the header. The >

Re: of possible interest to ICAP developers

2003-06-23 Thread Geetha Manjunath
> I am keeping notes on found issues and > shortcomings on http://devel.squid-cache.org/icap/ > Thanks for the neat page, Henrik. There is one more that was reported to me sometime back by Rui Ataide. I haven;t confirmed this bug though. You may want to add it to the list . " When ICAP is enable

Re: Fwd: Squid ICAP client problems

2003-06-23 Thread Geetha Manjunath
Henrik Nordstrom wrote: > > I had fogot about this issue. I'll note this issue so it is not > forgotten again. Needs to be fixed to not use MSG_PEEK so it can wait > for more data to arrive via commSetSelect(), which involves some magic > to get the interactions with the main Squid code correct.