unittest output for the build farm

2009-08-14 Thread Robert Collins
The build farm [hudson] can show test results if they are in an xml format (it supports a couple). There are several ways we can do this: - if all our tests are cppunit, the cppunit xml format can be understood directly - if some of our tests are not cppunit (e.g. they are shell based, or

Re: Can build tests be made conditional on a master

2009-08-14 Thread Robert Collins
On Sat, 2009-08-15 at 01:21 +0200, Henrik Nordstrom wrote: Just a thought, but to avoid spamming with failed reports when a platform-independent test is forgotten to be updated / fails, would it be possible to configure Hudson to use one build host as master (i.e. a reasonably new Linux one),

Re: unittest output for the build farm

2009-08-14 Thread Robert Collins
On Sat, 2009-08-15 at 13:32 +1200, Amos Jeffries wrote: No, layer-00-bootstrap is 100% shell code. The other tests have testHeaders test which is shell code, translation tests are automake code. Future plans are to at some point include the old test-suite run-tests and at least one

Re: unittest output for the build farm

2009-08-14 Thread Robert Collins
On Sat, 2009-08-15 at 13:54 +1200, Amos Jeffries wrote: What am I meant to be looking for? Whether you think this is a reasonable approach - after all you have done most of recent test harness work ;) -Rob signature.asc Description: This is a digitally signed message part

Re: Stateful helpers cleanup (big axe)

2009-08-02 Thread Robert Collins
On Sun, 2009-08-02 at 17:07 +0200, Henrik Nordstrom wrote: Looking at the stateful helpers code I noticed we still have the deferred concept, even if it's not used at all. As part of preparing the code for concurrent helper protocol for NTLM/Negotiate I propose dropping the deferred support,

Re: Stateful helpers cleanup (big axe)

2009-08-02 Thread Robert Collins
On Sun, 2009-08-02 at 23:28 +0200, Henrik Nordstrom wrote: mån 2009-08-03 klockan 07:11 +1000 skrev Robert Collins: There's still going to be the concept of 'tcp connection X needs auth helper Y to send its next step on'; this is essentially deferred requests. No, that's the RESERVED

Re: Hello from Mozilla

2009-07-29 Thread Robert Collins
On Wed, 2009-07-15 at 00:51 +, Ian Hickson wrote: If there are any bytes allowed from the client or the server before the handshake starts, then it is no longer secure. The idea is to make sure you can't smuggle though payloads from other protocols, since otherwise you could use

Re: Hello from Mozilla

2009-07-29 Thread Robert Collins
On Wed, 2009-07-29 at 23:48 +, Ian Hickson wrote: Surely once the HTTP server has decided that it can Upgrade, it doesn't actually need to worry about sending back something HTTP-valid at all, since we can just say the entire connection was always using the WebSocket protocol, and

Re: Hello from Mozilla

2009-07-29 Thread Robert Collins
On Thu, 2009-07-30 at 00:00 +, Ian Hickson wrote: On Thu, 30 Jul 2009, Robert Collins wrote: What drives the desire to live on port 80? Nothing. WebSocket will be on ports 81 and 815. The desire to share a port with HTTP comes from port 443 being the only port that is usable in some

Re: Hello from Mozilla

2009-07-29 Thread Robert Collins
On Fri, 2009-07-17 at 10:00 +, Ian Hickson wrote: On Fri, 17 Jul 2009, Adrian Chadd wrote: 2009/7/17 Ian Hickson i...@hixie.ch: That way you are still speaking HTTP right until the protocol change occurs, so any and all HTTP compatible changes in the path(s) will occur. As

Re: Bug for Today 2662

2009-07-18 Thread Robert Collins
this is wrong, writing a longer response now. -Rob signature.asc Description: This is a digitally signed message part

Re: Bug for Today 2662

2009-07-18 Thread Robert Collins
On Sat, 2009-07-18 at 15:21 +1200, Amos Jeffries wrote: Is anyone familiar enough with cross-compilation and auto-tools to verify and/or correct the solution to this bug? http://www.squid-cache.org/bugs/show_bug.cgi?id=2662 I'm happy to commit as-is if someone who knows can confirm its

Re: [PATCH] Bug 2680: ** helper errors after -k rotate

2009-07-16 Thread Robert Collins
On Thu, 2009-07-16 at 08:42 +0200, Henrik Nordstrom wrote: tor 2009-07-16 klockan 14:47 +1200 skrev Amos Jeffries: And the sad reality in squid-3 with _one_ helper: squid-*--1-helper---* winbindd [state1, state2] \---crash: all 2 of 1 helpers all RS pending state.

Re: [PATCH] Bug 2680: ** helper errors after -k rotate

2009-07-16 Thread Robert Collins
On Thu, 2009-07-16 at 09:11 +0200, Henrik Nordstrom wrote: tor 2009-07-16 klockan 16:54 +1000 skrev Robert Collins: I thought we put a unique id on the stateful helper protocol _way_ back. Sigh :( No, I couldn't when I implemented the concurent request protocol so it only got done

Re: [PATCH] Bug 2680: ** helper errors after -k rotate

2009-07-15 Thread Robert Collins
On Thu, 2009-07-16 at 14:08 +1200, Amos Jeffries wrote: Both reconfigure and helper recovery use startHelpers() where the limit needs to take place. The DOS bug fix broke *rotate* (reconfigure has an async step added by Alex that prevents it being a problem). s/rotate/reconfigure then :)

Re: [PATCH] Bug 2680: ** helper errors after -k rotate

2009-07-14 Thread Robert Collins
On Wed, 2009-07-15 at 00:52 +0200, Henrik Nordstrom wrote: Or 4, go back to don't strictly enforce the number of helpers? +1 I don't know what this strictly-enforce thing is, but it sounds unneeded as we used to fire up the right number of helpers anyway. -Rob signature.asc Description:

Re: [PATCH] chunked requests

2009-07-13 Thread Robert Collins
On Mon, 2009-07-13 at 13:40 +0200, Henrik Nordstrom wrote: a) Nothing of this should be unique to POST/PUT. HTTP message format is the same for all requests. For what it's worth even a GET/HEAD requests MAY contain a meaningless chunked entity. Ermm.. 4.3 ... A message-body MUST NOT be

Re: Importing recent trunk changes to 3.1

2009-07-12 Thread Robert Collins
On Mon, 2009-07-13 at 14:53 +1200, Amos Jeffries wrote: Your thinking parallels mine with a few extra Pros I had not thought of. I'm voting +1 to adding both. Ditto signature.asc Description: This is a digitally signed message part

Re: disable-loadable-modules

2009-07-10 Thread Robert Collins
On Thu, 2009-07-09 at 20:22 +1200, Amos Jeffries wrote: Robert Collins wrote: On Thu, 2009-07-09 at 19:40 +1200, Amos Jeffries wrote: ... checking whether to use loadable modules... yes, implicitly Is the test for whether to use them broken? The code is to always enables them

Re: disable-loadable-modules

2009-07-10 Thread Robert Collins
On Fri, 2009-07-10 at 23:33 +1200, Amos Jeffries wrote: I thought I had something adding ${srcdir} to the path we pass it. But builddir does not seem to be available, and srcdir is the wrong place to find the built convenience lib. Neither should be done. The lib should be added (the .la

Re: disable-loadable-modules

2009-07-09 Thread Robert Collins
On Thu, 2009-07-09 at 19:40 +1200, Amos Jeffries wrote: ... checking whether to use loadable modules... yes, implicitly Is the test for whether to use them broken? -Rob signature.asc Description: This is a digitally signed message part

Re: Hello from Mozilla

2009-07-07 Thread Robert Collins
On Tue, 2009-07-07 at 17:01 -0600, Alex Rousskov wrote: The reason I ask is because we're looking to take a patch that implements the IETF websockets protocol: http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol-17 I noticed that in section 3.1.3 the spec relies

Re: Hello from Mozilla

2009-07-07 Thread Robert Collins
On Tue, 2009-07-07 at 22:28 -0400, Tres Seaver wrote: I would argue that enabling only localhost for the default forward proxy configuration is a sane default: people configuring things like bastions ought not to expect to use out-of-the box configs without review / tweakage, while people

Re: Launchpad: Squid translation uploads

2009-06-23 Thread Robert Collins
On Tue, 2009-06-23 at 19:13 +0700, Jeroen Vermeulen wrote: Hi Robert, I'm reviewing the translation template errors/errpages.pot you uploaded to Squid. Actually, *I* didn't upload it. I've cc'd the squid developers list, I'm sure one of the other developers, probably Amos, did. I filed a

Re: NTLM authentication popups, etc

2009-06-16 Thread Robert Collins
On Tue, 2009-06-16 at 15:14 +0800, Adrian Chadd wrote: The stateful helper stuff seems correct enough, so requests aren't being queued to already busy stateful helpers. IIRC you can multiplex requests on single stateful helpers now (see deferred_requests - the count of how many concurrent

Re: source code reorg makefiles

2009-05-27 Thread Robert Collins
On Wed, 2009-05-27 at 16:31 -0600, Alex Rousskov wrote: Here is the good news: Regardless of the non/recursive decision, most of the SourceLayout changes are valid and useful. They properly organize the sources files. If we decide that non-recursive make is the goal, it would be much easier

Re: [RFC] ACL collection class

2009-05-27 Thread Robert Collins
On Wed, 2009-05-27 at 16:41 -0600, Alex Rousskov wrote: On 05/10/2009 11:08 PM, Robert Collins wrote: On Mon, 2009-05-11 at 16:12 +1200, Amos Jeffries wrote: PS. I took another look at the breakage that made me RFC, and I got the auth and ACL code mixed up. It's auth that is currently

source code reorg makefiles

2009-05-11 Thread Robert Collins
I have one small request vis-a-vis the source code reorg. Please don't undo the non-recursive make support. I put a lot of effort into getting it where it was up to (even though that wasn't propogated across the entire code base). It makes a substantial difference to correctness, performance and

Re: source code reorg makefiles

2009-05-11 Thread Robert Collins
On Tue, 2009-05-12 at 01:48 +1200, Amos Jeffries wrote: Can you explain a bit more detail please? what are you seeing us do wrong? we are not trying to remove anything at this point AFAIK. acl is the one I noticed; but I had the others building non-recursively too. Non-recursive make is

Re: [RFC] ACL collection class

2009-05-10 Thread Robert Collins
On Mon, 2009-05-11 at 13:51 +1200, Amos Jeffries wrote: We are currently hitting issues with template instance duplication (resolvable) and with instance initialization during AclReg static init context in the library model. What are the views on creating an ACL 'instance collection'

Re: [RFC] ACL collection class

2009-05-10 Thread Robert Collins
On Mon, 2009-05-11 at 16:12 +1200, Amos Jeffries wrote: PS. I took another look at the breakage that made me RFC, and I got the auth and ACL code mixed up. It's auth that is currently fubar again. But the principle holds: model is broken and we do need to fix it. I'd be strongly inclined

Re: [PATCH] Cache-Control overwriting hack

2009-05-04 Thread Robert Collins
surrogate-control is an existing, defined header that should do this cleanly, and squid-3 already supports. -Rob signature.asc Description: This is a digitally signed message part

Re: [PATCH] Cache-Control overwriting hack

2009-05-04 Thread Robert Collins
On Tue, 2009-05-05 at 11:57 +1000, Mark Nottingham wrote: Yeah, but if I had a do-over, I'd make it simpler. This is *much* simpler... I think you are entitled to that... but is it needed? -Rob signature.asc Description: This is a digitally signed message part

Re: [PATCH] Cache-Control overwriting hack

2009-05-04 Thread Robert Collins
On Tue, 2009-05-05 at 12:17 +1000, Mark Nottingham wrote: The functionality? Very much so; I've been thinking about adding this sort of thing for a while. Very useful if you're running an accelerator. No, a rewrite of the approach - seems to me that a functional version many things support a

Re: [PATCH] simpler test for PURGE method

2009-05-03 Thread Robert Collins
bb:approve looks good to me signature.asc Description: This is a digitally signed message part

Re: Fwd: Better Windows support for Bazaar.

2009-04-29 Thread Robert Collins
On Wed, 2009-04-29 at 16:45 -0600, Alex Rousskov wrote: On 04/16/2009 12:26 PM, Guido Serassio wrote: But is not clear to me if Bazaar on squid-cache.org should be upgraded with the rc version to support new functionality. Can you ask Karl? He seems to be willing to help. 1.14 has been

Re: Fwd: Better Windows support for Bazaar.

2009-04-29 Thread Robert Collins
On Thu, 2009-04-30 at 12:52 +1200, Amos Jeffries wrote: Well if it can reduce the 2-3 MB bzr currently insists on telling me its transferred just to save a few lines of patch I think its worth it. For me, pushing a single patch, is ~128kb of traffic (the counter measures both directions).

Re: Fwd: Better Windows support for Bazaar.

2009-04-29 Thread Robert Collins
On Thu, 2009-04-30 at 15:10 +1200, Amos Jeffries wrote: Well if it can reduce the 2-3 MB bzr currently insists on telling me its transferred just to save a few lines of patch I think its worth it. Just did this for me: [\ ]952kB @1kB/s | Running post_commit

Re: fakeauth_auth problem

2009-04-28 Thread Robert Collins
On Mon, 2009-04-27 at 18:58 +, Joao Alves Neto wrote: any idea? A better thing would be to use samba's domain membership functionality to actual authentication. fakeauth isn't very good. -Rob signature.asc Description: This is a digitally signed message part

Re: /bzr/squid3/trunk/ r9573: SourceLayout: acl/, take 1

2009-03-16 Thread Robert Collins
On Mon, 2009-03-16 at 20:01 -0600, Alex Rousskov wrote: The fix: I have moved registration code from src/acl/* sources into a src/AclRegs.cc file, making the latter the source file for Squid executable. With this change, Squid knows about specific ACL types (because they are needed by the

Re: /bzr/squid3/trunk/ r9573: SourceLayout: acl/, take 1

2009-03-15 Thread Robert Collins
On Sun, 2009-03-15 at 14:04 -0600, Alex Rousskov wrote: If some ACL type is not registered with Squid executable, do you think test-build would expose the problem, with the current set of tests? I doubt it would. This lack of runtime testing of registered types is probably the reason

Re: /bzr/squid3/trunk/ r9573: SourceLayout: acl/, take 1

2009-03-15 Thread Robert Collins
On Sun, 2009-03-15 at 22:35 -0600, Alex Rousskov wrote: On 03/15/2009 08:31 PM, Robert Collins wrote: I don't think that a pure virtual approach will work any better because the same not-directly-listed result will occur. The virtual method should be called directly or indirectly

Re: Feature: quota control

2009-02-26 Thread Robert Collins
Key things I'd look for: - quota's shouldn't be lost when squid restarts - people should be able to use external quota systems (they may have e.g. netflow or other systems tracking direct b/w use, and squid is pulling from those allowances when downloads are caused by a given user).

Re: votes..

2009-02-11 Thread Robert Collins
On Wed, 2009-02-11 at 23:20 +0200, Tsantilas Christos wrote: May I ask, about the votes, which is the procedure? Who is giving access to bundlebuggy? Or it is something I do not need it? I can add users, but I don't consider myself the decider - rather the community here is. -Rob

Re: TestBed phase 4

2009-02-08 Thread Robert Collins
On Mon, 2009-02-09 at 12:29 +1300, Amos Jeffries wrote: I've implemented the beginning of TestBed project phase 4 (regular automated testing on multiple OS). For now this consists of a script which runs the build testing and emails results and OS details to n...@squid-cache.org. Can we just

Re: TestBed phase 4

2009-02-08 Thread Robert Collins
On Mon, 2009-02-09 at 13:43 +1300, Amos Jeffries wrote: On Mon, 2009-02-09 at 12:29 +1300, Amos Jeffries wrote: I've implemented the beginning of TestBed project phase 4 (regular automated testing on multiple OS). For now this consists of a script which runs the build testing and

Re: Proposed /src/core directory

2009-01-08 Thread Robert Collins
On Thu, 2009-01-08 at 09:17 -0700, Alex Rousskov wrote: There are two problems with this addition: 1) The directory name should not be core. That name is treated specially in some environments. I have tried that directory name in the past and ran into problems with makefiles, archival

Re: Why does ~DeferredReadManager read?

2008-11-01 Thread Robert Collins
On Fri, 2008-10-31 at 10:10 -0600, Alex Rousskov wrote: Does anybody know why DeferredReadManager destructor forces deferred reads to read by calling flushReads? Besides leading to bugs, it seems kind of pointless to try to read if the object that guarded deferred reads is being destructed

Re: Why does ~DeferredReadManager read?

2008-11-01 Thread Robert Collins
On Sat, 2008-11-01 at 10:45 -0600, Alex Rousskov wrote: Moreover, if we must read until EOF before we close, then the cleanup code would have to be rewritten in many places, not just the deferred read-related ones! src/comm.cc line 353: /** * Empty the read buffers * * This is a magical

Re: Where to put ACL* sources

2008-10-19 Thread Robert Collins
On Sun, 2008-10-19 at 13:20 -0600, Alex Rousskov wrote: Should we dump all ACL* and excternal_acl.* sources to acl/? Or should some of the protocol or feature-specific ACL sources live where those sources live? For example, should ICAP-related ACLs live in acl/ or adaptation/icap/?

Re: Where to put ACL* sources

2008-10-19 Thread Robert Collins
The thing I want to differentiate is between: - code directly used by other parts of squid ('acl') which must be present if any acl's are in use - plugin acl's that are only used because a config item requests them I think the amount of code in the former is probably not worth a full

Re: eCAP configure tests

2008-10-14 Thread Robert Collins
On Wed, 2008-10-15 at 14:15 +1300, Amos Jeffries wrote: IMO, if a user explicitly requested feature Foo and Foo cannot be supported, we should fail rather than ignore the user request. I completely agree with this. The usual behaviour I see that works well is: no-parameter supplied:

Re: Deprecating URL passwords in cache_object://

2008-10-03 Thread Robert Collins
On Fri, 2008-10-03 at 13:30 +1000, Mark Nottingham wrote: What do folks think about removing support for @password in URLs? I think its fine. -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

Re: fixing deferred reads

2008-09-25 Thread Robert Collins
On Thu, 2008-09-25 at 13:43 -0600, Alex Rousskov wrote: I can probably fix it myself, but it would help a lot if somebody could document (briefly!) the overall purpose of deferred reads and the exact purposes of these two nearly identical methods (one brief description for each, please):

Re: fixing deferred reads

2008-09-25 Thread Robert Collins
On Thu, 2008-09-25 at 17:42 -0600, Alex Rousskov wrote: Is the order in which reads are done or kicked important? Does it have to be FIFO? FIFO was the behaviour of the code before I refactored into a manager object; I suspect FIFO prevents starvation of individual fds, so it shouldn't be

Re: [PATCH] string-safe improvements in basic-auth session helper

2008-09-03 Thread Robert Collins
bb:approve signature.asc Description: This is a digitally signed message part

Re: [MERGE] Bug #2447: Problems on failed DNS TCP connections

2008-09-03 Thread Robert Collins
Robert Collins has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1220137897.6703.4.camel%40henriknordstrom.net%3E Project: Squid

Re: How to resubmit merge requests

2008-08-28 Thread Robert Collins
On Fri, 2008-08-29 at 13:13 +1200, Amos Jeffries wrote: On tor, 2008-08-28 at 22:39 +1000, Benno Rice wrote: Just as a side question, once I've reworked my code to address Amos' concerns, what's the workflow for resubmitting? Do I just bzr send again? Is there anything I need to do to

Re: [MERGE] Fix build on systems where $(MAKE) != make

2008-08-27 Thread Robert Collins
On Wed, 2008-08-27 at 11:00 -0600, Alex Rousskov wrote: On Wed, 2008-08-27 at 16:05 +1000, [EMAIL PROTECTED] wrote: Respect $(MAKE) in error translation build. On FreeBSD, make is not GNU make. GNU make can be installed from ports, but it is installed as gmake, not make. This makes

Re: [MERGE] Fixed typo in squid.h which would prevent leak checking for arrays.

2008-08-22 Thread Robert Collins
Robert Collins has voted approve. Status is now: Approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219424744.7224.0.camel%40loki.home.kinkie.it%3E Project: Squid

Re: [MERGE] Fixes to configure.in and build-test layer-01

2008-08-22 Thread Robert Collins
Robert Collins has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219438105.27899.10.camel%40loki.home.kinkie.it%3E Project: Squid

Re: [PATCH] clean(er) squid.conf

2008-08-20 Thread Robert Collins
On Wed, 2008-08-20 at 19:03 +1200, Amos Jeffries wrote: Here is a quick patch I think builds a clean squid.conf file for use The gist of it is to build to shift the existing squid.conf.default to the name squid.conf.documented (anyone got a better one?) Then to generate a new

Re: ClearingTheCache

2008-08-20 Thread Robert Collins
On Thu, 2008-08-21 at 08:09 +1000, Mark Nottingham wrote: Noticed the update of http://wiki.squid-cache.org/SquidFaq/ClearingTheCache . To fix simple cases such as the above where the cache just needs to have a portion of the total removed Altering squid.conf and reconfiguring squid

Re: Squid-2 Subversion Checklist

2008-08-14 Thread Robert Collins
On Fri, 2008-08-15 at 12:49 +0800, Adrian Chadd wrote: G'day, I'd like to assemble a basic checklist for things to implement before a migration of Squid-2 to Subversion. If you're going to migrate right now, I suggest bzr, which is also trivial, and for which all the toolchain stuff on

Re: Squid-2 Subversion Checklist

2008-08-14 Thread Robert Collins
On Fri, 2008-08-15 at 15:19 +1000, Benno Rice wrote: On 15/08/2008, at 3:10 PM, Robert Collins wrote: On Fri, 2008-08-15 at 12:49 +0800, Adrian Chadd wrote: G'day, I'd like to assemble a basic checklist for things to implement before a migration of Squid-2 to Subversion. If you're

Re: Squid-2 Subversion Checklist

2008-08-14 Thread Robert Collins
On Fri, 2008-08-15 at 15:38 +1000, Benno Rice wrote: 1.6, in late-beta now, supports plugins that do EOL translations. Its still getting polished andimproved in the core. Are you able to assist Guido in testing this to make sure it works for him? If so then I'm happy to support using

Re: Unknown method handling in squid 2.x

2008-08-12 Thread Robert Collins
On Tue, 2008-08-12 at 16:20 +1000, Benno Rice wrote: On 12/08/2008, at 4:05 PM, Amos Jeffries wrote: By that do you mean you are syncing with the logic fix made for 3.1? I didn't directly refer to that, no. I set up a set of simple unit tests that checked compliance against the RFC

Re: Environment to build a squid helper

2008-08-12 Thread Robert Collins
On Tue, 2008-08-12 at 21:43 +0200, Henrik Nordstrom wrote: Been looking into MinGW+MSYS in the last days from this thread and it's status reminds me a bit of Squid-3 in the last years.. way overdue for the next bundle release with any serious development dependent on versions currently

Re: [MERGE] wordlist refactoring

2008-08-12 Thread Robert Collins
On Tue, 2008-08-12 at 22:00 +0200, Kinkie wrote: Hi all, this patch is an attempt at streamlining the wordlist implementation in 3.HEAD, by: .. The patch has been compile-tested, unit-tested, test-suite'd and run-tested. Thanks Kinkie. BundleBuggy couldn't identify the project this patch

Re: Environment to build a squid helper

2008-08-12 Thread Robert Collins
On Wed, 2008-08-13 at 00:02 -0400, Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Henrik Nordstrom wrote: On tis, 2008-08-12 at 22:52 -0400, Tres Seaver wrote: Isn't 'extern inline' a contradiction? There should be *no* linkage of any function being inlined.

Re: Making start/stop idempotent

2008-08-11 Thread Robert Collins
On Tue, 2008-08-12 at 14:43 +1000, Mark Nottingham wrote: Our management tools like processes to be idempotent; i.e., you should be able to start or stop a process any number of times without it throwing an error. Currently, Squid will return 1 if a squid process is already running

Re: [MERGE] Language Updates

2008-08-08 Thread Robert Collins
Robert Collins has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C20080808061444.ED7E3206218%40treenet.co.nz%3E Project: Squid

Re: [MERGE] Language Updates

2008-08-08 Thread Robert Collins
Robert Collins has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C20080808061444.ED7E3206218%40treenet.co.nz%3E Project: Squid

Re: plain patches and shared bundlebuggy

2008-07-23 Thread Robert Collins
On Wed, 2008-07-23 at 15:21 +0800, Adrian Chadd wrote: Guido, This is why I've been asking about migrating squid-2 to subversion instead of bzr for the time being. This seems like a good middle-ground - merging is still a bit whack, but for the most part, its much better than CVS, it'll

Re: R: plain patches and shared bundlebuggy

2008-07-22 Thread Robert Collins
On Tue, 2008-07-22 at 08:51 +0200, Guido Serassio wrote: Hi, Just a word: NO With bzr we have already killed Squid3 on Windows, do you also want to kill Squid2 ??? I think we should wait for the EOL support to be available for Guido; I need some time to do a

Re: plain patches and shared bundlebuggy

2008-07-22 Thread Robert Collins
On Tue, 2008-07-22 at 16:28 +1200, Amos Jeffries wrote: FYI Rob, the [PATCH] so far are for Squid-3, though Squid-2 may use tham of they apply. Oh, if you are seninding stuff for -3, it really should be a bundle :) -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt.

new bundlebuggy up and running

2008-07-18 Thread Robert Collins
I've now tested the new BB and it processed the second test fine. I think I mailed everyone with a login - if you haven't received one its oversight not insult just mail me and I'll set one up immediately (its easy - a web page). To use: in your ~/.bazaar/locations.conf, put a stanza like:

Re: new bundlebuggy up and running

2008-07-18 Thread Robert Collins
On Sat, 2008-07-19 at 05:29 +1200, Amos Jeffries wrote: Robert Collins wrote: I've now tested the new BB and it processed the second test fine. Just one problem. I got two bounces shortly after the dns_testnames submission. Both claimed I had no voting rights to the Bazaar group. Looks

[MERGE] Woo - test 2

2008-07-17 Thread Robert Collins
-- GPG key available at: http://www.robertcollins.net/keys.txt. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # 48w6aghlwowqz71m # target_branch: http://www.squid-cache.org/bzr/squid3/trunk/ # testament_sha1: 896240103f913257ed9c3a1dbaf4c1a1b18a3d19 #

Re: [MERGE] Woo

2008-07-17 Thread Robert Collins
On Fri, 2008-07-18 at 01:21 +1200, Amos Jeffries wrote: Robert Collins wrote: Just testing the new BB instance. -Rob Did it work? Nope, http://bundlebuggy.aaronbentley.com/project/squid/request is the new instance. I'm seeing multi-hour delays on my mail to this list though, which

Re: [MERGE] Woo - test 2

2008-07-17 Thread Robert Collins
On Thu, 2008-07-17 at 23:09 +1000, Robert Collins wrote: This was picked up by BB, but its reply is in the moderator queue. Thanks Aaron! bb:reject -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

Re: [MERGE] Closing branch cachemgr-refactoring

2008-07-15 Thread Robert Collins
On Tue, 2008-07-15 at 23:37 +1200, Amos Jeffries wrote: For the record. Robert your method of merge did eventually work. It seems I was just too impatient with my first attempt. The URL merge from launchpad just took me an hour to complete. Before any of the testing began. That sounds

Re: [MERGE] Final cachemgr-refactor mergeset, including hno's peer_userhash and peer_sourcehash

2008-07-14 Thread Robert Collins
On Tue, 2008-07-15 at 05:27 +1200, Amos Jeffries wrote: Kinkie wrote: Merged code failed testing. Please run make check again and fix this. Fixed code now in launchpad. Please let me know if you want it sent (see my other mail). I'm still learning the finer arts of bzr and haven't

bundlebuggy loggerhead

2008-07-12 Thread Robert Collins
I know bundlebuggy has been a disappointment, operating it was trickier that I expected on freebsd :). Aaron Bentley, the author, has added multi-project support now, and has offered to add squid to the BB instance he runs, if we so desire. This will give a web control panel for accounts, and let

Re: Next Squid get-together

2008-07-01 Thread Robert Collins
On Tue, 2008-07-01 at 22:50 +1000, Mark Nottingham wrote: I'm assuming so, since they're letting me host this thing, AIUI. We have room for a reasonable number (i.e., 30 would probably be pushing it). Cheers, P.S. This is the view from our office:

Re: bzr on Windows

2008-06-26 Thread Robert Collins
On Thu, 2008-06-26 at 08:10 +0200, Guido Serassio wrote: Hi Robert, There is and it works fine for many windows users. However some using problematic toolchains like Visual Studio have more needs than just checking out the code - they need file mangling. And that is very close to landing

Re: bzr on Windows

2008-06-26 Thread Robert Collins
On Thu, 2008-06-26 at 08:42 +0200, Guido Serassio wrote: The reality is that Squid is the the FIRST multiplatform open source project adopting bzr You're wrong here. , and the result was that bzr adoption broke the Squid Windows development, nothing else. I'm suspecting that Canonical

Re: bzr on Windows

2008-06-26 Thread Robert Collins
On Thu, 2008-06-26 at 11:29 +0200, Guido Serassio wrote: I'm really sorry that none of the existing workarounds suited you, the whole migration thing was done with huge amounts of warning, me asking *repeatedly* for feedback and not getting any from you until extremely late in the piece.

Re: RFC: delayed Logdaemon port merge

2008-06-25 Thread Robert Collins
On Thu, 2008-06-26 at 08:21 +0800, Adrian Chadd wrote: 2008/6/25 Guido Serassio [EMAIL PROTECTED]: Please also add the Windows support to the list, still totally broken and still without any usable VCS on Windows . There isn't a bzr implementation for Windows? Its just python, isn't

Re: Intro

2008-05-06 Thread Robert Collins
On Tue, 2008-05-06 at 15:48 -0400, Michael Conlen wrote: Hey, I'm the systems manager and developer for a business with a significant internet presence which uses squid to cache static content to reduce load from the apache cluster to the NFS server. I'm interested in modifying squid to

Re: zph and squid-3.0

2008-05-06 Thread Robert Collins
On Wed, 2008-05-07 at 14:38 +1200, Amos Jeffries wrote: I don't think the zph patch belongs in 3.0.STABLE. It's a new feature with several new directives, not a bugfix, and additionally I'd like a bit of cleanup before release. Saw that it got merged to 3.0 some day ago... and I vote

Re: Blocker bzr problem on Windows

2008-04-15 Thread Robert Collins
On Tue, 2008-04-15 at 20:30 +0200, Guido Serassio wrote: Hi Robert, I hope that a simple and reliable solution will be available soon. But my time resources are (and will be for the next months) limited for family reasons. So, while waiting for the fix to bzr, I will stop at all my

XPROF_STATS update for amd64?

2008-04-13 Thread Robert Collins
Anyone up for doing this... In file included from /home/robertc/source/squid/trunk/lib/hash.c:64: /home/robertc/source/squid/trunk/include/profiling.h:59:2: error: #warning Unsupported CPU. Define function get_tick(). Disabling USE_XPROF_STATS... processor : 0 vendor_id :

Re: Blocker bzr problem on Windows

2008-04-12 Thread Robert Collins
On Fri, 2008-04-11 at 14:28 -0600, Alex Rousskov wrote: On Fri, 2008-04-11 at 22:19 +0200, Guido Serassio wrote: I'm very scared for what could be happen in the main repository if the script will be fail before a commit :-( Do not run the script automatically before bzr commit.

Re: Blocker bzr problem on Windows

2008-04-12 Thread Robert Collins
On Fri, 2008-04-11 at 13:30 -0600, Alex Rousskov wrote: On Fri, 2008-04-11 at 11:29 +0200, Guido Serassio wrote: There is a very big problem using bzr on Windows: The files downloaded by bzr are in Unix text format, while CVS file are in DOS text format. This will totally broke

Re: [MERGE] Merged from trunk

2008-04-09 Thread Robert Collins
On Wed, 2008-04-09 at 12:07 -0600, Alex Rousskov wrote: On Wed, 2008-04-09 at 22:47 +0800, Adrian Chadd wrote: I'd really like to see the shuffling around seperated from the integration of the tproxy4 code - ie, (at least) two seperate commits. I expect separate commits as well. When

Re: bzr issues

2008-04-03 Thread Robert Collins
On Thu, 2008-04-03 at 12:57 +0200, Kinkie wrote: IMO integration with other tools should use out-of-band information, such as an extra mail header. [MERGE] in the subject is good to interact with humans, but too flimsy to be used with automated tools. [MERGE] is used so humans can manually

Re: bzr issues

2008-04-02 Thread Robert Collins
On Wed, 2008-04-02 at 11:21 -0600, Alex Rousskov wrote: I think an incomplete [MERGE] default subject would be much better that the current behavior that will lead to _incorrect_ subjects. In addition, a command line option to specify the subject should be added. Amos wasn't entirely

Re: bzr send

2008-04-02 Thread Robert Collins
On Wed, 2008-04-02 at 14:56 -0600, Alex Rousskov wrote: On Wed, 2008-04-02 at 21:16 +0200, Henrik Nordstrom wrote: ons 2008-04-02 klockan 10:51 -0600 skrev Alex Rousskov: I doubt bzr managed to generate a proper bundle, even though I did follow instructions and did _not_ commit before

Re: bzr issues

2008-04-02 Thread Robert Collins
On Wed, 2008-04-02 at 15:52 -0600, Alex Rousskov wrote: On Thu, 2008-04-03 at 08:38 +1100, Robert Collins wrote: On Wed, 2008-04-02 at 11:21 -0600, Alex Rousskov wrote: I think an incomplete [MERGE] default subject would be much better that the current behavior that will lead

<    1   2   3   4   5   6   7   >