Re: /bzr/squid3/trunk/ r9386: Bug 2395: FTP auth errors not displayed

2008-12-02 Thread Henrik Nordstrom
tis 2008-12-02 klockan 13:55 +1300 skrev Amos Jeffries: > > Isn't the real question who called FwdState::complete()? It's only meant > > to be called when all data has been placed into the entry, not before.. > > > > I started with that idea, but the code proved to be very convoluted. > > On an e

Re: /bzr/squid3/trunk/ r9386: Bug 2395: FTP auth errors not displayed

2008-12-01 Thread Amos Jeffries
> Isn't the real question who called FwdState::complete()? It's only meant > to be called when all data has been placed into the entry, not before.. > I started with that idea, but the code proved to be very convoluted. On an error the FTP engine calls ftpFail(), which syncs down to FtpSate::fail

Re: /bzr/squid3/trunk/ r9386: Bug 2395: FTP auth errors not displayed

2008-12-01 Thread Henrik Nordstrom
Isn't the real question who called FwdState::complete()? It's only meant to be called when all data has been placed into the entry, not before.. tis 2008-12-02 klockan 00:56 +1300 skrev Amos Jeffries: > > revno: 9386 > committer: Amo