Re: [PATCH] Add build info tag to squid -v output

2010-09-08 Thread Amos Jeffries
On 08/09/10 17:52, Kinkie wrote: Calling the variable DISTCHECK_CONFIGURE_FLAGS makes no sense when distcheck is itself a variable selectable by the layer. CONFIGURE_FLAGS would be sufficient. Other than that. Okay. +1 It used to originally set OPTS and then copy OPTS to a variable of that

Re: [PATCH] Add build info tag to squid -v output

2010-09-07 Thread Kinkie
Hi all, here's the second release of the build-info patch. Changes: - address Amos' comments about configure test - implement Alex's +changes suggestion - fix the extra empty line if no version issue While testing it, I've discovered that test-builds.sh doesn't really handle arguments with

Re: [PATCH] Add build info tag to squid -v output

2010-09-07 Thread Amos Jeffries
On Tue, 7 Sep 2010 16:38:51 +0200, Kinkie gkin...@gmail.com wrote: Hi all, here's the second release of the build-info patch. Changes: - address Amos' comments about configure test - implement Alex's +changes suggestion - fix the extra empty line if no version issue While testing it,

Re: [PATCH] Add build info tag to squid -v output

2010-09-07 Thread Kinkie
Calling the variable DISTCHECK_CONFIGURE_FLAGS makes no sense when distcheck is itself a variable selectable by the layer. CONFIGURE_FLAGS would be sufficient. Other than that. Okay. +1 It used to originally set OPTS and then copy OPTS to a variable of that name; I left it as that as I

Re: [PATCH] Add build info tag to squid -v output

2010-09-04 Thread Amos Jeffries
Kinkie wrote: Hi all, a followup to yesterday's and today's IRC discussion. This patch adds a configure option --enable-build-info[=text] If text is specified, it will print it on the second line of squid -v. If the option is given but no text is specified, configure will attempt to determine

Re: [PATCH] Add build info tag to squid -v output

2010-09-04 Thread Kinkie
On Sat, Sep 4, 2010 at 3:25 PM, Amos Jeffries squ...@treenet.co.nz wrote: Kinkie wrote: Hi all,  a followup to yesterday's and today's IRC discussion. This patch adds a configure option --enable-build-info[=text] If text is specified, it will print it on the second line of squid -v. If the

Re: [PATCH] Add build info tag to squid -v output

2010-09-04 Thread Kinkie
On Sat, Sep 4, 2010 at 8:50 PM, Alex Rousskov rouss...@measurement-factory.com wrote: On 09/03/2010 11:37 AM, Kinkie wrote: Hi all,   a followup to yesterday's and today's IRC discussion. This patch adds a configure option --enable-build-info[=text] If text is specified, it will print it on

[PATCH] Add build info tag to squid -v output

2010-09-03 Thread Kinkie
Hi all, a followup to yesterday's and today's IRC discussion. This patch adds a configure option --enable-build-info[=text] If text is specified, it will print it on the second line of squid -v. If the option is given but no text is specified, configure will attempt to determine whether we are