Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-07-10 Thread Tsantilas Christos
If there are no objections I will apply the latest patch to trunk. Regards, Christos On 06/26/2014 05:45 PM, Tsantilas Christos wrote: A new patch. Changes: - clt_conn_id renamed to clt_conn_tag - Amos requested fixes. I hope it is OK. Regards, Christos On 06/22/2014 08:43 PM, Tsa

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-26 Thread Tsantilas Christos
A new patch. Changes: - clt_conn_id renamed to clt_conn_tag - Amos requested fixes. I hope it is OK. Regards, Christos On 06/22/2014 08:43 PM, Tsantilas Christos wrote: Hi all, The attached patch replaces existin annotation values with the new one received from helpers. Just one ques

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-24 Thread Alex Rousskov
On 06/23/2014 11:00 PM, Amos Jeffries wrote: > On 24/06/2014 8:19 a.m., Alex Rousskov wrote: >> On 06/23/2014 07:44 AM, Tsantilas Christos wrote: >>> On 06/23/2014 09:50 AM, Amos Jeffries wrote: On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: > clt_conn_id=ID > Associates the

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-24 Thread Tsantilas Christos
On 06/24/2014 08:21 AM, Amos Jeffries wrote: On 24/06/2014 1:44 a.m., Tsantilas Christos wrote: On 06/23/2014 09:50 AM, Amos Jeffries wrote: On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: in src/Notes.cc: * replaceOrAdd iterates over the notes list twice in the event of removals (due to re

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Amos Jeffries
On 24/06/2014 1:44 a.m., Tsantilas Christos wrote: > On 06/23/2014 09:50 AM, Amos Jeffries wrote: >> On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: >>> Hi all, >>> >>> The attached patch replaces existin annotation values with the new one >>> received from helpers. >>> >>> Just one question. We

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Amos Jeffries
On 24/06/2014 8:19 a.m., Alex Rousskov wrote: > On 06/23/2014 07:44 AM, Tsantilas Christos wrote: >> On 06/23/2014 09:50 AM, Amos Jeffries wrote: >>> On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: clt_conn_id=ID Associates the received ID with the client TCP connection.

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Alex Rousskov
On 06/23/2014 07:44 AM, Tsantilas Christos wrote: > On 06/23/2014 09:50 AM, Amos Jeffries wrote: >> On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: >>> clt_conn_id=ID >>> Associates the received ID with the client TCP connection. >>> The clt_conn_id=ID pair is treated as a regular an

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Tsantilas Christos
On 06/23/2014 09:50 AM, Amos Jeffries wrote: On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: Hi all, The attached patch replaces existin annotation values with the new one received from helpers. Just one question. We are documenting key-value pairs in cf.data.pre only for url-rewriter helpe

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-22 Thread Amos Jeffries
On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: > Hi all, > > The attached patch replaces existin annotation values with the new one > received from helpers. > > Just one question. We are documenting key-value pairs in cf.data.pre > only for url-rewriter helpers, but annotations works for all

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-22 Thread Amos Jeffries
On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: > Hi all, > > The attached patch replaces existin annotation values with the new one > received from helpers. > > Just one question. We are documenting key-value pairs in cf.data.pre > only for url-rewriter helpers, but annotations works for all

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-22 Thread Tsantilas Christos
Hi all, The attached patch replaces existin annotation values with the new one received from helpers. Just one question. We are documenting key-value pairs in cf.data.pre only for url-rewriter helpers, but annotations works for all squid helpers. Should we move the related url-rewriter sectio

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-19 Thread Amos Jeffries
On 20/06/2014 6:07 a.m., Tsantilas Christos wrote: > On 06/16/2014 06:36 PM, Alex Rousskov wrote: >> On 06/15/2014 12:07 AM, Amos Jeffries wrote: >>> On 15/06/2014 4:58 a.m., Alex Rousskov wrote: On 06/11/2014 08:52 AM, Tsantilas Christos wrote: > I must also note that this patch adds

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-19 Thread Tsantilas Christos
On 06/16/2014 06:36 PM, Alex Rousskov wrote: On 06/15/2014 12:07 AM, Amos Jeffries wrote: On 15/06/2014 4:58 a.m., Alex Rousskov wrote: On 06/11/2014 08:52 AM, Tsantilas Christos wrote: I must also note that this patch adds an inconsistency. All annotation key=values pairs received from help

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-16 Thread Alex Rousskov
On 06/15/2014 12:07 AM, Amos Jeffries wrote: > On 15/06/2014 4:58 a.m., Alex Rousskov wrote: >> On 06/11/2014 08:52 AM, Tsantilas Christos wrote: >> >>> I must also note that this patch adds an inconsistency. All annotation >>> key=values pairs received from helpers, accumulated to the existing ke

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-14 Thread Amos Jeffries
On 15/06/2014 4:58 a.m., Alex Rousskov wrote: > On 06/11/2014 08:52 AM, Tsantilas Christos wrote: > >> I must also note that this patch adds an inconsistency. All annotation >> key=values pairs received from helpers, accumulated to the existing key >> notes values. The clt_conn_id=Id pair is alwa

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-14 Thread Alex Rousskov
On 06/11/2014 08:52 AM, Tsantilas Christos wrote: > I must also note that this patch adds an inconsistency. All annotation > key=values pairs received from helpers, accumulated to the existing key > notes values. The clt_conn_id=Id pair is always unique and replaces the > existing clt_conn_id=Id

[PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-11 Thread Tsantilas Christos
TCP client connections tagging is useful for faking various forms of connection-based "authentication" when standard HTTP authentication cannot be used. A URL rewriter or, external ACL helper may mark the "authenticated" client connection to avoid going through "authentication" steps during sub