Re: [PATCH] port of http_access2 from 2.6

2010-01-22 Thread Alex Rousskov
On 01/20/2010 04:02 PM, Amos Jeffries wrote: > On Wed, 20 Jan 2010 09:58:01 -0700, Alex Rousskov > wrote: >> Should the documentation mention that redirects are performed before the >> second access check? > > I think so. That being one of the two differences between this and > http_access. > Or

Re: [PATCH] port of http_access2 from 2.6

2010-01-20 Thread Amos Jeffries
On Wed, 20 Jan 2010 09:58:01 -0700, Alex Rousskov wrote: > On 01/19/2010 07:16 PM, Amos Jeffries wrote: >> I think this is right. Anyone able to double-check me though? > > Should the documentation mention that redirects are performed before the > second access check? I think so. That being one

Re: [PATCH] port of http_access2 from 2.6

2010-01-20 Thread Alex Rousskov
On 01/19/2010 07:16 PM, Amos Jeffries wrote: > I think this is right. Anyone able to double-check me though? Should the documentation mention that redirects are performed before the second access check? I am not a big fan of fooN names. Is using something more specific like post_adaptation_access

[PATCH] port of http_access2 from 2.6

2010-01-19 Thread Amos Jeffries
I think this is right. Anyone able to double-check me though? Amos === modified file 'src/ClientRequestContext.h' --- src/ClientRequestContext.h 2009-07-13 01:20:26 + +++ src/ClientRequestContext.h 2010-01-20 02:07:17 + @@ -26,6 +26,7 @@ bool httpStateIsValid(); void clientA