Re: [Squid-cvs] squid3-ipv6 squid3/include config.h,1.7.4.2,1.7.4.3

2005-05-16 Thread Henrik Nordstrom
On Mon, 16 May 2005, Rafael Martinez Torres wrote: Fine for me, or perhaps address_needs_brackets? inline bool address_needs_brackets(const char *host) { return SAFE_INET_ADDR(host,NULL); } But this should be then moved into "squid.h" or another more appropiate place other than "conf

Re: [Squid-cvs] squid3-ipv6 squid3/include config.h,1.7.4.2,1.7.4.3

2005-05-16 Thread Rafael Martinez Torres
> > > Hmmm... Yes.. May be URL_NEEDS_BRACKETS ? Any suggestion ? > > Fine for me, or perhaps address_needs_brackets? > > inline bool address_needs_brackets(const char *host) > { > return SAFE_INET_ADDR(host,NULL); > } > > But this should be then moved into "squid.h" or another more

Re: [Squid-cvs] squid3-ipv6 squid3/include config.h,1.7.4.2,1.7.4.3

2005-05-15 Thread Henrik Nordstrom
On Sun, 15 May 2005, Rafael Martinez Torres wrote: The format of IPv6 URLs are sligthly modified . Since the dotted addresses can containg ":" character, it was to mandatory to support brackets to split the dotted host address from the port. i.e: This do not apply to the DNS names... http://124.35.

Re: [Squid-cvs] squid3-ipv6 squid3/include config.h,1.7.4.2,1.7.4.3

2005-05-15 Thread Rafael Martinez Torres
> > > Tag: squid3-ipv6 > > config.h > > > > +#define NEEDS_BRACKETS(s) \ > > +SAFE_INET_ADDR(s,NULL) > > + > > Just curious, but what is the rationale behind this macro? > Okey. The format of IPv6 URLs are sligthly modified . Since the dotted addresses c

Re: [Squid-cvs] squid3-ipv6 squid3/include config.h,1.7.4.2,1.7.4.3

2005-05-15 Thread Henrik Nordstrom
On Sun, 15 May 2005, Rafael Martinez Torres wrote: Tag: squid3-ipv6 config.h +#define NEEDS_BRACKETS(s) \ +SAFE_INET_ADDR(s,NULL) + Just curious, but what is the rationale behind this macro? Brobably also needs a better name... NEEDS_BRACKETS is pretty