Re: Long response header problem

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 23:21 +0200 skrev Axel Westerhold: > Uhmmm, > > See my mybeReadVirginBody() from Stable4 > > Any chance that you re using CVS ? Hmm.. yes. I am using current Squid-3.0 sources and thought this was in STABLE4.. looking again it's not.. The patch is here: http://www.squid-

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
> Axel Westerhold wrote: >>> mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: >>> --- src/http.cc 2008-04-01 13:54:38.0 +0200 +++ src/http.cc 2008-04-21 19:11:47.0 +0200 @@ -1200,7 +1200,7 @@ void HttpStateData::maybeReadVirginBody() {

Re: Long response header problem

2008-04-21 Thread Amos Jeffries
Axel Westerhold wrote: mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: --- src/http.cc 2008-04-01 13:54:38.0 +0200 +++ src/http.cc 2008-04-21 19:11:47.0 +0200 @@ -1200,7 +1200,7 @@ void HttpStateData::maybeReadVirginBody() { -int read_sz = replyBodySpace(readBuf

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
As said before, not my day. I did my checkes with Stable4 without the applied logresp patch. That's why I missed if (read_sz < 2) { if (flags.headers_parsed) return; else read_sz = 1024; } S, as a guess my initial patch (with the longresp ) went wrong

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
> mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: > >> --- src/http.cc 2008-04-01 13:54:38.0 +0200 >> +++ src/http.cc 2008-04-21 19:11:47.0 +0200 >> @@ -1200,7 +1200,7 @@ >> void >> HttpStateData::maybeReadVirginBody() >> { >> -int read_sz = replyBodySpace(readBuf-

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
> mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: > >> --- src/http.cc 2008-04-01 13:54:38.0 +0200 >> +++ src/http.cc 2008-04-21 19:11:47.0 +0200 >> @@ -1200,7 +1200,7 @@ >> void >> HttpStateData::maybeReadVirginBody() >> { >> -int read_sz = replyBodySpace(readBuf-

Re: Long response header problem

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: > --- src/http.cc 2008-04-01 13:54:38.0 +0200 > +++ src/http.cc 2008-04-21 19:11:47.0 +0200 > @@ -1200,7 +1200,7 @@ > void > HttpStateData::maybeReadVirginBody() > { > -int read_sz = replyBodySpace(readBuf->spaceSize(

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
> Hmm.. can't seem to reproduce this. > > The proposed change do not fix the problem, just hides it a bit. See my last mail of three (:-) sorry Not my best day) > > The 3.0.STABLE4 code already bumps the read size to 1KB minimum when > headers haven't been successfully parsed yet. See > Http

Re: Long response header problem

2008-04-21 Thread Henrik Nordstrom
Hmm.. can't seem to reproduce this. The proposed change do not fix the problem, just hides it a bit. The 3.0.STABLE4 code already bumps the read size to 1KB minimum when headers haven't been successfully parsed yet. See HttpStateData::maybeReadVirginBody() Do you have an example URL triggering t

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
And one more. It might be this patch which solved the issue --- src/http.cc 2008-04-01 13:54:38.0 +0200 +++ src/http.cc 2008-04-21 19:11:47.0 +0200 @@ -1200,7 +1200,7 @@ void HttpStateData::maybeReadVirginBody() { -int read_sz = replyBodySpace(readBuf->spaceSize()); +int

Long response header problem

2008-04-21 Thread Axel Westerhold
Hi there, I ran, or better a customer ran into a problem today which sounded like this bug. http://www.squid-cache.org/bugs/show_bug.cgi?id=2001 So I applied the attached patch to squid-3.0.STABLE4 and did a quick test. Still the same problem. By cache.log looks like this ... comm_read_try: F

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
Ok, Did some additional checks, It should be --- src/http.cc 2008-04-01 13:54:38.0 +0200 +++ src/http.cc 2008-04-21 16:42:19.0 +0200 @@ -75,7 +75,7 @@ surrogateNoStore = false; fd = fwd->server_fd; readBuf = new MemBuf; -readBuf->init(4096, SQUID_TCP_S