Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-10 Thread Alex Rousskov
On Mon, 2008-03-10 at 18:59 +1300, Amos Jeffries wrote: Alex Rousskov wrote: IMO, at the end of the cleanup, squid.h should be the file that all sources are guaranteed to include first simply because it is called squid.h. Config.h has, by name, a much narrower scope. I realize that

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-10 Thread Amos Jeffries
Alex Rousskov wrote: On Mon, 2008-03-10 at 18:59 +1300, Amos Jeffries wrote: Alex Rousskov wrote: IMO, at the end of the cleanup, squid.h should be the file that all sources are guaranteed to include first simply because it is called squid.h. Config.h has, by name, a much narrower scope. I

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://squid-cache.org/bundlebuggy//request/%3C20080309110310.889A6E9FF1%40treenet.co.nz%3E

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Alex Rousskov
On Mon, 2008-03-10 at 00:03 +1300, Amos Jeffries wrote: - removes squid.h includes from many unit-tests I think this is a step backwards (which may be OK as a temporary measure, but I think there are better ways to deal with the problem at hand). IMO, virtually all Squid sources should include

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Henrik Nordstrom
On Sun, 2008-03-09 at 11:23 -0600, Alex Rousskov wrote: IMO, virtually all Squid sources should include (directly or indirectly) squid.h as the first include file. In my experience, this design is very useful for portability and other hacks. We have two such files include/config.h project

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Amos Jeffries
On Sun, 2008-03-09 at 11:23 -0600, Alex Rousskov wrote: IMO, virtually all Squid sources should include (directly or indirectly) squid.h as the first include file. In my experience, this design is very useful for portability and other hacks. We have two such files include/config.h

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Alex Rousskov
On Sun, 2008-03-09 at 22:23 +0100, Henrik Nordstrom wrote: Or we could consider squid.h the dirty one, moving out the little tweaks which is there to config.h or better places. IMO, at the end of the cleanup, squid.h should be the file that all sources are guaranteed to include first simply

Re: [MERGE] Remove old .h file tests from unit-testing

2008-03-09 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-03-09 at 22:23 +0100, Henrik Nordstrom wrote: Or we could consider squid.h the dirty one, moving out the little tweaks which is there to config.h or better places. IMO, at the end of the cleanup, squid.h should be the file that all sources are guaranteed to