Re: comm_connect_addr broke in squid3/trunk?

2008-04-01 Thread Amos Jeffries
Amos Jeffries wrote: On Tue, 2008-04-01 at 00:08 +1300, Amos Jeffries wrote: Probably a muckup by me in the code setting the sockaddr_storage content. Can you get a trace with output of the sas variable fields? I have abort()ed Squid after a negative connect() return value is detected. Here

Re: comm_connect_addr broke in squid3/trunk?

2008-04-01 Thread Henrik Nordstrom
tis 2008-04-01 klockan 17:24 +0800 skrev Adrian Chadd: Wait a sec, which platforms don't have sin_len in which struct? I think amos meant to say ss_len in struct sockaddr_storage, which not very frequently seen as not all address families need a length.. (for example on Linux) I do not know of

Re: comm_connect_addr broke in squid3/trunk?

2008-04-01 Thread Adrian Chadd
On Tue, Apr 01, 2008, Amos Jeffries wrote: I've made a test patch to fix that: http://treenet.co.nz/projects/squid/patches/alex-20080401.patch Though I am not sure if the #if defined(sin_len) will work properly. Can you try it with and without those lines please before you roll back the

Re: comm_connect_addr broke in squid3/trunk?

2008-04-01 Thread Amos Jeffries
Henrik Nordstrom wrote: tis 2008-04-01 klockan 22:59 +1300 skrev Amos Jeffries: I started out that way (assuming ss_len was absent but sin_len was present) but a header analysis proved the assumption wrong. sin_len also proves very absent from Debian Linux 2.6.25 headers. Somehow I doubt

Re: comm_connect_addr broke in squid3/trunk?

2008-04-01 Thread Henrik Nordstrom
tis 2008-04-01 klockan 22:59 +1300 skrev Amos Jeffries: I started out that way (assuming ss_len was absent but sin_len was present) but a header analysis proved the assumption wrong. sin_len also proves very absent from Debian Linux 2.6.25 headers. Somehow I doubt that linux would change the

Re: comm_connect_addr broke in squid3/trunk?

2008-04-01 Thread Henrik Nordstrom
ons 2008-04-02 klockan 00:38 +1300 skrev Amos Jeffries: rio:/usr/include# grep -R sin_len ./* Right.. I wonder where I was looking. Can't find it again today. Regards Henrik

comm_connect_addr broke in squid3/trunk?

2008-03-31 Thread Alex Rousskov
Hello, I am getting the following Invalid argument error on any connect(2) after updating my trunk copy: 00:16:24.833| commConnectStart: FD 10, cb 0x8b60780*1, 10.0.0.104:1344 00:16:24.833| comm_add_close_handler: FD 10, handler=1, data=0x8c64010 00:16:24.833| cbdataLock: 0x8c64010=1

Re: comm_connect_addr broke in squid3/trunk?

2008-03-31 Thread Amos Jeffries
Alex Rousskov wrote: Hello, I am getting the following Invalid argument error on any connect(2) after updating my trunk copy: 00:16:24.833| commConnectStart: FD 10, cb 0x8b60780*1, 10.0.0.104:1344 00:16:24.833| comm_add_close_handler: FD 10, handler=1, data=0x8c64010 00:16:24.833|

Re: comm_connect_addr broke in squid3/trunk?

2008-03-31 Thread Alex Rousskov
On Tue, 2008-04-01 at 00:08 +1300, Amos Jeffries wrote: Probably a muckup by me in the code setting the sockaddr_storage content. Can you get a trace with output of the sas variable fields? I have abort()ed Squid after a negative connect() return value is detected. Here is the backtrace and

Re: comm_connect_addr broke in squid3/trunk?

2008-03-31 Thread Amos Jeffries
On Tue, 2008-04-01 at 00:08 +1300, Amos Jeffries wrote: Probably a muckup by me in the code setting the sockaddr_storage content. Can you get a trace with output of the sas variable fields? I have abort()ed Squid after a negative connect() return value is detected. Here is the backtrace