On Tue, 18 Nov 2003, Andres Kroonmaa wrote:
> > > - if (isupper(*s1))
> > > + if (isupper((int)(char)*s1))
> >
> > This cast it not correct. The input to isupper and any other ctype
> > functions should be a unsigned char manually or implicitly casted to int..
>
> is it harmful? I thought, if I
On Tue, 18 Nov 2003, Andres Kroonmaa wrote:
> indeed:
> /usr/include/ia32/sys/reg.h:#if !defined(_XPG4_2) || defined(__EXTENSIONS__)
> /usr/include/ia32/sys/reg.h:#define CS 15
> /usr/include/ia32/sys/reg.h:#define FS 1
> /usr/include/ia32/sys/reg.h:#define PS EFL
And
On Tue, 2003-11-18 at 19:28, Andres Kroonmaa wrote:
> So, then, what is correct way to solve this? Rename vars in all cases
> that conflict? I'll submit you a patch with rename changes, and you'll
> review for consistent naming conventions, ok?
Yeah, thats probably the lowest impact fix.
Rob
On 17 Nov 2003, at 22:09, Henrik Nordstrom <[EMAIL PROTECTED]> wrote:
> On Mon, 17 Nov 2003, Andres Kroonmaa wrote:
>
> > gcc (3.3.1 and 3.3.2) produce error whenever there is variable
> > definition with all uppercase:
> >
> > protos.h
> > -SQUIDCEXTERN void fwdServersFree(FwdServer ** FS);
> >
On Mon, 17 Nov 2003, Andres Kroonmaa wrote:
> gcc (3.3.1 and 3.3.2) produce error whenever there is variable
> definition with all uppercase:
>
> protos.h
> -SQUIDCEXTERN void fwdServersFree(FwdServer ** FS);
> +SQUIDCEXTERN void fwdServersFree(FwdServer ** fs);
Most likely there is a #define
sFree(FwdServer ** FS);
+SQUIDCEXTERN void fwdServersFree(FwdServer ** fs);
with uppercase compile produces error: parse error before numeric constant
As there are quite many such places I suspect something is wrong on my end.
anyone point me to right rtfm?
A
