Re: logfile writing

2006-07-16 Thread Adrian Chadd
On Mon, Jul 17, 2006, Henrik Nordstrom wrote: > m??n 2006-07-17 klockan 09:07 +0800 skrev Adrian Chadd: > > > > You flush any pending buffers first, right? > > > > This patch doesn't do that yet. It wasn't that important as buffered data > > doesn't get lost during a rotate. > > The main reason

Re: logfile writing

2006-07-16 Thread Henrik Nordstrom
mån 2006-07-17 klockan 09:07 +0800 skrev Adrian Chadd: > > You flush any pending buffers first, right? > > This patch doesn't do that yet. It wasn't that important as buffered data > doesn't get lost during a rotate. The main reason to flush on rotate is to ensure the logs are whole. It is not d

Re: logfile writing

2006-07-16 Thread Henrik Nordstrom
mån 2006-07-17 klockan 09:07 +0800 skrev Adrian Chadd: > Robert: I do remember your work having that annoying problem of dropping > logfile entries. I've got an idea on how to test it (I'll write a script > to throw lots of consecutively-numbered requests at my code and make sure > they all appear

Re: logfile writing

2006-07-16 Thread Adrian Chadd
On Mon, Jul 17, 2006, Henrik Nordstrom wrote: > Instead of the linked list of separately maintained buffers, have you > considered using MemBuf:s? Nope! I just did this quick hack to mirror stuff I've done in the past under Linux/BSD to try and stuff IPC IO into page-aligned buffers to exploit CO

Re: logfile writing

2006-07-16 Thread Henrik Nordstrom
mån 2006-07-17 klockan 09:25 +1000 skrev Robert Collins: > I did a patch for squid 2.x/early 3.0 that did something similar - and > it suffered from dropped log contents during high load... which is > something I never got *satisfactorily* addressed - its the key thing I > think needs considering.

Re: logfile writing

2006-07-16 Thread Robert Collins
On Mon, 2006-07-17 at 00:15 +0200, Henrik Nordstrom wrote: > sön 2006-07-16 klockan 21:49 +0800 skrev Adrian Chadd: > > > I've written some code to push logfile writing into an external process, > > freeing up the main squid process from the potentially blocking >

Re: logfile writing

2006-07-16 Thread Henrik Nordstrom
sön 2006-07-16 klockan 21:49 +0800 skrev Adrian Chadd: > I've written some code to push logfile writing into an external process, > freeing up the main squid process from the potentially blocking > stdio writes. Good. > This code isn't ready to be merged into squid-2.

logfile writing

2006-07-16 Thread Adrian Chadd
Hiya, I've written some code to push logfile writing into an external process, freeing up the main squid process from the potentially blocking stdio writes. This code isn't ready to be merged into squid-2.6. Its meant more as a prototype. I haven't even reviewed it for '