[sr-dev] Pull request example

2018-10-24 Thread Diego Nadares
Hi guys, I hit a little bug in evapi module. I would like to do a pull request but i don't know exactly how to accomplish this. I found this howto -> https://yangsu.github.io/pull-request-tutorial . Are these the correct steps? I tried but it's forbidden for my user. git checkout -b pull-reques

Re: [sr-dev] [kamailio/kamailio] cfg_rpc updates changing variable values to large random numbers (#1679)

2018-10-24 Thread Daniel-Constantin Mierla
@vinesinha - thanks for detailed troubleshooting and testing! @mtirpak - thanks for the patch, you can push the commit with it to master branch if you want, otherwise I can do it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on Git

Re: [sr-dev] [kamailio/kamailio] Core generated by Kamailio when a bad char is found in header (#1687)

2018-10-24 Thread Daniel-Constantin Mierla
The first two backtraces led to a function related to a new feature added in 5.2, respectively statistics for replies per method. The issue was accessing CSeq header fields without any checks if the header was properly parsed. I pushed a commit for it, referenced above. You can try with latest m

[sr-dev] git:master:5e763029: kex: safety check for accessing CSeq in per method stats

2018-10-24 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 5e763029dc207c99796adc1c3ace71cf6de59446 URL: https://github.com/kamailio/kamailio/commit/5e763029dc207c99796adc1c3ace71cf6de59446 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-10-25T07:07:52+02:00 kex: safety check for

Re: [sr-dev] Pull request example

2018-10-24 Thread Diego Nadares
Sorry, I think this is the correct link of the PR. https://github.com/kamailio/kamailio/pull/1688 Cheers, Diego > On Oct 24, 2018, at 10:41 PM, Diego Nadares wrote: > > Thanks for your answer Henning. I generated the following PR >

[sr-dev] [kamailio/kamailio] evapi: minor fix in tag length compare (#1688)

2018-10-24 Thread dnadares
It was assigning the length instead of comparing it. Pre-Submission Checklist - [X ] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash

Re: [sr-dev] Pull request example

2018-10-24 Thread Diego Nadares
Thanks for your answer Henning. I generated the following PR . Please, let me know if its ok or if I should modify the template. Cheers. Diego. El miƩ., 24 oct. 2018 a las 17:24, Henning Westerholt

Re: [sr-dev] [kamailio/kamailio] Core generated by Kamailio when a bad char is found in header (#1687)

2018-10-24 Thread Joel Serrano
To add a more specific version as `5.2.0-pre1` doesn't say much...: ``` root@sbc01:/var/tmp# dpkg -l | grep kam ii kamailio5.2.0~pre1+0~20181020005754.1238+stretch amd64very fast, dynamic and configurable SIP server ii kamailio-dbg:amd64 5.2.0~pre1+0

[sr-dev] [kamailio/kamailio] Core generated by Kamailio when a bad char is found in header (#1687)

2018-10-24 Thread Joel Serrano
### Description Kamailio dies complaining about a bad char in some header. I can say that I just updated from the nightly-devel apt repo, this problem never happened in latest v5.1 release. ### Troubleshooting Reproduction I don't know how to reproduce yet. Debugging Data [BT-F

Re: [sr-dev] Pull request example

2018-10-24 Thread Henning Westerholt
Am Mittwoch, 24. Oktober 2018, 16:48:51 CEST schrieb Diego Nadares: > I hit a little bug in evapi module. I would like to do a pull request but i > don't know exactly how to accomplish this. > > I found this howto -> https://yangsu.github.io/pull-request-tutorial . Are > these the correct steps? >

Re: [sr-dev] [kamailio/kamailio] cfg_rpc updates changing variable values to large random numbers (#1679)

2018-10-24 Thread vinesinha
So, now the linked list is populated in the same order as it is read. This solved the issue. The diff looks good to me [tested]. Thanks for the help! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kam

Re: [sr-dev] [kamailio/kamailio] RPC command stats.get_statistics randomly reporting 9223372036854776000 for current active/early dialogs (#1591)

2018-10-24 Thread Joel Serrano
Hi @miconda, sorry for the delay, it's taken me a while until I have been able to test this.. I can confirm so far that `dlg.stats_active` works correctly, it's in sync between both nodes all the time, so any changes to the dialogs are reflected there instantly on both nodes. But, something m

[sr-dev] [kamailio/kamailio] Crash ims_diameter_server module (#1686)

2018-10-24 Thread iman432
Hi dears When the below format from restful is sent, kamailio crashes List List List (Json with 3 lists), With 2 lists it works properly, When diameter is translated to json with 3 lists by this module it also works properly, Json format is correct too. Where is problem? Thanks

[sr-dev] [kamailio/kamailio] nsq: deprecate json and pua funcs for json api and pua_json modules (#1685)

2018-10-24 Thread Emmanuel Schmidbauer
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1685 -- Commit Summary -- * nsq: deprecate json and pua funcs for json api and pua_json modules -- File Changes -- M src/modules/nsq/Makefile (3) M src/modules/nsq/doc/nsq_adm

[sr-dev] Pull request example

2018-10-24 Thread Diego Nadares
Hi guys, I hit a little bug in evapi module. I would like to do a pull request but i don't know exactly how to accomplish this. I found this howto -> https://yangsu.github.io/pull-request-tutorial . Are these the correct steps? I tried but it's forbidden for my user. git checkout -b pull-reques

Re: [sr-dev] [kamailio/kamailio] pipelimit module documentation error? (#1671)

2018-10-24 Thread Rogelio Perez
Thanks @miconda, I'll post my findings here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1671#issuecomment-432682998___ Kamailio (SER

[sr-dev] [kamailio/kamailio] Wrong QOP value in UAC auth_alg (#1684)

2018-10-24 Thread Sebastian Lauwers
### Description While trying to setup a handoff to a third party SIP trunk with authentication, I ran into some issues with said authentication. I'm using qop auth on the inbound leg (and `consume_credentials()`), and then UAC to authenticate against the SIP trunk with different credentials. Th

Re: [sr-dev] [kamailio/kamailio] usrloc: call contact expired call back for a domain with db_mode: DB_ONLY (#1683)

2018-10-24 Thread adil-mafzool
@miconda: Adding db_mode would be required since db_timer_udomain is now being called for different db_modes. @henningw: Had seen that but since the concept was duplicated from ``preload_udomain``` where ucontact was being freed where as urecord was not. It looks like urecord is using static mem

Re: [sr-dev] [kamailio/kamailio] usrloc: call contact expired call back for a domain with db_mode: DB_ONLY (#1683)

2018-10-24 Thread adil-mafzool
@adil-mafzool pushed 1 commit. 531e613 usrloc: only execute funtion udomain_contact_expired_cb when db_mode is set as DB_ONLY -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1683/files/8cf7bafd9639ce2dbc9d438b2f

[sr-dev] git:master:e87feb9f: modules: readme files regenerated - topos ... [skip ci]

2018-10-24 Thread Kamailio Dev
Module: kamailio Branch: master Commit: e87feb9f11c1dde9710bf3ef3ef5e6626b735233 URL: https://github.com/kamailio/kamailio/commit/e87feb9f11c1dde9710bf3ef3ef5e6626b735233 Author: Kamailio Dev Committer: Kamailio Dev Date: 2018-10-24T15:01:48+02:00 modules: readme files regenerated - topos ...

[sr-dev] git:master:56c40ebe: topos: docs - replaced c&p topoh with topos

2018-10-24 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 56c40ebefcbe0954c5c40470b22d4f26e163a2d0 URL: https://github.com/kamailio/kamailio/commit/56c40ebefcbe0954c5c40470b22d4f26e163a2d0 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-10-24T14:49:10+02:00 topos: docs - replaced

Re: [sr-dev] [kamailio/kamailio] usrloc: call contact expired call back for a domain with db_mode: DB_ONLY (#1683)

2018-10-24 Thread Henning Westerholt
@miconda: It is not strictly a bugfix - but as you said it brings coherence to the module with the other values for db_mode. So I have nothing against the exception to merge it now in the current phase of development. To addea module parameter is a good idea as well. @adil-mafzool: I have one q

Re: [sr-dev] [kamailio/kamailio] Private memory leaking in case of topos(redis) and topoh modules enable together (#1682)

2018-10-24 Thread alexey-khabulyak
thanks a lot -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1682#issuecomment-432537923___ Kamailio (SER) - Development Mailing List sr-

Re: [sr-dev] [kamailio/kamailio] Private memory leaking in case of topos(redis) and topoh modules enable together (#1682)

2018-10-24 Thread Daniel-Constantin Mierla
That's a typo, being couple of mod params with the same purpose in the two modules, I did some copy&paste from topoh (older module) and topos. I will fix the docs, thanks for pointing it out. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or vi