Re: [sr-dev] [kamailio/kamailio] dispatcher on 5.2 not setting the destination properly for the second route (#1728)

2018-11-22 Thread Daniel-Constantin Mierla
The last details clarified the use case and I just pushed a patch trying to fix. The issue was that only first group of destinations was considered to update r-uri/d-uri, but in your case that had no available destination address. Try the master or the 5.2 applying the patch, if works fine, then

Re: [sr-dev] [kamailio/kamailio] 180 Ringing without Contact with TOPOS enabled (#1720)

2018-11-22 Thread Daniel-Constantin Mierla
Closed #1720. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1720#event-1981857122___ Kamailio (SER) - Development Mailing List sr-dev@l

Re: [sr-dev] [kamailio/kamailio] 180 Ringing without Contact with TOPOS enabled (#1720)

2018-11-22 Thread Daniel-Constantin Mierla
The same (similar) result should be when not using topos, because the other side didn't give any contact where to forward the BYE. So in this case you have to route the BYE like you did the INVITE. Eventually store in an htable where you sent the INVITE (using call-id as a key) and forward the

Re: [sr-dev] [kamailio/kamailio] Crash using TLS with many child processes on Alpine with libressl (#1670)

2018-11-22 Thread Henning Westerholt
Thank you Daniel for the clarification -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1670#issuecomment-440950935___ Kamailio (SER) - De

[sr-dev] [kamailio/kamailio] Added 'msg' argument to ksr_route_relay (#1734)

2018-11-22 Thread Joonas Keskitalo
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files

Re: [sr-dev] [kamailio/kamailio] 180 Ringing without Contact with TOPOS enabled (#1720)

2018-11-22 Thread Sergey Basov
@miconda Please check latest commit. It brakes 180 and 183 responses with Contact header ``` /* keep contact without updates for redirect responses sent out */ ** if(msg->first_line.u.reply.statuscode<300 ** || msg->first_line.u.reply.statuscode>=400) {

Re: [sr-dev] [kamailio/kamailio] 180 Ringing without Contact with TOPOS enabled (#1720)

2018-11-22 Thread Sergey Basov
@miconda I think correct way will be: ``` tps_remove_headers(msg, HDR_RECORDROUTE_T); if(msg->first_line.u.reply.statuscode>100 && msg->first_line.u.reply.statuscode<200 && msg->contact==NULL) {

Re: [sr-dev] [kamailio/kamailio] misc/examples/kemi: Added 'msg' argument to ksr_route_relay (#1734)

2018-11-22 Thread Mikko Lehto
Log message fixed as per guidelines, usage looks sane as per other ksr_route_relay() calls in same example. Merging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1734#issuecomment

[sr-dev] [kamailio/kamailio] Crash in topoh module (#1735)

2018-11-22 Thread Alexandru Pirvulescu
### Description We have multiple SIP trunks aggregated in a Kamailio router. One of them misbehaves in a way that I fail to see and it crashes our Kamailio. The conversation that triggers this bug is attached below. ### Troubleshooting Reproduction Debugging Data ``` (gdb) bt ful

[sr-dev] git:master:fe259304: Merge pull request #1734 from Joonake/master

2018-11-22 Thread GitHub
Module: kamailio Branch: master Commit: fe259304d83123842ce1f76aefe1ce8c905a5dae URL: https://github.com/kamailio/kamailio/commit/fe259304d83123842ce1f76aefe1ce8c905a5dae Author: Mikko Lehto Committer: GitHub Date: 2018-11-22T19:54:30+02:00 Merge pull request #1734 from Joonake/master misc/ex

Re: [sr-dev] [kamailio/kamailio] misc/examples/kemi: Added 'msg' argument to ksr_route_relay (#1734)

2018-11-22 Thread Mikko Lehto
Merged #1734 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1734#event-1983021319___ Kamailio (SER) - Development Mailing Lis

Re: [sr-dev] [kamailio/kamailio] dispatcher on 5.2 not setting the destination properly for the second route (#1728)

2018-11-22 Thread David Villasmil
Hello Daniel, A million thanks for looking into this. It looks very promising, my first tests are perfect! There's some more tests coming up with more nodes (I only had 3 up until now, will be adding another one) and will let you know the results. Thanks again! David -- You are receiving th

[sr-dev] git:master:a35503b3: misc/examples/kemi: Added 'msg' argument to ksr_route_relay

2018-11-22 Thread root
Module: kamailio Branch: master Commit: a35503b3837cfc804f30c7493fbd13573c1a55e1 URL: https://github.com/kamailio/kamailio/commit/a35503b3837cfc804f30c7493fbd13573c1a55e1 Author: Joonas Keskitalo Committer: root Date: 2018-11-22T19:17:53+02:00 misc/examples/kemi: Added 'msg' argument to ksr_ro

Re: [sr-dev] [kamailio/kamailio] dispatcher on 5.2 not setting the destination properly for the second route (#1728)

2018-11-22 Thread Daniel-Constantin Mierla
Thanks for testing and reporting back the results! -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1728#issuecomment-441170431___ Kamailio (SER) - Developmen

Re: [sr-dev] [kamailio/kamailio] dispatcher on 5.2 not setting the destination properly for the second route (#1728)

2018-11-22 Thread Daniel-Constantin Mierla
Closed #1728. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1728#event-1983549426___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org ht

[sr-dev] git:master:97da6b1a: topoh: safety checks for couple of mandatory headers

2018-11-22 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 97da6b1a5f656db4a91c8909167706fc8ec3d932 URL: https://github.com/kamailio/kamailio/commit/97da6b1a5f656db4a91c8909167706fc8ec3d932 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-11-23T08:46:54+01:00 topoh: safety checks f

[sr-dev] git:master:93e40d5b: topos: safety checks for couple of mandatory headers

2018-11-22 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 93e40d5b7fb66d33f31c46dfaea5425062505127 URL: https://github.com/kamailio/kamailio/commit/93e40d5b7fb66d33f31c46dfaea5425062505127 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-11-23T08:51:18+01:00 topos: safety checks f