Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Joel Serrano
+1 for option #2 On Wed, Dec 19, 2018 at 04:35 Carsten Bock wrote: > Hi, > > given the fact, that we do a lot of "non-sip" related stuff with Kamailio > (we are using Kamailio as a Diameter HSS, Diameter Charging-Server (OCS), > Diameter Routing-Agent (DRA)), I would also vote for number (2):

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread YAS0 CANER
TmEXIT , kEXIT and corEXIT is failed  From: sr-users on behalf of Olle E. Johansson Sent: Wednesday, December 19, 2018 2:38 PM To: Daniel-Constantin Mierla Cc: Kamailio (SER) - Development Mailing List; Kamailio (SER) - Users Mailing List Subject: Re:

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread YAS0 CANER
Hello, i agree with Mr. Johansson . Merging main modules and cores help to find right function in documentation. Thanks /O “The campaign to remove Kamailio extensions to Kamailio” From: sr-users on behalf of Olle E. Johansson Sent: Wednesday, December 19,

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Sergey Safarov
I prefer second way. Without any duplication. For old configs branches 4.4, 5.0, 5.1 is always available. Sergey ср, 19 дек. 2018 г. в 10:50, Daniel-Constantin Mierla : > Hello, > > it was brought into discussions several times in the past about core > functions not accepting variables in the

[sr-dev] git:master:10be01a4: core: Add PROXY protocol implementation (#1765)

2018-12-19 Thread Henning Westerholt
Module: kamailio Branch: master Commit: 10be01a41430335f27a557a58a8f0e72bbd5d2c7 URL: https://github.com/kamailio/kamailio/commit/10be01a41430335f27a557a58a8f0e72bbd5d2c7 Author: Sebastian Lauwers Committer: Henning Westerholt Date: 2018-12-19T09:05:14+01:00 core: Add PROXY protocol

[sr-dev] git:master:d8f595fe: core: fix compilation warnings

2018-12-19 Thread Victor Seva
Module: kamailio Branch: master Commit: d8f595fe4bb4cec6049e86202b95e40ae849b165 URL: https://github.com/kamailio/kamailio/commit/d8f595fe4bb4cec6049e86202b95e40ae849b165 Author: Victor Seva Committer: Victor Seva Date: 2018-12-20T00:26:20+01:00 core: fix compilation warnings >

[sr-dev] git:master:89e89e02: cnxcc: fix compilation warnings

2018-12-19 Thread Victor Seva
Module: kamailio Branch: master Commit: 89e89e023d923d2dbec694509b9f958bbed6d3ad URL: https://github.com/kamailio/kamailio/commit/89e89e023d923d2dbec694509b9f958bbed6d3ad Author: Victor Seva Committer: Victor Seva Date: 2018-12-20T00:16:25+01:00 cnxcc: fix compilation warnings > warning:

[sr-dev] git:master:7d9d9fe2: ndb_redis: fix compilation warnings

2018-12-19 Thread Victor Seva
Module: kamailio Branch: master Commit: 7d9d9fe21a121a38d4a3861ce252a1a485a35c71 URL: https://github.com/kamailio/kamailio/commit/7d9d9fe21a121a38d4a3861ce252a1a485a35c71 Author: Victor Seva Committer: Victor Seva Date: 2018-12-20T00:06:45+01:00 ndb_redis: fix compilation warnings > warning:

[sr-dev] git:master:da18d99e: topos_redis: fix compilation warnings

2018-12-19 Thread Victor Seva
Module: kamailio Branch: master Commit: da18d99e509c86ac21f04cf36184cadfe16fce83 URL: https://github.com/kamailio/kamailio/commit/da18d99e509c86ac21f04cf36184cadfe16fce83 Author: Victor Seva Committer: Victor Seva Date: 2018-12-20T00:09:39+01:00 topos_redis: fix compilation warnings >

[sr-dev] [kamailio/kamailio] secfilter: some improvements and fixes (#1770)

2018-12-19 Thread Victor Seva
You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1770 -- Commit Summary -- * secfilter: reduce code copy * secfilter: simplify secf_get_contact() * secfilter: fix memmory leak on error * secfilter: simplify RPC code -- File

[sr-dev] git:master:eb374d71: secfilter: free initial struct of shared memory on mod_destroy

2018-12-19 Thread Jose Luis Verdeguer
Module: kamailio Branch: master Commit: eb374d7167e9be15dca0a30a402418fb5993bf69 URL: https://github.com/kamailio/kamailio/commit/eb374d7167e9be15dca0a30a402418fb5993bf69 Author: Victor Seva Committer: Jose Luis Verdeguer Date: 2018-12-19T18:43:28+01:00 secfilter: free initial struct of

[sr-dev] [kamailio/kamailio] secfilter: free initial struct of shared memory on mod_destroy (#1769)

2018-12-19 Thread Victor Seva
seems that ``secf_data`` was never freed You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1769 -- Commit Summary -- * secfilter: free initial struct of shared memory on mod_destroy -- File Changes -- M

[sr-dev] git:master:bfbbc231: secfilter: clang-format

2018-12-19 Thread Victor Seva
Module: kamailio Branch: master Commit: bfbbc2311530a5d9ef0d2cde0aef01f652acbc93 URL: https://github.com/kamailio/kamailio/commit/bfbbc2311530a5d9ef0d2cde0aef01f652acbc93 Author: Victor Seva Committer: Victor Seva Date: 2018-12-19T18:18:54+01:00 secfilter: clang-format --- Modified:

Re: [sr-dev] [kamailio/kamailio] dialog: safety checks for local cseq and contact vars (79946bb)

2018-12-19 Thread Cui Gang
I found your commit in branch master, "dialog: check for cseq value only when getting it for caller/request". And I tested, It works well ! Could you commit that patch to branch 5.2? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

[sr-dev] git:master:fbfca70e: modules: readme files regenerated - websocket ... [skip ci]

2018-12-19 Thread Kamailio Dev
Module: kamailio Branch: master Commit: fbfca70ec60c41f3fa4050c8d022e75f7b1e1bba URL: https://github.com/kamailio/kamailio/commit/fbfca70ec60c41f3fa4050c8d022e75f7b1e1bba Author: Kamailio Dev Committer: Kamailio Dev Date: 2018-12-19T14:16:41+01:00 modules: readme files regenerated - websocket

[sr-dev] git:master:3a20bb1a: websocket: docs for timer_interval and rm_delay_interval params

2018-12-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 3a20bb1ad27b8a85ec932975e14bcec12237437b URL: https://github.com/kamailio/kamailio/commit/3a20bb1ad27b8a85ec932975e14bcec12237437b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-12-19T14:11:51+01:00 websocket: docs for

[sr-dev] git:master:71517152: websocket: fetch ws connections based on keepalive process index

2018-12-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 71517152e7de26d6c47fd037c25dc854aa37734f URL: https://github.com/kamailio/kamailio/commit/71517152e7de26d6c47fd037c25dc854aa37734f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-12-19T13:15:36+01:00 websocket: fetch ws

[sr-dev] git:master:af09e224: websocket: destroy ws connections in dedicated timer process

2018-12-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: af09e224dba0c57c23fd58a7f83a24d2ffbaa07c URL: https://github.com/kamailio/kamailio/commit/af09e224dba0c57c23fd58a7f83a24d2ffbaa07c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-12-19T14:06:56+01:00 websocket: destroy ws

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Olle E. Johansson
> On 19 Dec 2018, at 13:45, Carsten Bock wrote: > > Hi, > > I would vote for: > "Kamailio - the swiss-army knife for communications"... ;-) > Nils Ohlmeier -the author of SIPsak - will propably sue us. Not good. /O ;-) > Thanks, > Carsten > -- > > Carsten Bock > CEO (Geschäftsführer) > >

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Carsten Bock
Hi, I would vote for: "Kamailio - the swiss-army knife for communications"... ;-) Thanks, Carsten -- Carsten Bock CEO (Geschäftsführer) ng-voice GmbH Millerntorplatz 1 20359 Hamburg / Germany http://www.ng-voice.com mailto:cars...@ng-voice.com Office +49 40 5247593-40 Fax +49 40 5247593-99

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Olle E. Johansson
“Kamailio - the leading non-sip and sip server" Naahhh. Doesn’t work. /Kamailio Marketing Dept. ;-) > On 19 Dec 2018, at 13:31, Carsten Bock wrote: > > Hi, > > given the fact, that we do a lot of "non-sip" related stuff with Kamailio (we > are using Kamailio as a Diameter HSS, Diameter

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Carsten Bock
Hi, given the fact, that we do a lot of "non-sip" related stuff with Kamailio (we are using Kamailio as a Diameter HSS, Diameter Charging-Server (OCS), Diameter Routing-Agent (DRA)), I would also vote for number (2): > 2) remove the function export from the core and export one with the same

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Olle E. Johansson
> On 19 Dec 2018, at 12:26, Daniel-Constantin Mierla wrote: > > > On 19.12.18 09:47, Olle E. Johansson wrote: >> >>> On 19 Dec 2018, at 09:41, Daniel-Constantin Mierla >>> wrote: >>> >>> corex module was added to hold the functions that otherwise would be >>> more or less "in the core",

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Daniel-Constantin Mierla
On 19.12.18 09:47, Olle E. Johansson wrote: > >> On 19 Dec 2018, at 09:41, Daniel-Constantin Mierla wrote: >> >> corex module was added to hold the functions that otherwise would be >> more or less "in the core", like those that were updated to support >> variables in the parameters, so this is

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Fred Posner
On 12/19/18 3:18 AM, Victor Seva wrote: On Wed, 19 Dec 2018 at 08:49, Daniel-Constantin Mierla mailto:mico...@gmail.com>> wrote: 2) remove the function export from the core and export one with the same name from the corex module This would be my preference as well. --fred

Re: [sr-dev] [kamailio/kamailio] dialog: safety checks for local cseq and contact vars (79946bb)

2018-12-19 Thread Daniel-Constantin Mierla
Looks like a regression introduced with a patch that tried to avoid a crash -- I pushed another commit to skip the test on cseq when not taken from sip request. It is already in branch 5.2, can you test and see if all ok now? -- You are receiving this because you are subscribed to this thread.

[sr-dev] git:master:740bc8ce: dialog: check for cseq value only when getting it for caller/request

2018-12-19 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 740bc8ce88da612ac30a73db0145908355cab192 URL: https://github.com/kamailio/kamailio/commit/740bc8ce88da612ac30a73db0145908355cab192 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-12-19T11:56:41+01:00 dialog: check for

Re: [sr-dev] [kamailio/kamailio] dialog: safety checks for local cseq and contact vars (79946bb)

2018-12-19 Thread Cui Gang
Hi, My kamailio configuration file works well on the first release 5.2.0(535e13b). When I update kamailio server to the 5.2.0 branch last version, include this commit, dialog always ERROR like: ERROR: {...} dialog [dlg_handlers.c:212]: populate_leg_info(): empty CSeq number Why? And how can I

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Olle E. Johansson
> On 19 Dec 2018, at 09:41, Daniel-Constantin Mierla wrote: > > corex module was added to hold the functions that otherwise would be > more or less "in the core", like those that were updated to support > variables in the parameters, so this is the one to take the place of > core in regard to

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Daniel-Constantin Mierla
corex module was added to hold the functions that otherwise would be more or less "in the core", like those that were updated to support variables in the parameters, so this is the one to take the place of core in regard to exporting functions. tmx was added because tm module became very big, but

Re: [sr-dev] [kamailio/kamailio] core: Add PROXY protocol implementation (#1765)

2018-12-19 Thread Sebastian Lauwers
@henningw As requested: https://www.kamailio.org/wiki/cookbooks/devel/core?do=diff%5B0%5D=1543419017%5B1%5D=1545207854=sidebyside With regards to the border condition that you mention, I don't believe there should be such a case, unless weird things are done in the `goto error;` branch. I

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Olle E. Johansson
Going back one step, are there any reasons to keep tmx, kex and corex modules at all? At this point in the project I think many of the functions should be merged into the main modules and core. If I remember correctly, they exist because of a multi-brand history that is not really the case

Re: [sr-dev] RFC: updates to some core functions

2018-12-19 Thread Federico Cabiddu
Hi, I'd go for the second option, cleaner. Once we have a list of core functions to be migrated we could split the work among the developers. And of course write a nice migration doc 5.2 => 5.3. Cheers, Federico On Wed, Dec 19, 2018 at 8:50 AM Daniel-Constantin Mierla wrote: > Hello, > > it

Re: [sr-dev] [SR-Users] RFC: updates to some core functions

2018-12-19 Thread Henning Westerholt
Am Mittwoch, 19. Dezember 2018, 09:03:26 CET schrieb Sergey Safarov: > I prefer second way. Without any duplication. > For old configs branches 4.4, 5.0, 5.1 is always available. Hello, I would prefer also the second way, for the same reason: less duplicated functions. Best regards, Henning

Re: [sr-dev] [kamailio/kamailio] Proxy Protocol support (#1757)

2018-12-19 Thread Henning Westerholt
Closed #1757. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1757#event-2034980783___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] core: Add PROXY protocol implementation (#1765)

2018-12-19 Thread Henning Westerholt
Merged #1765 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1765#event-2034979926___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] core: Add PROXY protocol implementation (#1765)

2018-12-19 Thread Henning Westerholt
Thank you for the comments and extensions. About this question: > related to error cases, what would happen if you e.g. set in the IPv6 case > 0x21 the dst_ip->af = > AF_INET6, but later one run unto an error in the parsing. Then you would > return an error to the > callee, and would go to