Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README
@alexyosifov I already removed the ones (mostly copy and pasted code) that I
found in commit ad5a346c and ac2736d6. If you need this for debugging - feel
free to add a proper debugging function that output some information at LM_DBG
log level. There is almost no performance impact in doing so,
Thank you!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1832#issuecomment-511533237___
Kamailio (SER) - Development Mailing List
Merged #1832 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1832#event-2483958572___
Kamailio (SER) - Development Mailing
I agree, no one should complain if commented out code gets removed at some
point and you can look up old code in git.
@alexyosifov could you please have a look at the commented out code and remove
the unnecessary functions or add TODOs, as @henningw suggested?
--
You are receiving this
henningw commented on this pull request.
> @@ -269,6 +271,25 @@ int populate_leg_info( struct dlg_cell *dlg, struct
> sip_msg *msg,
if (rr_set.s) pkg_free(rr_set.s);
Thanks for the clarification
--
You are receiving this because you are subscribed to this thread.
Reply to this
henningw commented on this pull request.
> @@ -528,7 +533,7 @@ int dlg_set_leg_info(struct dlg_cell *dlg, str* tag, str
> *rr, str *contact,
if(dlg->tag[leg].s)
shm_free(dlg->tag[leg].s);
- dlg->tag[leg].s = (char*)shm_malloc( tag->len + rr->len );
Thank you,
I agree that it is important to have a working IMS modules and proper
integration.
About the commented out code - feel free to add a TODO or a similar comment
like this to it, then people know that it is still work in progress. Otherwise
it might get removed during integration or later, as
Module: kamailio
Branch: master
Commit: 497fd1a38ab655ebeb33a0db3cfd5708ca18d63a
URL:
https://github.com/kamailio/kamailio/commit/497fd1a38ab655ebeb33a0db3cfd5708ca18d63a
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2019-07-15T21:03:39+02:00
ims_usrloc_pcscf: fix code
Module: kamailio
Branch: master
Commit: 655aff041853a1426ee1adbfff16bd2ad6eec2db
URL:
https://github.com/kamailio/kamailio/commit/655aff041853a1426ee1adbfff16bd2ad6eec2db
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2019-07-15T20:52:41+02:00
ims_ipsec_pcscf: fix code
Module: kamailio
Branch: master
Commit: ac2736d62fc97c6e93f98dea46e61cb22a356e47
URL:
https://github.com/kamailio/kamailio/commit/ac2736d62fc97c6e93f98dea46e61cb22a356e47
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2019-07-15T20:52:03+02:00
ims_ipsec_pcscf: remove commented
Module: kamailio
Branch: master
Commit: ad5a346c13c20603f732b6a0a0988746850cfbaf
URL:
https://github.com/kamailio/kamailio/commit/ad5a346c13c20603f732b6a0a0988746850cfbaf
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2019-07-15T20:37:46+02:00
ims_registrar_pcscf: remove
Module: kamailio
Branch: master
Commit: 26c620fc4b791c9661c47508a34436f50e8c6641
URL:
https://github.com/kamailio/kamailio/commit/26c620fc4b791c9661c47508a34436f50e8c6641
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2019-07-15T20:35:45+02:00
ims_registrar_pcscf: fix code
@henningw I've made a review on my own, before asking a second opinion. The
patch remained open for more than 10 days, which I think is too much. I wasn't
aware that you are still reviewing the patch.
The whole mode is in "work in progress" state, so I am willing to accept
commented out code
@tdimitrov I started the review yesterday as announced here, but got caught by
some other urgent topic. This is a quite large patch in the end. There was no
need to rush this into the repository.
There exists many white-space issues where the code uses a complete different
indention as the
Merged #2001 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2001#event-2483541165___
Kamailio (SER) - Development Mailing
Module: kamailio
Branch: master
Commit: 57961c9f485a9324e140f90acbfc82857efbf0f5
URL:
https://github.com/kamailio/kamailio/commit/57961c9f485a9324e140f90acbfc82857efbf0f5
Author: Tsvetomir Dimitrov
Committer: GitHub
Date: 2019-07-15T19:41:34+03:00
Merge pull request #2001 from
Module: kamailio
Branch: master
Commit: 7dd380afaa5bee73a5bed1d928be38b8bb76fd99
URL:
https://github.com/kamailio/kamailio/commit/7dd380afaa5bee73a5bed1d928be38b8bb76fd99
Author: Aleksandar Yosifov
Committer: Aleksandar Yosifov
Date: 2019-07-04T10:41:48+03:00
kamctl: added new fields in
Module: kamailio
Branch: master
Commit: 59c4e08fa57d6fe7b65d9265d39a03d4733b3dd2
URL:
https://github.com/kamailio/kamailio/commit/59c4e08fa57d6fe7b65d9265d39a03d4733b3dd2
Author: Aleksandar Yosifov
Committer: Aleksandar Yosifov
Date: 2019-07-04T10:39:07+03:00
ims_usrloc_pcscf: added a new
Module: kamailio
Branch: master
Commit: 7e46cdac98f70c9fb5f599961c03129089473269
URL:
https://github.com/kamailio/kamailio/commit/7e46cdac98f70c9fb5f599961c03129089473269
Author: Aleksandar Yosifov
Committer: Aleksandar Yosifov
Date: 2019-07-04T10:38:39+03:00
ims_registrar_pcscf: update
Module: kamailio
Branch: master
Commit: 3203c53ea2e00bdbec2746de3d9eb19f6f7f2a71
URL:
https://github.com/kamailio/kamailio/commit/3203c53ea2e00bdbec2746de3d9eb19f6f7f2a71
Author: Aleksandar Yosifov
Committer: Aleksandar Yosifov
Date: 2019-07-04T10:37:06+03:00
ims_ipsec_pcscf: support for
I'm merging this as it is waiting for too long time. If anyone has concerns
about the code, we'll fix them later.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Module: kamailio
Branch: master
Commit: 9dab8303a96614fd74efff6add359a23713642a5
URL:
https://github.com/kamailio/kamailio/commit/9dab8303a96614fd74efff6add359a23713642a5
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2019-07-15T17:24:14+02:00
siputils: log method
Module: kamailio
Branch: master
Commit: 183ff04e00e592cc2c7db54732c6a3bb8fb75bb8
URL:
https://github.com/kamailio/kamailio/commit/183ff04e00e592cc2c7db54732c6a3bb8fb75bb8
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2019-07-15T16:41:22+02:00
siputils: exported
Hello,
thanks for contributing! To merge the code you should combine the patches in a
single commit and then format the commit message as per contributing guidelines.
To merge the patches you can get the diff of the pull request:
*
gaaf commented on this pull request.
> @@ -528,7 +533,7 @@ int dlg_set_leg_info(struct dlg_cell *dlg, str* tag, str
> *rr, str *contact,
if(dlg->tag[leg].s)
shm_free(dlg->tag[leg].s);
- dlg->tag[leg].s = (char*)shm_malloc( tag->len + rr->len );
It is not
gaaf commented on this pull request.
> + /* skip_recs contains the number of RR's for the callee */
+ skip_recs -= own_rr;
+ /* Add local RR's to caller's routeset */
+ if( print_rr_body(msg->record_route, _set, DLG_CALLER_LEG,
+
gaaf commented on this pull request.
> @@ -269,6 +271,25 @@ int populate_leg_info( struct dlg_cell *dlg, struct
> sip_msg *msg,
if (rr_set.s) pkg_free(rr_set.s);
print_rr_body() allocates the memory for rrset.s, it is up to the caller to
free it. As it may be allocated twice, it
Module: kamailio
Branch: 5.2
Commit: 7c8ee7a32a712cddc4d6080f9d9f48a588113eb0
URL:
https://github.com/kamailio/kamailio/commit/7c8ee7a32a712cddc4d6080f9d9f48a588113eb0
Author: Victor Seva
Committer: Victor Seva
Date: 2019-07-15T12:38:45+02:00
rtpengine: fix error output on send_rtpp_command()
Module: kamailio
Branch: 5.1
Commit: 797705e42896c9bcef6b4b45d631d643bf07efe5
URL:
https://github.com/kamailio/kamailio/commit/797705e42896c9bcef6b4b45d631d643bf07efe5
Author: Victor Seva
Committer: Victor Seva
Date: 2019-07-15T12:39:17+02:00
rtpengine: fix error output on send_rtpp_command()
Merged #2009 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2009#event-2482458929___
Kamailio (SER) - Development Mailing
Module: kamailio
Branch: master
Commit: 262068940ba8dbd1b9fd93847f83f40c038d988c
URL:
https://github.com/kamailio/kamailio/commit/262068940ba8dbd1b9fd93847f83f40c038d988c
Author: Victor Seva
Committer: Victor Seva
Date: 2019-07-15T12:37:54+02:00
rtpengine: fix error output on
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README
This is a ringless implementation of millisecond precision timer and
millisecond async_sleep function.
I've added the functionality to the current async mod but this can me moved to
a dedicated module.
For now only the async_ms_sleep is implemented but async_ms_route is just a few
lines.
here are the logs
getting timeout with same sip configuration with kamailio uac register module
, support for it enabled
Jul 15 13:28:50 vdserver.telcob.live /usr/sbin/kamailio[8673]: INFO: rtpengine
[rtpengine.c:2421]: rtpp_test():
About the first quesiton - sorry, but we can't help you with Asterisk issues
here, please contact the asterisk list. About the second question, what do you
mean with "same configuration in kamailio with PJSIP"? I don't understand this.
--
You are receiving this because you are subscribed to
@urtho - Thank you, looks like an interesting extension. Can you please create
a pull request against kamailio master branch with your changes? You already
mentioned the missing XML docs - after you created the pull request lets
continue the discussion there.
--
You are receiving this because
Closed #2006.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2006#event-2481949955___
Kamailio (SER) - Development Mailing List
Hi
Greeting !!!
I am kaushik saha from Discreet Solutions Pvt LTD. India
We want to install you're VOIP OS in a home router which should be cost
effective .
Home sip server is use for following use :
1. Audio and video extension calling
2. Remote extension Audio and video
Hello all
I am facing a different kind of problem
my SIP provider getting registered with sip.conf
but when i am doing same configuration in kamailio with PJSIP
sip registry
40 matches
Mail list logo
