Re: [sr-dev] [kamailio/kamailio] lost: adds HELD (RFC6155) and LOST (RFC5222) queries for location-bas… (#2031)

2019-08-12 Thread Wolfgang Kampichler
> Thank you Wolfgang, great contribution. > > I have added a few comments, mainly to memory management, and some > spelling/formatting fixes. I found nothing serious in my review. Would be > great if you could have a look to them, after this the module should be > committed to git master.

Re: [sr-dev] [kamailio/kamailio] lost: adds HELD (RFC6155) and LOST (RFC5222) queries for location-bas… (#2031)

2019-08-12 Thread Henning Westerholt
henningw commented on this pull request. Thank you Wolfgang, great contribution. I have added a few comments, mainly to memory management, and some spelling/formatting fixes. I found nothing serious in my review. Would be great if you could have a look to them, after this the module should be

Re: [sr-dev] [kamailio/kamailio] topoh: PKG memory leak (#2027)

2019-08-12 Thread Henning Westerholt
Ah, this might be the cause that I did not managed to reproduce it with only one module.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:5.2:db0ae1e3: modules: readme files regenerated - modules ... [skip ci]

2019-08-12 Thread Kamailio Dev
Module: kamailio Branch: 5.2 Commit: db0ae1e3dde3331810ba8b154d7e111bf3322583 URL: https://github.com/kamailio/kamailio/commit/db0ae1e3dde3331810ba8b154d7e111bf3322583 Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-08-12T21:01:32+02:00 modules: readme files regenerated - modules ...

[sr-dev] git:master:b3d9da5c: modules: readme files regenerated - topos ... [skip ci]

2019-08-12 Thread Kamailio Dev
Module: kamailio Branch: master Commit: b3d9da5c5e80e42e550c4cf56c29aee1ab068c92 URL: https://github.com/kamailio/kamailio/commit/b3d9da5c5e80e42e550c4cf56c29aee1ab068c92 Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-08-12T21:01:45+02:00 modules: readme files regenerated - topos ...

[sr-dev] git:5.2:6e5cb772: topos: docs for dialog_expire param limitation for in-dialog requests (GH #2024)

2019-08-12 Thread Henning Westerholt
Module: kamailio Branch: 5.2 Commit: 6e5cb772817a8275c89869c868ce20a2ddb47df9 URL: https://github.com/kamailio/kamailio/commit/6e5cb772817a8275c89869c868ce20a2ddb47df9 Author: Henning Westerholt Committer: Henning Westerholt Date: 2019-08-12T20:55:26+02:00 topos: docs for dialog_expire param

[sr-dev] git:master:3ccf5ee6: topos: docs for dialog_expire param limitation for in-dialog requests (GH #2024)

2019-08-12 Thread Henning Westerholt
Module: kamailio Branch: master Commit: 3ccf5ee691440e806d441f0e58562ddc4137a488 URL: https://github.com/kamailio/kamailio/commit/3ccf5ee691440e806d441f0e58562ddc4137a488 Author: Henning Westerholt Committer: Henning Westerholt Date: 2019-08-12T20:54:48+02:00 topos: docs for dialog_expire

Re: [sr-dev] [kamailio/kamailio] topos module does not update topos_d timestamp at re-INVITE (#2024)

2019-08-12 Thread Henning Westerholt
Closed #2024. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2024#event-2551178825___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] topos module does not update topos_d timestamp at re-INVITE (#2024)

2019-08-12 Thread Henning Westerholt
Thanks Daniel. So basically something like the dialog timeout_noreset [parameter](https://kamailio.org/docs/modules/5.2.x/modules/dialog.html#dialog.p.timeout_noreset) Ok, I have added some documentation for now: ``` Keep in mind that the module does not update the dialog timestamp after the

[sr-dev] git:5.2:c1eaf335: dispatcher: skip inactive destinations for pointing next to be used record

2019-08-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.2 Commit: c1eaf3353f43d34f164f28a871399ca785c40b4f URL: https://github.com/kamailio/kamailio/commit/c1eaf3353f43d34f164f28a871399ca785c40b4f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-08-12T20:18:12+02:00 dispatcher: skip

[sr-dev] git:master:18eeda01: dispatcher: skip inactive destinations for pointing next to be used record

2019-08-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 18eeda012a711584239b03d5cfef8b7720f0ef31 URL: https://github.com/kamailio/kamailio/commit/18eeda012a711584239b03d5cfef8b7720f0ef31 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-08-12T20:15:17+02:00 dispatcher: skip

Re: [sr-dev] [SR-Users] Dispatcher round-robin problems in 5.2

2019-08-12 Thread Henning Westerholt
Hi Alex, there have been many  changes to the modules between 5.1 and 5.2. I just looked a bit to the code of dispatch.c and also the commits. I noticed something in commit 3933a64c464acfb285e - there was a block related to round-robin before which got removed in this refactoring (if I

Re: [sr-dev] [kamailio/kamailio] lost: adds HELD (RFC6155) and LOST (RFC5222) queries for location-bas… (#2031)

2019-08-12 Thread Daniel-Constantin Mierla
Thanks! At a very quick look, code seems ok. I will let it here for a bit, just in case someone else wants to do a review, then it will be merged. I will grant you commit access so your can manage the module yourself directly, once it is merged. -- You are receiving this because you are

[sr-dev] [kamailio/kamailio] lost: adds HELD (RFC6155) and LOST (RFC5222) queries for location-bas… (#2031)

2019-08-12 Thread Wolfgang Kampichler
…ed routing - lost_held_query() takes specific id (pvar, P-A-I, or From), assembles a locationRequest (XML), and sends it to an http_client connection, responses are parsed (pidf-lo and location reference are returned) - lost_query() takes pidf-lo (pvar, msg body, or de-referenced), a service

Re: [sr-dev] [kamailio/kamailio] topos module does not update topos_d timestamp at re-INVITE (#2024)

2019-08-12 Thread Daniel-Constantin Mierla
That is supposed to be the lifetime of the dialog, not updated on re-INVITE or other requests within dialog. You can add a new param to control this behaviour if you want to change this value on requests within dialog. -- You are receiving this because you are subscribed to this thread. Reply

Re: [sr-dev] [kamailio/kamailio] core: Fix the cfg framework variable input type default (#2022)

2019-08-12 Thread Daniel-Constantin Mierla
Merged #2022 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2022#event-2549617585___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:0a161d19: Merge pull request #2022 from mancasg/master

2019-08-12 Thread GitHub
Module: kamailio Branch: master Commit: 0a161d19707917f690b5823b64d120354c8b URL: https://github.com/kamailio/kamailio/commit/0a161d19707917f690b5823b64d120354c8b Author: Daniel-Constantin Mierla Committer: GitHub Date: 2019-08-12T11:37:11+02:00 Merge pull request #2022 from

Re: [sr-dev] [kamailio/kamailio] core: Fix the cfg framework variable input type default (#2022)

2019-08-12 Thread Daniel-Constantin Mierla
Thanks! I will merge it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2022#issuecomment-520358137___ Kamailio (SER) - Development

Re: [sr-dev] [kamailio/kamailio] topoh: PKG memory leak (#2027)

2019-08-12 Thread Daniel-Constantin Mierla
This may have been a result of having two modules using the same callback to update the content of the outbound buffer, in your case the topoh (hiding header attributes) and dialog (updating the cseq). I pushed a bunch of patches to core and modules using this callback. They are in master

[sr-dev] git:master:c79dfbea: corex: free old outbound buffer inside SREV_NET_DATA_OUT callback

2019-08-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: c79dfbeab0bfefaa4dd5cefc41cba3ba157da0ce URL: https://github.com/kamailio/kamailio/commit/c79dfbeab0bfefaa4dd5cefc41cba3ba157da0ce Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-08-12T11:18:39+02:00 corex: free old

[sr-dev] git:master:d9a1cbc8: gzcompress: free old outbound buffer inside SREV_NET_DATA_OUT callback

2019-08-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: d9a1cbc8f66f9fd0991048e5e1ba1579916a092e URL: https://github.com/kamailio/kamailio/commit/d9a1cbc8f66f9fd0991048e5e1ba1579916a092e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-08-12T11:18:21+02:00 gzcompress: free old

[sr-dev] git:master:ad8d9628: dialog: free old outbound buffer inside SREV_NET_DATA_OUT callback

2019-08-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: ad8d9628da27a3ab68b005ef52842784af6bda3a URL: https://github.com/kamailio/kamailio/commit/ad8d9628da27a3ab68b005ef52842784af6bda3a Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-08-12T11:18:08+02:00 dialog: free old

[sr-dev] git:master:37a17658: topoh: free old outbound buffer inside th_msg_sent()

2019-08-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 37a1765853294016f43bd633667cd6232d3e URL: https://github.com/kamailio/kamailio/commit/37a1765853294016f43bd633667cd6232d3e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-08-12T11:16:23+02:00 topoh: free old

[sr-dev] git:master:21816a11: topos: free old outbound buffer inside SREV_NET_DATA_OUT callback

2019-08-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 21816a11a56628a9eee17765645fcf03d57929bd URL: https://github.com/kamailio/kamailio/commit/21816a11a56628a9eee17765645fcf03d57929bd Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-08-12T11:17:33+02:00 topos: free old

[sr-dev] git:master:98249e2c: core: forward - clone outbound buffer for SREV_NET_DATA_OUT event

2019-08-12 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 98249e2cc97e818cf7ad492132ecfea2ce13a78b URL: https://github.com/kamailio/kamailio/commit/98249e2cc97e818cf7ad492132ecfea2ce13a78b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-08-12T11:14:38+02:00 core: forward - clone

[sr-dev] git:5.2:7069cbaf: modules: readme files regenerated - modules ... [skip ci]

2019-08-12 Thread Kamailio Dev
Module: kamailio Branch: 5.2 Commit: 7069cbaf28beb35036eeb2ab9bde19844144eb00 URL: https://github.com/kamailio/kamailio/commit/7069cbaf28beb35036eeb2ab9bde19844144eb00 Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-08-12T10:32:22+02:00 modules: readme files regenerated - modules ...

[sr-dev] git: new commits in branch 5.2

2019-08-12 Thread Daniel-Constantin Mierla
- URL: https://github.com/kamailio/kamailio/commit/2f07bb77623c556b440d040203ade01726a59fde Author: Daniel-Constantin Mierla Date: 2019-08-12T09:41:04+02:00 usrloc: clone xavp list in contact struct in memory mode (cherry picked from commit 76f0fa8a0330de3885f5f3830eb90061c59045d4) - URL:

Re: [sr-dev] Planning the release of Kamailio v5.2.4

2019-08-12 Thread Daniel-Constantin Mierla
Hello, short note to say that the release of v5.2.4 is going to be on Wednesday, August 14, 2019 -- some backports still need to be sorted out till then. Cheers, Daniel On 01.08.19 12:50, Daniel-Constantin Mierla wrote: > Hello, > > I am considering to do soon a new release out of branch 5.2, >