Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Daniel-Constantin Mierla
@joelsdc: regarding the description of the issue - Kamailio doesn't return values for auth-header related variable before authentication is done, they are not set before auth_check()/proxy_authenticate()/... That's because a SIP request can have many Proxy-/Authorize headers with different

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Joel Serrano
Sounds good! I hope it can make it to 5.3 :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2056#issuecomment-528544772___ Kamailio

[sr-dev] git:master:748f981c: Revert "pv: fix $Au pseudo-variable, it contains incorrectly domain or realm (GH #2056)"

2019-09-05 Thread Henning Westerholt
Module: kamailio Branch: master Commit: 748f981c708ebeb8b0f4325060696fd58d152f54 URL: https://github.com/kamailio/kamailio/commit/748f981c708ebeb8b0f4325060696fd58d152f54 Author: Henning Westerholt Committer: Henning Westerholt Date: 2019-09-05T21:31:16+02:00 Revert "pv: fix $Au

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Henning Westerholt
It is rather strange, it was introduced in kamailio 1.4.0 and the wrong documentation were added to the old wiki.. I will revert the patch. @joelsdc - I will introduce a new PV "$AU" with the documented behavior. @miconda - ok to add it now or after un-freezing git master again? -- You are

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Daniel-Constantin Mierla
Looking at the patch, it is rather clear that the developer wanted to have @ realm, because there is explicit concatenation. So I think the correct way would be to fix documentation based on code, not the code based on wiki documentation, specially given the age of the code in this case.

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Henning Westerholt
@lazedo - good point, in the end nobody complained about it in a long time. So my suggestion would be to to keep the old functionality in stable branches and document the change in 5.3 migration document. I googled for this PV, did not found something on the net so far. -- You are receiving

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Daniel-Constantin Mierla
I am not using that variable, so I don't have anything explicitly again, but the code being that old might have been how it was intended to work. If I am not wrong, @juha-h added some of the $aX or $AX variables related to auth header/acc, so maybe he can comment if he is using or not. -- You

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread lazedo
@henningw please hold on the `backport` as this is a changing on existing behaviour. users are currently getting the `realm` part and this change may break their scripts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Henning Westerholt
Great, let me know the results, I will then back-port the fix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Joel Serrano
Great news! I'll locally build new packages from master and test. I'll report back my results, thank you Henning! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Henning Westerholt
Thanks Joel for the report. I fixed it in git master. This is really strange that nobody reported it before, we have indeed a lot of pseudo-variables.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[sr-dev] git:master:aa8f0820: pv: fix $Au pseudo-variable, it contains incorrectly domain or realm (GH #2056)

2019-09-05 Thread Henning Westerholt
Module: kamailio Branch: master Commit: aa8f0820318762a393c41623cba3a5795225fb0a URL: https://github.com/kamailio/kamailio/commit/aa8f0820318762a393c41623cba3a5795225fb0a Author: Henning Westerholt Committer: Henning Westerholt Date: 2019-09-05T19:24:01+02:00 pv: fix $Au pseudo-variable, it

[sr-dev] [kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)

2019-09-05 Thread Joel Serrano
### Description Testing on latest master deb nightly build (`5.3.0~dev7+0~20190904005559.1479+buster`) I've noticed that `$Au` is not being set correctly, at least according to my tests. >From the documentation

[sr-dev] git:master:20c9e35e: call_obj: fix Doxygen comments.

2019-09-05 Thread Vicente Hernando
Module: kamailio Branch: master Commit: 20c9e35e811817377dba0290180ff23ee9749827 URL: https://github.com/kamailio/kamailio/commit/20c9e35e811817377dba0290180ff23ee9749827 Author: Vicente Hernando Committer: Vicente Hernando Date: 2019-09-05T15:32:18+02:00 call_obj: fix Doxygen comments. ---

[sr-dev] git:master:bda770e5: call_obj: software license.

2019-09-05 Thread Vicente Hernando
Module: kamailio Branch: master Commit: bda770e57200aba4118803a6d332f2440fb0a540 URL: https://github.com/kamailio/kamailio/commit/bda770e57200aba4118803a6d332f2440fb0a540 Author: Vicente Hernando Committer: Vicente Hernando Date: 2019-09-05T15:32:04+02:00 call_obj: software license. ---

Re: [sr-dev] [kamailio/kamailio] TLS module compiled with outdated OpenSSL version for Ubuntu bionic (#2018)

2019-09-05 Thread Victor Seva
> @welljsjs What is the version you have installed? Sorry I meant what openssl version do you have in that system -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] TLS module compiled with outdated OpenSSL version for Ubuntu bionic (#2018)

2019-09-05 Thread welljsjs
``` version: kamailio 5.3.0-dev7 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER,

[sr-dev] git:master:7f11960a: pkg/kamailio/deb: version set 5.3.0~pre0

2019-09-05 Thread Victor Seva
Module: kamailio Branch: master Commit: 7f11960acfec8b182eadee1948f1cbd0e553faa1 URL: https://github.com/kamailio/kamailio/commit/7f11960acfec8b182eadee1948f1cbd0e553faa1 Author: Victor Seva Committer: Victor Seva Date: 2019-09-05T11:53:28+02:00 pkg/kamailio/deb: version set 5.3.0~pre0 ---

Re: [sr-dev] [SR-Users] Development for v5.3.x is frozen

2019-09-05 Thread Daniel-Constantin Mierla
Thanks, good spot of the wrong version! Daniel On 05.09.19 08:08, Henning Westerholt wrote: > Hello, > > just a quick note, I did a spelling fix for the upgrade guidelines URL: > >   * https://www.kamailio.org/wiki/install/upgrade/5.2.x-to-5.3.0 > > Cheers, > > Henning > > Am 05.09.19 um 07:28

Re: [sr-dev] [kamailio/kamailio] mod pua (dialoginfo) etag race conditions (#2048)

2019-09-05 Thread Henning Westerholt
@laszlovl - thank you for the detailed issue description. Are you planning to work on this further, e.g. by creating pull requests? It makes probably sense to prioritize the different fixes according to implementation effort. It would be also good to cross-check the implementation with the

Re: [sr-dev] [kamailio/kamailio] Phonenum module not working when invoked from other than cfg file (#2052)

2019-09-05 Thread Henning Westerholt
close this one - according to report it works not. The fix was also merged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] Phonenum module not working when invoked from other than cfg file (#2052)

2019-09-05 Thread Henning Westerholt
Closed #2052. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2052#event-2609619944___ Kamailio (SER) - Development Mailing List

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio: added rpm version and release configuration (#2050)

2019-09-05 Thread sergey-safarov
@sergey-safarov pushed 1 commit. 7d5f40ce72a92beab4fe9a9045f250923d8f4a6c pkg/kamailio: added rpm spec version and release configuration [skip ci] -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio: added rpm version and release configuration (#2050)

2019-09-05 Thread sergey-safarov
@sergey-safarov pushed 1 commit. 299d987614f9b2ca7f13fc138323aaf80dc1bb9f pkg/kamailio: added rpm spec version and release configuration [skip ci] -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[sr-dev] git:master:ac0a0d6f: pkg/kamailio/deb: version set 5.3.0~dev8 [skip ci]

2019-09-05 Thread Victor Seva
Module: kamailio Branch: master Commit: ac0a0d6feebe738830efaa7bdcfae8ca7f41070d URL: https://github.com/kamailio/kamailio/commit/ac0a0d6feebe738830efaa7bdcfae8ca7f41070d Author: Victor Seva Committer: Victor Seva Date: 2019-09-05T08:46:10+02:00 pkg/kamailio/deb: version set 5.3.0~dev8 [skip

Re: [sr-dev] [SR-Users] Development for v5.3.x is frozen

2019-09-05 Thread Henning Westerholt
Hello, just a quick note, I did a spelling fix for the upgrade guidelines URL:   * https://www.kamailio.org/wiki/install/upgrade/5.2.x-to-5.3.0 Cheers, Henning Am 05.09.19 um 07:28 schrieb Daniel-Constantin Mierla: > Hello, > > the formal notification that the development for the next major