Re: [sr-dev] git:master:ce19d921: siptrace: turn warn into info message about loading dlg api

2019-09-08 Thread Daniel-Constantin Mierla
On 09.09.19 08:46, Juha Heinanen wrote: > Daniel-Constantin Mierla writes: > >> siptrace: turn warn into info message about loading dlg api > Info is better than warning, but I would prefer no message at all. > These kind of things are in README file and don't need to appear in > syslog. > > The c

[sr-dev] git:master:ce19d921: siptrace: turn warn into info message about loading dlg api

2019-09-08 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > siptrace: turn warn into info message about loading dlg api Info is better than warning, but I would prefer no message at all. These kind of things are in README file and don't need to appear in syslog. The code should check if dialog module is available when t

Re: [sr-dev] siptrace warning

2019-09-08 Thread Daniel-Constantin Mierla
Hello, I made that warning an info message (commit ce19d9212feb0ff4b017b5eaa71e4637a71aa4b9), but I am considering to add a param to be able to control if dialog tracking should be done. I didn't have time to dig much into it, but I do not want tracking of dialog automatically if dialog module is

[sr-dev] git:master:ce19d921: siptrace: turn warn into info message about loading dlg api

2019-09-08 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: ce19d9212feb0ff4b017b5eaa71e4637a71aa4b9 URL: https://github.com/kamailio/kamailio/commit/ce19d9212feb0ff4b017b5eaa71e4637a71aa4b9 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-09-09T08:34:08+02:00 siptrace: turn warn in

Re: [sr-dev] [kamailio/kamailio] Db ipv6-address parsing in config file (#2061)

2019-09-08 Thread Daniel-Constantin Mierla
Not supporting IPv6 is a bug, Kamailio is supposed to work on IPv6 for its common use cases. Not sure why support in db_url was not discovered so far missing IPv6, we did a review couple of years ago, but we focused on SIP routing, this was somehow overlooked. If the review of the code is ok, t

Re: [sr-dev] siptrace warning

2019-09-08 Thread Juha Heinanen
Henning Westerholt writes: > just to understand it correctly: > > - is the dialog module loaded and acc generates the warning nevertheless? > > - is the dialog module not loaded, but you don't use the dialog > functionality of acc? Dialog module is not loaded and I'm not tracing dialogs. -- J

[sr-dev] git:master:d80bccc3: github: small additition related to file line endings and windows editors

2019-09-08 Thread Henning Westerholt
Module: kamailio Branch: master Commit: d80bccc3b85256fe0d440cc47c90fc1020ae1d8d URL: https://github.com/kamailio/kamailio/commit/d80bccc3b85256fe0d440cc47c90fc1020ae1d8d Author: Henning Westerholt Committer: Henning Westerholt Date: 2019-09-08T22:57:27+02:00 github: small additition related t

Re: [sr-dev] git:master:1b85430f: lost: added generic P-A-I body parsing

2019-09-08 Thread Henning Westerholt
Hello Wolfgang, it is possible that you edited this files on a windows machine? I just noticed that the files uses Windows style line endings (CRLF) and this would make further collaboration a bit messy if we end up with different style of files in the repository. I will convert the module fil

Re: [sr-dev] git:master:26c13797: core: fix log message with the proper preprocessor directive name

2019-09-08 Thread Henning Westerholt
Hi Daniel, again the subproject commit related to docker in this change set. Strange.. Cheers, Henning Am 06.09.19 um 20:50 schrieb Daniel-Constantin Mierla: > Module: kamailio > Branch: master > Commit: 26c137977d2892f67e80f07759bec17ddfe99172 > URL: > https://github.com/kamailio/kamailio/com

Re: [sr-dev] [kamailio/kamailio] Db ipv6-address parsing in config file (#2061)

2019-09-08 Thread Henning Westerholt
Hello, thank you for the pull request. This is indeed a good addition. I had a look to the code - I think it is good to combine this with a small refactoring in the modules as well. As git master branch is currently frozen, I will put this on hold until 5.3 is released in a few weeks. -- You

[sr-dev] git:5.2:de9a03f1: modules: readme files regenerated - modules ... [skip ci]

2019-09-08 Thread Kamailio Dev
Module: kamailio Branch: 5.2 Commit: de9a03f1353456d8e0165cd673d660c3d8e1e27e URL: https://github.com/kamailio/kamailio/commit/de9a03f1353456d8e0165cd673d660c3d8e1e27e Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-09-08T22:16:41+02:00 modules: readme files regenerated - modules ... [

[sr-dev] git:5.2:307939e8: db_redis: add examples about usage with dialog module

2019-09-08 Thread Henning Westerholt
Module: kamailio Branch: 5.2 Commit: 307939e892877603357af11ff452ca8c62d7bef5 URL: https://github.com/kamailio/kamailio/commit/307939e892877603357af11ff452ca8c62d7bef5 Author: Federico Cabiddu Committer: Henning Westerholt Date: 2019-09-08T22:10:30+02:00 db_redis: add examples about usage with

Re: [sr-dev] siptrace warning

2019-09-08 Thread Henning Westerholt
Hello Juha, just to understand it correctly: - is the dialog module loaded and acc generates the warning nevertheless? - is the dialog module not loaded, but you don't use the dialog functionality of acc? Cheers, Henning Am 07.09.19 um 14:24 schrieb Juha Heinanen: > On masterm, I noticed tha

[sr-dev] [kamailio/kamailio] Db ipv6-address parsing in config file (#2061)

2019-09-08 Thread Alexey Vasilyev
Pre-Submission Checklist